Re: [PATCH v2 06/10] dt-bindings: clock: airoha: Document new property airoha,chip-scu

[Christian Marangi <ansuelsmth@gmail.com>]

On Wed, Jul 16, 2025 at 04:29:12PM +0200, Krzysztof Kozlowski wrote:
> On 27/06/2025 10:20, Christian Marangi wrote:
> > 
> > Here the current DTS [1]. Nothing is stable for this and we can change
> > it but I want to stress that the current HW block are VERY CONFUSING and
> > SCRAMBELED. So it's really a matter of finding the least bad solution.
> > 
> > In SCU there are:
> > - PART fot the clock register
> > - 2 MDIO controller register
> > 
> > In chip SCU:
> > - Other part of the clock register
> > - Thermal driver register
> > - PART of the pinctrl register
> > 
> > [1] https://github.com/Ansuel/openwrt/blob/openwrt-24.10-airoha-an7581-stable/target/linux/airoha/dts/an7583.dtsi#L361
> 
> 
> Thanks and it proves: that's a no. You cannot have two devices with same
> unit address. It means that chip-scu and scu ARE THE SAME devices.
> 

Thanks for checking it. Hope it's clear that

scuclk: system-controller@1fa20000

is a typo and should be

scuclk: system-controller@1fb00000
(to follow the reg property reg = <0x0 0x1fb00000 0x0 0x970>;
 with the 0x970 taken from the documentation)

With this in mind and if your comment still apply do you have any hint
how to better reorganize the 2 node?

-- 
	Ansuel