mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: syzbot <syzbot+fb4362a104d45ab09cf9@syzkaller.appspotmail.com>
To: abbotti@mev.co.uk
Cc: abbotti@mev.co.uk, linux-kernel@vger.kernel.org,
	 syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] [kernel?] KMSAN: kernel-infoleak in do_insnlist_ioctl
Date: Fri, 25 Jul 2025 03:23:55 -0700	[thread overview]
Message-ID: <68835b3b.a00a0220.2f88df.0044.GAE@google.com> (raw)
In-Reply-To: <20250725112352.56640b40@ian-deb>

> #syz test

This crash does not have a reproducer. I cannot test it.

>
> diff --git a/drivers/comedi/comedi_fops.c b/drivers/comedi/comedi_fops.c
> index 23b7178522ae..360fde417016 100644
> --- a/drivers/comedi/comedi_fops.c
> +++ b/drivers/comedi/comedi_fops.c
> @@ -1587,6 +1587,10 @@ static int do_insnlist_ioctl(struct comedi_device *dev,
>  				memset(&data[n], 0, (MIN_SAMPLES - n) *
>  						    sizeof(unsigned int));
>  			}
> +		} else {
> +			unsigned int n_min = max(n, (unsigned int)MIN_SAMPLES);
> +
> +			memset(data, 0, n_min * sizeof(unsigned int));
>  		}
>  		ret = parse_insn(dev, insns + i, data, file);
>  		if (ret < 0)
> @@ -1670,6 +1674,8 @@ static int do_insn_ioctl(struct comedi_device *dev,
>  			memset(&data[insn->n], 0,
>  			       (MIN_SAMPLES - insn->n) * sizeof(unsigned int));
>  		}
> +	} else {
> +		memset(data, 0, n_data * sizeof(unsigned int));
>  	}
>  	ret = parse_insn(dev, insn, data, file);
>  	if (ret < 0)

       reply	other threads:[~2025-07-25 10:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20250725112352.56640b40@ian-deb>
2025-07-25 10:23 ` syzbot [this message]
2025-07-21 19:30 syzbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=68835b3b.a00a0220.2f88df.0044.GAE@google.com \
    --to=syzbot+fb4362a104d45ab09cf9@syzkaller.appspotmail.com \
    --cc=abbotti@mev.co.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=syzkaller-bugs@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®