From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34A59C433EF for ; Thu, 5 May 2022 13:33:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377880AbiEENhJ (ORCPT ); Thu, 5 May 2022 09:37:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47080 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379805AbiEENga (ORCPT ); Thu, 5 May 2022 09:36:30 -0400 Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com [170.10.129.74]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id A6D4F57114 for ; Thu, 5 May 2022 06:32:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1651757546; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+kiADHH0OTUEekRfTTqboMY0mUFLqzmSHiGBuu3QXQA=; b=UTMoBhW4SoONg1+zanmHNFXftfBWlFuobTeaCDOz/J1CgZJR2zF9qJaN5cLiGxwnojQ09P XJCUMKnZdNWW8JuXQZU5P1R6o/GKodqunViH10vBltMaQCShVIWjlv+huAXO/OsE6yVxqw PWjwak1p/BB4gtaqWRM+pTLoxFIQ3ME= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-127-ST_BgvSbPYivES7cdVsQXA-1; Thu, 05 May 2022 09:32:25 -0400 X-MC-Unique: ST_BgvSbPYivES7cdVsQXA-1 Received: by mail-ed1-f69.google.com with SMTP id k13-20020a50ce4d000000b00425e4447e64so2317206edj.22 for ; Thu, 05 May 2022 06:32:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=+kiADHH0OTUEekRfTTqboMY0mUFLqzmSHiGBuu3QXQA=; b=mOOrQ0kI+Hfy0Q+efie6JAOdzX4Im9mV0iuaF52VyUsnXYj692v+3C6gsMhH8vA8ng MQZAL5mjhzN5g1N3WK3RNyhxPoXygMu6qMA9CWlXaDgJY9dLxTCdg4AlnOYMvW6vs0Pe LAOvJDtd+LQWkQfqrSqPRYltzzjZfaVw9rOQKiHeOpoxNH0c6As19B66LX+i89MJsNti TOL20gqk/J/RL+oaBXdyzbhLjWvH5WehVL/dar0+jojRBiJHRupxXk9tsnOP01QU2NMl FpBuCtOrTB/HHZha4CLtf17kuB7mO7TlhvxffqVJgYMOFxu975H22M8QkxkxS56HRlTa CsPg== X-Gm-Message-State: AOAM530+g2Z5uLVHGjyKid3s6YY1yBv+ppvwlZS9oBl7btVJbeCOmQeZ aKEaGTZHAUYLYK6rRNQAnSqzSlYduxXoMPT1/eqIUGSmdCpPZdmP4OcwDp1mdN+NxR2XcgXwS3y e0cmdfDLcUMBQhGJB8puNZndb X-Received: by 2002:a17:907:9053:b0:6f3:9f7e:5325 with SMTP id az19-20020a170907905300b006f39f7e5325mr26644991ejc.455.1651757544355; Thu, 05 May 2022 06:32:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy52UhctkwW9yt5QGwSz6n+bp/2FcbovNN8FC8hnhQ4d8qEEUMnISxAnpY/IrKzXNsv5I+1WQ== X-Received: by 2002:a17:907:9053:b0:6f3:9f7e:5325 with SMTP id az19-20020a170907905300b006f39f7e5325mr26644966ejc.455.1651757544125; Thu, 05 May 2022 06:32:24 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.googlemail.com with ESMTPSA id bc20-20020a056402205400b0042617ba63cesm812545edb.88.2022.05.05.06.32.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 May 2022 06:32:23 -0700 (PDT) Message-ID: <688a817f-b2e2-4620-ef4b-f3c5f73ae34d@redhat.com> Date: Thu, 5 May 2022 15:32:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH] selftests: KVM: aarch64: Let hypercalls use UAPI *_BIT_COUNT Content-Language: en-US To: Marc Zyngier , Oliver Upton Cc: Raghavendra Rao Ananta , Andrew Jones , James Morse , Alexandru Elisei , Suzuki K Poulose , Catalin Marinas , Will Deacon , Peter Shier , Ricardo Koller , Reiji Watanabe , Jing Zhang , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org References: <20220504184415.1905224-1-rananta@google.com> <87zgjw6v9k.wl-maz@kernel.org> From: Paolo Bonzini In-Reply-To: <87zgjw6v9k.wl-maz@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/5/22 14:04, Marc Zyngier wrote: > diff --git a/arch/arm64/include/uapi/asm/kvm.h b/arch/arm64/include/uapi/asm/kvm.h > index e523bb6eac67..3cde9f958eee 100644 > --- a/arch/arm64/include/uapi/asm/kvm.h > +++ b/arch/arm64/include/uapi/asm/kvm.h > @@ -342,6 +342,10 @@ struct kvm_arm_copy_mte_tags { > > enum { > KVM_REG_ARM_STD_BIT_TRNG_V1_0 = 0, > + /* > + * KVM_REG_ARM_STD_BMAP_BIT_COUNT will vary as new services > + * are added, and is explicitely not part of the ABI. > + */ > KVM_REG_ARM_STD_BMAP_BIT_COUNT, > }; That seems like a bad idea. Perhaps you can wrap it in #ifdef __KERNEL_OR_SELFTESTS__? I can't find any prior art. Paolo