mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ryan Brue <ryanbrue.dev@gmail.com>
To: Lyude Paul <lyude@redhat.com>,
	dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
	linux-kernel@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
	linux-pci@vger.kernel.org
Cc: Mark Pearson <mpearson-lenovo@squebb.ca>,
	Timur Tabi <ttabi@nvidia.com>, John Hubbard <jhubbard@nvidia.com>,
	stable@vger.kernel.org
Subject: Re: [PATCH v2] pci: Add broken-GPE quirk for Lenovo Legion 16APH8 and 16AHP9 Nvidia GPUs
Date: Sat, 12 Sep 2026 16:44:48 -0500	[thread overview]
Message-ID: <688b15d1-a85b-492e-ba1e-b4da548ebd06@gmail.com> (raw)
In-Reply-To: <20260821200607.621341-1-lyude@redhat.com>

On 8/21/26 3:04 PM, Lyude Paul wrote:
> On the Lenovo Legion Slim 5 16APH8 and 16AHP9, the firmware appears to enjoy
> firing a GPE on the parent PCIe port of the nvidia GPU very shortly after the
> GPU enters D3Cold. This means that every time the GPU is runtime suspended,
> ACPI firmware immediately wakes up its parent PCIe port, which then wakes up
> the GPU. Once it falls asleep again, the cycle repeats.
>
> See: https://github.com/NVIDIA/open-gpu-kernel-modules/issues/905
>
> Note, this bug doesn't require Nvidia's driver. It happens on nouveau and
> nova as well, and it even seems possible for this to happen without any
> driver loaded.
>
> This seems to simply be a bug. Luckily, there is nothing that we actually
> need ACPI wakeup events for on the GPU. Events such as display connector
> hotplug events in D3Cold come through as ACPI_VIDEO events which aren't
> affected by this quirk.
>
> Reported-by: Ryan Brue <ryanbrue.dev@gmail.com>
> Co-authored-by: Ryan Brue <ryanbrue.dev@gmail.com>
> Signed-off-by: Lyude Paul <lyude@redhat.com>
> Cc: stable@vger.kernel.org
> Fixes: https://github.com/NVIDIA/open-gpu-kernel-modules/issues/905
>
> ---
> V2:
> * Don't forget to actually use parent_adev with acpi_remove_pm_notifier()
> * Check if parent_adev is NULL (could happen if booted with acpi=off), just
>    consider it a no-op if it is.
> * Base the patch off Linux master instead, I based it off drm-misc-next by
>    mistake because I'm too used to working on DRM drivers :).
>
>   drivers/pci/quirks.c | 79 ++++++++++++++++++++++++++++++++++++++++++++
>   1 file changed, 79 insertions(+)
FWIW, this has been tested by me, with positive results, on my Lenovo 
Legion Slim 5 16APH8. Not sure if this warrants a Tested-by trailer 
since I'm a co-author, but just in case.

In the thread [1], we have had another user report positive results on 
their 16AHP9 (note that Lenovo seems to have switched the P and the H 
around for the laptop one generation up for some reason). Said user 
tested on both OpenRM and nouveau on top of kernel 7.1.10.

This means we have tested 16APH8 on nouveau, and 16AHP9 on both OpenRM 
and nouveau.

[1] 
https://github.com/NVIDIA/open-gpu-kernel-modules/issues/905#issuecomment-5444071160 


      reply	other threads:[~2026-09-12 21:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-21 20:04 Lyude Paul
2026-09-12 21:44 ` Ryan Brue [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=688b15d1-a85b-492e-ba1e-b4da548ebd06@gmail.com \
    --to=ryanbrue.dev@gmail.com \
    --cc=bhelgaas@google.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jhubbard@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lyude@redhat.com \
    --cc=mpearson-lenovo@squebb.ca \
    --cc=nouveau@lists.freedesktop.org \
    --cc=stable@vger.kernel.org \
    --cc=ttabi@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®