From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDD74C433FE for ; Sun, 27 Feb 2022 19:28:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231485AbiB0T3F (ORCPT ); Sun, 27 Feb 2022 14:29:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53300 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230444AbiB0T3C (ORCPT ); Sun, 27 Feb 2022 14:29:02 -0500 X-Greylist: delayed 1205 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Sun, 27 Feb 2022 11:28:24 PST Received: from 1.mo548.mail-out.ovh.net (1.mo548.mail-out.ovh.net [178.32.121.110]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 52A315D18E for ; Sun, 27 Feb 2022 11:28:24 -0800 (PST) Received: from mxplan5.mail.ovh.net (unknown [10.109.138.238]) by mo548.mail-out.ovh.net (Postfix) with ESMTPS id 449B420F5D; Sun, 27 Feb 2022 18:50:42 +0000 (UTC) Received: from kaod.org (37.59.142.95) by DAG4EX1.mxp5.local (172.16.2.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.18; Sun, 27 Feb 2022 19:50:40 +0100 Authentication-Results: garm.ovh; auth=pass (GARM-95G0019dbb524f-1c55-405d-97b9-25daac512930, 949565DF20DEE76D4A77FF7731A75FE8B07B1F6B) smtp.auth=clg@kaod.org X-OVh-ClientIp: 82.64.250.170 Message-ID: <688b7a65-d4b6-682b-494a-1d4178699dba@kaod.org> Date: Sun, 27 Feb 2022 19:50:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH 01/10] mtd: spi-nor: aspeed: Rename Kconfig option Content-Language: en-US To: Pratyush Yadav CC: , , Mark Brown , Tudor Ambarus , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , , Joel Stanley , Andrew Jeffery , Chin-Ting Kuo , , Rob Herring , , References: <20220214094231.3753686-1-clg@kaod.org> <20220214094231.3753686-2-clg@kaod.org> <20220225073155.f2cxfhm7surf34d4@ti.com> From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= In-Reply-To: <20220225073155.f2cxfhm7surf34d4@ti.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [37.59.142.95] X-ClientProxiedBy: DAG1EX1.mxp5.local (172.16.2.1) To DAG4EX1.mxp5.local (172.16.2.31) X-Ovh-Tracer-GUID: bc842ac2-478e-418e-8a0a-cc8300debdda X-Ovh-Tracer-Id: 14411800285764684676 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvvddrleekgdduudeiucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepkfffgggfuffvfhfhjggtgfhisehtkeertddtfeejnecuhfhrohhmpeevrogurhhitggpnfgvpgfiohgrthgvrhcuoegtlhhgsehkrghougdrohhrgheqnecuggftrfgrthhtvghrnhepieegvdffkeegfeetuddttddtveduiefhgeduffekiedtkeekteekhfffleevleelnecukfhppedtrddtrddtrddtpdefjedrheelrddugedvrdelheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhhouggvpehsmhhtphhouhhtpdhhvghlohepmhigphhlrghnhedrmhgrihhlrdhovhhhrdhnvghtpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpegtlhhgsehkrghougdrohhrghdpnhgspghrtghpthhtohepuddprhgtphhtthhopehlihhnuhigqdhkvghrnhgvlhesvhhgvghrrdhkvghrnhgvlhdrohhrgh Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/25/22 08:31, Pratyush Yadav wrote: > On 14/02/22 10:42AM, Cédric Le Goater wrote: >> To prepare transition to the new Aspeed SMC SPI controller driver using >> the spi-mem interface, change the kernel CONFIG option of the current >> driver to reflect that the implementation uses the MTD SPI-NOR interface. >> Once the new driver is sufficiently exposed, we should remove the old one. > > I don't quite understand the reasoning behind this. Why keep the old > driver around? Why not directly replace it with the new one? Does the > new one have any limitations that this one doesn't? No. The old one has more limitations than the new one. The old one in mainline is half baked since we could never merge the necessary bits for training. We have been keeping a full version on the OpenBMC tree. Joel, could we simply drop the old driver in mainline and keep the old one in the OpenBMC tree until we feel comfortable ? I guess we need more testing. Thanks, C. >