From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Banajit Goswami <bgoswami@quicinc.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: qcom: reduce number of binding headers includes
Date: Thu, 5 Oct 2023 09:27:03 +0200 [thread overview]
Message-ID: <688c0678-fad8-490a-9f1e-bb0caffee129@linaro.org> (raw)
In-Reply-To: <20231004163030.670039-1-krzysztof.kozlowski@linaro.org>
On 04/10/2023 18:30, Krzysztof Kozlowski wrote:
> Move the includes of binding headers from Qualcomm SoC sound drivers
> headers to unit files actually using these bindings. This reduces the
> amount of work for C preprocessor and makes usage of bindings easier to
> follow. No impact expected on final binaries.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> sound/soc/qcom/apq8016_sbc.c | 1 +
> sound/soc/qcom/common.c | 2 +-
> sound/soc/qcom/lpass-cdc-dma.c | 1 +
> sound/soc/qcom/lpass-cpu.c | 1 +
> sound/soc/qcom/lpass-platform.c | 1 +
> sound/soc/qcom/lpass.h | 1 -
> sound/soc/qcom/qdsp6/q6afe-clocks.c | 1 +
> sound/soc/qcom/qdsp6/q6afe-dai.c | 1 +
> sound/soc/qcom/qdsp6/q6afe.c | 1 +
> sound/soc/qcom/qdsp6/q6afe.h | 2 --
> sound/soc/qcom/qdsp6/q6apm-lpass-dais.c | 1 +
> sound/soc/qcom/qdsp6/q6apm.h | 1 -
> sound/soc/qcom/qdsp6/q6asm-dai.c | 1 +
> sound/soc/qcom/qdsp6/q6asm.c | 1 +
> sound/soc/qcom/qdsp6/q6asm.h | 1 -
> sound/soc/qcom/qdsp6/q6prm-clocks.c | 2 +-
> sound/soc/qcom/qdsp6/q6routing.c | 2 ++
> sound/soc/qcom/sc7180.c | 2 +-
> sound/soc/qcom/sc7280.c | 2 ++
> sound/soc/qcom/sc8280xp.c | 1 +
> sound/soc/qcom/sdm845.c | 1 +
> sound/soc/qcom/sdw.c | 2 +-
> sound/soc/qcom/sm8250.c | 1 +
I missed few cases of header dependencies, as pointed out by kbuild. I
will send v2.
Best regards,
Krzysztof
prev parent reply other threads:[~2023-10-05 14:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-04 16:30 Krzysztof Kozlowski
2023-10-05 7:27 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=688c0678-fad8-490a-9f1e-bb0caffee129@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@quicinc.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®