From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753582AbdKHV34 (ORCPT ); Wed, 8 Nov 2017 16:29:56 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:49866 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752833AbdKHV3f (ORCPT ); Wed, 8 Nov 2017 16:29:35 -0500 Subject: Re: [PATCH 3/6] target: Fix quiese during transport_write_pending_qf endless loop To: "Nicholas A. Bellinger" , target-devel Cc: linux-scsi , lkml , Mike Christie , Hannes Reinecke , Michael Cyr , Potnuri Bharat Teja , Sagi Grimberg References: <1510115512-15617-1-git-send-email-nab@linux-iscsi.org> <1510115512-15617-4-git-send-email-nab@linux-iscsi.org> From: "Bryant G. Ly" Date: Wed, 8 Nov 2017 15:29:27 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1510115512-15617-4-git-send-email-nab@linux-iscsi.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-TM-AS-GCONF: 00 x-cbid: 17110821-0048-0000-0000-000002025BE7 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00008033; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000239; SDB=6.00943072; UDB=6.00475780; IPR=6.00723359; BA=6.00005679; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00017916; XFM=3.00000015; UTC=2017-11-08 21:29:31 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17110821-0049-0000-0000-0000431DA8EF Message-Id: <6892cffb-3734-7bd7-aa42-1d91b70ee57b@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-11-08_03:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1711080282 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > From: Nicholas Bellinger > > This patch fixes a potential end-less loop during QUEUE_FULL, > where cmd->se_tfo->write_pending() callback fails repeatedly > but __transport_wait_for_tasks() has already been invoked to > quiese the outstanding se_cmd descriptor. > > To address this bug, this patch adds a CMD_T_STOP|CMD_T_ABORTED > check within transport_write_pending_qf() and invokes the > existing se_cmd->t_transport_stop_comp to signal quiese > completion back to __transport_wait_for_tasks(). > > Cc: Mike Christie > Cc: Hannes Reinecke > Cc: Bryant G. Ly > Cc: Michael Cyr > Cc: Potnuri Bharat Teja > Cc: Sagi Grimberg > Signed-off-by: Nicholas Bellinger > --- > Reviewed-by: Bryant G. Ly