From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BCBAC7EE22 for ; Sun, 14 May 2023 08:16:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232968AbjENIPM (ORCPT ); Sun, 14 May 2023 04:15:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229462AbjENIPK (ORCPT ); Sun, 14 May 2023 04:15:10 -0400 X-Greylist: delayed 600 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Sun, 14 May 2023 01:15:07 PDT Received: from air.basealt.ru (air.basealt.ru [194.107.17.39]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E66002125; Sun, 14 May 2023 01:15:07 -0700 (PDT) Received: by air.basealt.ru (Postfix, from userid 490) id 7251D2F20227; Sun, 14 May 2023 07:59:50 +0000 (UTC) Received: from [192.168.120.181] (unknown [176.59.56.94]) by air.basealt.ru (Postfix) with ESMTPSA id 52EE52F20226; Sun, 14 May 2023 07:59:46 +0000 (UTC) Message-ID: <6894e9f7-7100-255b-b026-5ccf485a7e31@basealt.ru> Date: Sun, 14 May 2023 10:59:44 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH] e1000e: Fix bind network card with ID = 0x0D4F To: "Neftin, Sasha" , kovalev@altlinux.org, nickel@altlinux.org, jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com, davem@davemloft.net, kuba@kernel.org, jeffrey.t.kirsher@intel.com, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, pabeni@redhat.com, edumazet@google.com, "Ruinskiy, Dima" , "Fuxbrumer, Devora" , "naamax.meir" References: <20230512231944.100501-1-kovalev@altlinux.org> Content-Language: en-US From: =?UTF-8?B?0JLQsNGB0LjQu9C40Lkg0JrQvtCy0LDQu9C10LI=?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 14.05.2023 09:00, Neftin, Sasha пишет: >> Fixes: 914ee9c436cbe9 ("e1000e: Add support for Comet Lake") >> Signed-off-by: Vasiliy Kovalev >> --- >>   drivers/net/ethernet/intel/e1000e/netdev.c | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c >> b/drivers/net/ethernet/intel/e1000e/netdev.c >> index db8e06157da29..8b13f19309c39 100644 >> --- a/drivers/net/ethernet/intel/e1000e/netdev.c >> +++ b/drivers/net/ethernet/intel/e1000e/netdev.c >> @@ -7887,7 +7887,7 @@ static const struct pci_device_id >> e1000_pci_tbl[] = { >>       { PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_ICP_I219_LM9), >> board_pch_cnp }, >>       { PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_ICP_I219_V9), >> board_pch_cnp }, >>       { PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_CMP_I219_LM10), >> board_pch_cnp }, >> -    { PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_CMP_I219_V10), >> board_pch_cnp }, >> +    { PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_CMP_I219_V10), >> board_pch_adp }, > This is wrong approach. (we can not process old board similar as new) >>       { PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_CMP_I219_LM11), >> board_pch_cnp }, >>       { PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_CMP_I219_V11), >> board_pch_cnp }, >>       { PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_CMP_I219_LM12), >> board_pch_spt }, > Looking in commit 639e298f432fb0 (e1000e: Fix packet loss on Tiger > Lake and later) I would suggest to replace the mac->type as follow: > "if (mac->type >= e1000_pch_tgp)" with "if (mac->type >= > e1000_pch_cnp)" (more correct) - try it on your side. I checked this variant first of all - the behavior is correct, network packets are not lost. Can I prepare a new patch or will this change be made by you? -- Best regards, Vasiliy Kovalev