From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E038CCA489 for ; Tue, 26 Jul 2022 11:25:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231492AbiGZLZ0 (ORCPT ); Tue, 26 Jul 2022 07:25:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40030 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233080AbiGZLZX (ORCPT ); Tue, 26 Jul 2022 07:25:23 -0400 Received: from alexa-out.qualcomm.com (alexa-out.qualcomm.com [129.46.98.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73C521E3F8; Tue, 26 Jul 2022 04:25:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1658834723; x=1690370723; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=TgsY3kSUDq559VWKlBJhSI8YVwFY9gdL6CTg2MQlcG8=; b=wjO5vkwlHvM6lkCMeUJErEnq8BxEniMvXR6yTlx3g9W3N/Pgo3OP6hBo peysYxRuQ1MbtRZD4t2EHPTCYFTWTdjHTtCZffFa66WeJr7gexJb306N6 uqgcIVbjEE6fGdRI7zTAaUqF3uiDcgOTxErgd6QCX8VX8AvLPStvIZaij I=; Received: from ironmsg09-lv.qualcomm.com ([10.47.202.153]) by alexa-out.qualcomm.com with ESMTP; 26 Jul 2022 04:25:22 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg09-lv.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jul 2022 04:25:21 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Tue, 26 Jul 2022 04:25:21 -0700 Received: from [10.79.43.230] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Tue, 26 Jul 2022 04:25:17 -0700 Subject: Re: [PATCH 03/10] soc: qcom: icc-bwmon: drop unused BWMON_ZONE_COUNT To: Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , "Konrad Dybcio" , Georgi Djakov , Rob Herring , , , , CC: Rajendra Nayak References: <20220720192807.130098-1-krzysztof.kozlowski@linaro.org> <20220720192807.130098-4-krzysztof.kozlowski@linaro.org> From: Sibi Sankar Message-ID: <689ae7a0-bb23-8264-a2ff-40b1b5bbf0af@quicinc.com> Date: Tue, 26 Jul 2022 16:55:14 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20220720192807.130098-4-krzysztof.kozlowski@linaro.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hey Krzysztof, Thanks for working on the llcc bwmon patch series! On 7/21/22 12:58 AM, Krzysztof Kozlowski wrote: > BWMON_ZONE_COUNT define is not used. > > Cc: Rajendra Nayak > Signed-off-by: Krzysztof Kozlowski > --- > drivers/soc/qcom/icc-bwmon.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/soc/qcom/icc-bwmon.c b/drivers/soc/qcom/icc-bwmon.c > index 3415f42523cd..b76a59d9002c 100644 > --- a/drivers/soc/qcom/icc-bwmon.c > +++ b/drivers/soc/qcom/icc-bwmon.c > @@ -105,7 +105,6 @@ > > /* BWMONv4 count registers use count unit of 64 kB */ > #define BWMON_COUNT_UNIT_KB 64 > -#define BWMON_ZONE_COUNT 0x2d8 Apart from ^^ a few more defines like BWMON_GLOBAL_IRQ_STATUS, THRESHOLD_COUNT_ZONE2_SHIFT were unused as well. Reviewed-by: Sibi Sankar > #define BWMON_ZONE_MAX(zone) (0x2e0 + 4 * (zone)) > > struct icc_bwmon_data { >