mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sergey Ryazanov <ryazanov.s.a@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: haozhe chang <haozhe.chang@mediatek.com>,
	Loic Poulain <loic.poulain@linaro.org>,
	Johannes Berg <johannes@sipsolutions.net>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net-next v1 1/1] wwan: core: Use the bitmap API to allocate bitmaps
Date: Mon, 28 Aug 2023 21:06:09 +0300	[thread overview]
Message-ID: <689ae7b5-0b73-3cb3-5d9c-5ae23e36ee85@gmail.com> (raw)
In-Reply-To: <20230828131953.3721392-1-andriy.shevchenko@linux.intel.com>

On 28.08.2023 16:19, Andy Shevchenko wrote:
> Use bitmap_zalloc() and bitmap_free() instead of hand-writing them.
> It is less verbose and it improves the type checking and semantic.
> 
> While at it, add missing header inclusion (should be bitops.h,
> but with the above change it becomes bitmap.h).
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Make sense. Thank you.

BTW, any plans to update __dev_alloc_name(), which was used as 
reference, in the same way?

Reviewed-by: Sergey Ryazanov <ryazanov.s.a@gmail.com>

  reply	other threads:[~2023-08-28 18:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-28 13:19 Andy Shevchenko
2023-08-28 18:06 ` Sergey Ryazanov [this message]
2023-08-29 13:24   ` Andy Shevchenko
2023-08-28 19:45 ` Jakub Kicinski
2023-08-29 13:26   ` Andy Shevchenko
2023-08-30 13:48 ` Loic Poulain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=689ae7b5-0b73-3cb3-5d9c-5ae23e36ee85@gmail.com \
    --to=ryazanov.s.a@gmail.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=haozhe.chang@mediatek.com \
    --cc=johannes@sipsolutions.net \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=loic.poulain@linaro.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®