From: Jacob Keller <jacob.e.keller@intel.com>
To: Nishanth Menon <nm@ti.com>, Jakub Kicinski <kuba@kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"David S. Miller" <davem@davemloft.net>
Cc: "Simon Horman" <horms@kernel.org>,
"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
"Eric Dumazet" <edumazet@google.com>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"Santosh Shilimkar" <ssantosh@kernel.org>,
"Siddharth Vadapalli" <s-vadapalli@ti.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH V3] net: ethernet: ti: netcp: Standardize knav_dma_open_channel to return NULL on error
Date: Wed, 29 Oct 2025 13:07:54 -0700 [thread overview]
Message-ID: <68a4b852-4eeb-4f97-af2a-58714b59be97@intel.com> (raw)
In-Reply-To: <20251029132310.3087247-1-nm@ti.com>
[-- Attachment #1.1: Type: text/plain, Size: 767 bytes --]
On 10/29/2025 6:23 AM, Nishanth Menon wrote:
> diff --git a/drivers/soc/ti/knav_dma.c b/drivers/soc/ti/knav_dma.c
> index a25ebe6cd503..e69f0946de29 100644
> --- a/drivers/soc/ti/knav_dma.c
> +++ b/drivers/soc/ti/knav_dma.c
> @@ -402,7 +402,7 @@ static int of_channel_match_helper(struct device_node *np, const char *name,
> * @name: slave channel name
> * @config: dma configuration parameters
> *
> - * Returns pointer to appropriate DMA channel on success or error.
> + * Returns pointer to appropriate DMA channel on success or NULL on error.
> */
Minor nit: you could make this a proper kdoc returns by using "Return:"
or "Returns:" here to introduce this as a section instead of just a comment.
That would fix a kdoc warning too.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]
prev parent reply other threads:[~2025-10-29 20:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-29 13:23 Nishanth Menon
2025-10-29 20:07 ` Jacob Keller
2025-10-29 20:07 ` Jacob Keller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68a4b852-4eeb-4f97-af2a-58714b59be97@intel.com \
--to=jacob.e.keller@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nm@ti.com \
--cc=pabeni@redhat.com \
--cc=s-vadapalli@ti.com \
--cc=ssantosh@kernel.org \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®