From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F33873F54DB for ; Mon, 15 Jun 2026 14:33:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781534007; cv=none; b=ljABS491+LNAkRMlPykI10ylAEdTtMMH3QwzbJhZ7LxRw3Tp8YZqB2nJxzKWLPn6iPMiM0w5x2A7Xi6G3wyIz+OHWRW6xoBqLsbeOtDVIjlzhepFGiBTGAV6zyRN0itvxC3IT2nniJ9D64G8NVWEWWEYwBgBPSXS8x6pNQfdgJ4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781534007; c=relaxed/simple; bh=MA2HC+nJuMiryx7fCp6ddzKKGYKPWzCZYFTJWhzzEMg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RByyzyBtp6sMrRrxR1tzXzSZ4eyFdXBH2CDeFnq7vvXKo7bqVkrEz95dFa7Yuz6Q/MlXozqlPJ4XJD4O1E18Mmb+imaTwz2MYTjDMhgy689NWDMjHRKAh3CsZTs0eEUvei5Uz5gWAc5ysVj25ms1wXk7pu6r2n9EX6yFneX+hVw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=IIIKCZUO; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RP68iyYT; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="IIIKCZUO"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RP68iyYT" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65FCZbGY4116663 for ; Mon, 15 Jun 2026 14:33:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= dv9ZEji4B7BwWDkbahrAwa3+NSTzy2uFpYlUp/k2i20=; b=IIIKCZUOuSR0VYK4 Gf+utiApakgUA5qcs85b3UpmsFTr/tBUAWA3O7meipFTIwDiq6ITlxTtNoh2Tfbd 7Q2DXAP2QniCBWFpuB+SzVc6SmBzW9Pdg7/cxMmmvZKpEub0XzGMJjaCrxz69hDG f6JYf1qwBrCU65y1PqWr1NrBl1fjbg/QbR8pvUj118NSpsEUX4XdFTVCKwxO7FAW oN05kJfvdOPreHVl+hczdCnXgpWQzx7CtOrnhb9j8yZonCOf6Nw4DiNc14sVwEGf r08gEkBzLrGkIqYcKBCyWJMO4Wq7wmRzyRoRmlwoRpNOxIV1okqdza3d7Ef9uuJs 8reKBw== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4etetjs6s1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 15 Jun 2026 14:33:24 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-917fd2bafdbso56509785a.3 for ; Mon, 15 Jun 2026 07:33:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781534003; x=1782138803; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=dv9ZEji4B7BwWDkbahrAwa3+NSTzy2uFpYlUp/k2i20=; b=RP68iyYTHYd6iWNw6ZsuB0SyQrWhW9GlLIJakGQOgD+5gdqd0hv0zwwdwyDp59YRkZ TgPN5lvh6nxKhHqlaBA4wd7/0wgXG2xPF6h920J8hnFJcWr1uCi9ta61nOlUv38nFCxj WTA6t9jxIjWbhf9fkLrXoz8mOKK1OJYrCII4GfcOPDdbQyJPOpiSYG9KEYsuEnMflIqt maM+Zlci1dVF1K7fPWVd+Ku8Mx19qCpqwJZAJfmymOS5ppu9NqiaVXrDxuxkSWlWG/De BT0Ai7zhal+hHTX2q+uGBKOfme95wzgWFv8WKBn2D2IXE5jNcJJApuEBDnKKOKw4xtLC FW3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781534003; x=1782138803; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dv9ZEji4B7BwWDkbahrAwa3+NSTzy2uFpYlUp/k2i20=; b=kBYy4OysH3U5gnNDL2TcwAdTzuDZy341f/8AiOUm8BK+ICe98BnIQfJi9Lr0crO42g 8ublyklb8NsEP5cKqIQcWdtU642Uw3L6uP66tnFxGYKuvXmKl0xLG1dFW/xwW5nAoIkv 6AXs1/7aqxzUuCMKwVoUd2K1cQPIDMBmmJxoty6ZV3K/2OpUaLYJNssDR4c2VXv/YXT8 n3mOutJhM6wZni6MMTNP5ecSKnWbnUm0LfUzl30avAV1j9zk8vV2KVIaKE11zH8EOa57 1QL+aUT/WDzE1MQzBrlYaSzK770tlN/lXj01HmufCHDSAnNs6SWEbHy3LQdE3zKoadiV stLg== X-Forwarded-Encrypted: i=1; AFNElJ8ZZzSxon+tiU7N7R3lh67JA6qBF6DCNBOCaZeKbsPH04fnK2J1++tZmpfWeXzxc8O+Hpc4j2fDs9HsClY=@vger.kernel.org X-Gm-Message-State: AOJu0Yzahj17PpnFopCMV8rhse6sdpXqdAJ2054QSmmEBaFId21/sk2c ApMMAu1s8MBI+9h3cAnm8oL7lGVNfhjRb9xJ3M7h2b02yUuDwhL/EsZYS0Sf17owrMe9Wigvdc7 DIhyKlF3ThaVw99pYECb8malpCBsvsFmQTfun+Ot7B7mXANQ+dfdm9c5fQHCeZjp9Z4k= X-Gm-Gg: Acq92OEzgm2lHG3IfmMTiA94s2DGBmbLDxxrn3iXycfR2MwyXkSaXeMkbyw/kYiADOB Z6NNd4XL8u1l3X9xtQvZ3tgEwuOlRbeyhxCBeqdPJxpVYVOsbELekn8YZXeWsINCC2jr2Sq0lHC npl8jRvlwqqXKzQTTJHpxG6y+ivHw3n9CH96dTQ8JVK8C6nHAjd92LE0aqXFQqbMfCtqRXV/adO SNvNaSkwGIEnuUa72AqXX7CnQyd7s0J8RcP9l3ShzsJ7YHdOr4SDCSIkCjEQrHkMOSDFst1N/lr wil/PXAVMg/uzkZm2M7CLNZs+CQbwgh9wEzgp8AbCFxNS16hFS3xwU9j0ZkMtbXQO/CPo9w7noz x2Pl6/HXAYVDIK9sJJQAOEr/rXqgT30mVfcxKz8oDjdky4w== X-Received: by 2002:a05:620a:2714:b0:911:295d:59a1 with SMTP id af79cd13be357-9161bd4df47mr1315442185a.8.1781534003164; Mon, 15 Jun 2026 07:33:23 -0700 (PDT) X-Received: by 2002:a05:620a:2714:b0:911:295d:59a1 with SMTP id af79cd13be357-9161bd4df47mr1315435385a.8.1781534002504; Mon, 15 Jun 2026 07:33:22 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5ad2e1b421bsm2863645e87.73.2026.06.15.07.33.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Jun 2026 07:33:20 -0700 (PDT) Message-ID: <68a86037-bba0-4cab-8a1f-b0be78f259db@oss.qualcomm.com> Date: Mon, 15 Jun 2026 16:33:17 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/4] clk: qcom: common: introduce qcom_cc_sync_state() To: Brian Masney , Dmitry Baryshkov Cc: Val Packett , Saravana Kannan , Abel Vesa , Maxime Ripard , Michael Turquette , Stephen Boyd , Russell King , Bjorn Andersson , Hans de Goede , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20260603-clk-sync-state-v1-0-457120eed200@redhat.com> <20260603-clk-sync-state-v1-2-457120eed200@redhat.com> <2f6dbc37-7ee5-4cef-b39e-455494fb31fd@packett.cool> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE1MDE1MiBTYWx0ZWRfX1RSPiKg+vyWu zmXL9bcNI1bsHzyuKU7C26cgDOGNncDyYtyGCaSy0qYnT+x1n6eQmHJMFnN0GoJeven8cyB8Ycn C6PSv4Mum5TQJCRnu79f7yeKCL0E+NYNdT18FHfvBGiq/ahCvXhOrD/Br9dAVxFF/YCUGbZz9Ud /nEdXOrzU0UHJ8xgyWxGoYmxbKd/G0bnYpbQLIySnstsJY0phtHMfeIVQKPq3r/f1XsJ0ebsMwn uJyoGASb2DH2tsc9i/p+wPuUwfb2kDhSsiG1DUvrt2SdmAIyc8FVWI9eiALlrMWbovlsffsjM9s BtE8aDhNEiw/zQ446ohmstJKD1/8JOYUL7W/YjQBezOGuDoo7PzIhF+q7BqoZlok6UTDuBGCf5C YMBd/EnhbuFCDH5yvvsDpg9ugc5GbcBnQqaCKuRvQaLA2cKoPaSNZEbaW/BDfWdQIj+7eG7RkTk w2jW0apd2Bqm/rji+GQ== X-Proofpoint-ORIG-GUID: Mf0rvQ0B-H4J2WbZB9se0cwR-JVFN1Cu X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE1MDE1MiBTYWx0ZWRfX/267swUY7oDx 17gxaN/0jgmz+tENL+qgcJP89LNydsEsmF1+LnJ52mSSG7W6I1ZmiJNJxaXpDoGvj+3ZJuWszHB t88pWfp3wnIpYOzDawGVPhxrA7QsthM= X-Authority-Analysis: v=2.4 cv=HttG3UTS c=1 sm=1 tr=0 ts=6a300d34 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=4N5aaHjLVSWDVt9tEy4A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-GUID: Mf0rvQ0B-H4J2WbZB9se0cwR-JVFN1Cu X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-15_03,2026-06-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 spamscore=0 suspectscore=0 clxscore=1015 impostorscore=0 malwarescore=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606150152 On 6/15/26 4:24 PM, Brian Masney wrote: > Hi Dmitry, > > On Sun, Jun 07, 2026 at 01:30:03PM +0300, Dmitry Baryshkov wrote: >> On Sun, Jun 07, 2026 at 01:43:06AM -0300, Val Packett wrote: >>> >>> On 6/6/26 8:15 AM, Dmitry Baryshkov wrote: >>>> On Wed, Jun 03, 2026 at 10:21:47AM -0400, Brian Masney wrote: >>>>> Several qcom clk providers currently have a sync_state helper set to >>>>> icc_sync_state(). With an upcoming change to the clk framework, if >>>>> sync_state is not defined for the device, then the clk framework sets it >>>>> to clk_sync_state(). >>>>> [..] >>>>> @@ -464,5 +466,12 @@ int qcom_cc_probe_by_index(struct platform_device *pdev, int index, >>>>> } >>>>> EXPORT_SYMBOL_GPL(qcom_cc_probe_by_index); >>>>> +void qcom_cc_sync_state(struct device *dev) >>>>> +{ >>>>> + icc_sync_state(dev); >>>> Only if desc->icc_hws != 0, otherwise it will mess the interconnect >>>> internals. You might need to set drvdata to desc. >>> >>> Hmm… >>> >>> Currently icc_sync_state does not seem to use the dev argument at all. >>> >>> How would something get messed up, now or whenever icc_sync_state changes? >>> o.0 >> >> Yes :-( > > Sorry about the delayed response since I was out of town all last week. > Just to be clear, the missing check for 'desc->icc_hws != 0' is a bug that > existed prior to my change, and I should label it as such with a Fixes > tag when I post my next version? Up until this change, having icc_hws > 0 but lacking icc_sync_state (or the reverse) would be be considered programmer error Starting with patch 4, this gets assigned unconditionally, so there's no prior bug to be fixed Konrad