From: Juergen Gross <jgross@suse.com>
To: Jason Wang <wangborong@cdjrlc.com>
Cc: boris.ostrovsky@oracle.com, sstabellini@kernel.org,
xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xen/pciback: fix typo in a comment
Date: Wed, 15 Dec 2021 09:55:39 +0100 [thread overview]
Message-ID: <68aa97ae-dd76-5879-3dba-a08c3581f25b@suse.com> (raw)
In-Reply-To: <20211212032408.52180-1-wangborong@cdjrlc.com>
[-- Attachment #1.1.1: Type: text/plain, Size: 962 bytes --]
On 12.12.21 04:24, Jason Wang wrote:
> The double `the' in the comment in line 163 is repeated. Remove it
> from the comment.
>
> Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
> ---
> drivers/xen/xen-pciback/pciback_ops.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/xen/xen-pciback/pciback_ops.c b/drivers/xen/xen-pciback/pciback_ops.c
> index 3fbc21466a93..e38b43b5065e 100644
> --- a/drivers/xen/xen-pciback/pciback_ops.c
> +++ b/drivers/xen/xen-pciback/pciback_ops.c
> @@ -160,7 +160,7 @@ int xen_pcibk_enable_msi(struct xen_pcibk_device *pdev,
> }
>
> /* The value the guest needs is actually the IDT vector, not the
> - * the local domain's IRQ number. */
> + * local domain's IRQ number. */
When touching this comment, would you mind to correct its style, too?
It should have a leading "/*" and a trailing "*/" line like e.g. in
line 72 of the same source file.
Juergen
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3135 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
prev parent reply other threads:[~2021-12-15 8:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-12 3:24 Jason Wang
2021-12-15 8:55 ` Juergen Gross [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68aa97ae-dd76-5879-3dba-a08c3581f25b@suse.com \
--to=jgross@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sstabellini@kernel.org \
--cc=wangborong@cdjrlc.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®