mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jie Gan <jie.gan@oss.qualcomm.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Abel Vesa <abelvesa@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] arm64: dts: qcom: hamoa: Add CoreSight nodes for APSS debug block
Date: Wed, 14 Oct 2026 09:13:28 +0800	[thread overview]
Message-ID: <68acff8e-2696-4ff9-9bfa-3b23e2b15fd1@oss.qualcomm.com> (raw)
In-Reply-To: <7fccb993-8605-4eb6-afd5-94edef1d487d@oss.qualcomm.com>



On 10/13/2026 8:46 PM, Konrad Dybcio wrote:
> On 9/22/26 12:35 PM, Jie Gan wrote:
>> The APSS debug block is built with CoreSight devices like ETM,
>> replicator, funnel and TMC ETF. Add dt nodes for these devices to enable
>> ETM trace.
>>
>> The replicator, funnel and TMC ETF nodes in this block are physically
>> powered by the CPU cluster power rail rather than by a dedicated always-on
>> rail. Add a power-domains property referencing the corresponding
>> cluster_pdN domain to each of these nodes, so their power state is
>> tied to the CPU cluster domain and the runtime PM core can power the
>> domain on before the devices are accessed and let it be powered off
>> otherwise.
>>
>> Signed-off-by: Jie Gan <jie.gan@oss.qualcomm.com>
>> ---
> 
> [...]
> 
>> +		funnel@12080000 {
>> +			compatible = "arm,coresight-dynamic-funnel", "arm,primecell";
>> +			reg = <0x0 0x12080000 0x0 0x1000>;
>> +
>> +			clocks = <&aoss_qmp>;
>> +			clock-names = "apb_pclk";
>> +
>> +			in-ports {
> 
> No need for power-domains here? (also same question for the other
> platforms)

The power-domain only adds to the devices within the cluster. This 
funnel device doesnt sit in the CPU clusters.

Thanks,
Jie

> 
> Konrad


  reply	other threads:[~2026-10-14  1:13 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-22 10:35 [PATCH 0/4] Add ETM devices for multiple QCOM platforms Jie Gan
2026-09-22 10:35 ` [PATCH 1/4] arm64: dts: qcom: hamoa: Add CoreSight nodes for APSS debug block Jie Gan
2026-10-13 12:46   ` Konrad Dybcio
2026-10-14  1:13     ` Jie Gan [this message]
2026-09-22 10:35 ` [PATCH 2/4] arm64: dts: qcom: sm8750: " Jie Gan
2026-09-22 10:35 ` [PATCH 3/4] arm64: dts: qcom: kaanapali: " Jie Gan
2026-10-13 12:49   ` Konrad Dybcio
2026-10-14  1:23     ` Jie Gan
2026-10-15  2:26       ` Jie Gan
2026-10-15  9:06         ` Konrad Dybcio
2026-09-22 10:35 ` [PATCH 4/4] arm64: dts: qcom: glymur: " Jie Gan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=68acff8e-2696-4ff9-9bfa-3b23e2b15fd1@oss.qualcomm.com \
    --to=jie.gan@oss.qualcomm.com \
    --cc=abelvesa@kernel.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®