mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Eli Billauer <eli.billauer@gmail.com>
To: Marco Crivellari <marco.crivellari@suse.com>,
	linux-kernel@vger.kernel.org
Cc: Tejun Heo <tj@kernel.org>, Lai Jiangshan <jiangshanlai@gmail.com>,
	Frederic Weisbecker <frederic@kernel.org>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Michal Hocko <mhocko@suse.com>, Arnd Bergmann <arnd@arndb.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] char: xillybus: add WQ_PERCPU to alloc_workqueue users
Date: Fri, 7 Nov 2025 15:52:17 +0100	[thread overview]
Message-ID: <68ad3747-a912-7644-d9c3-e6137da4e555@outbound.gmail.com> (raw)
In-Reply-To: <20251106163048.334400-1-marco.crivellari@suse.com>

Hello Marco,

Thanks for this heads-up. Frankly speaking, I wasn't aware that the said 
calls to alloc_workqueue() implicitly bind the queue to a CPU, and this 
was never my intention. I agree that the better choice is an unbound 
queue, at least in this case.

This seems to be an example for why the API change of alloc_workqueue() 
is a good idea.

As for the patch itself, it perpetuates the incorrect choice, so I vote 
against. If anything, WQ_UNBOUND should be added, but since it's going 
to be the default (soon?), maybe just let it be, and let the planned 
change in the API rectify this.

Thanks,
   Eli

  reply	other threads:[~2025-11-07 14:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-06 16:30 Marco Crivellari
2025-11-07 14:52 ` Eli Billauer [this message]
2025-11-07 14:57   ` Marco Crivellari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=68ad3747-a912-7644-d9c3-e6137da4e555@outbound.gmail.com \
    --to=eli.billauer@gmail.com \
    --cc=arnd@arndb.de \
    --cc=bigeasy@linutronix.de \
    --cc=frederic@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jiangshanlai@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marco.crivellari@suse.com \
    --cc=mhocko@suse.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®