mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Viacheslav Dubeyko <vdubeyko@redhat.com>
To: Alex Markuze <amarkuze@redhat.com>, ceph-devel@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, idryomov@gmail.com
Subject: Re: [EXTERNAL] [PATCH v2 7/7] ceph: add manual reset selftests and validation harness
Date: Fri, 17 Apr 2026 11:48:09 -0700	[thread overview]
Message-ID: <68b2b3eb55e7e44ae574c5caa0ef910cf088ed00.camel@redhat.com> (raw)
In-Reply-To: <20260415170043.3882912-8-amarkuze@redhat.com>

On Wed, 2026-04-15 at 17:00 +0000, Alex Markuze wrote:
> Add single-client selftests and a validation wrapper for manual
> client reset.
> 
> The test set covers reset stress under concurrent metadata
> activity together with targeted corner cases for overlap,
> dirty-state handling, stale lock behavior, and unmount while reset
> is active.  A validation wrapper runs the individual stages with
> watchdog timeouts and captures the final reset status for post-run
> checks.
> 
> The stress validator checks failure_count in addition to
> last_errno so that transient mid-run reset failures are caught
> even when a later reset succeeds.
> 
> Keep the test scope intentionally focused on the shipped
> single-client reset behavior so the series includes a practical
> regression signal for the final design.
> 
> Signed-off-by: Alex Markuze <amarkuze@redhat.com>
> ---
>  MAINTAINERS                                   |   1 +
>  tools/testing/selftests/Makefile              |   1 +
>  .../selftests/filesystems/ceph/Makefile       |   7 +
>  .../selftests/filesystems/ceph/README.md      |  84 +++
>  .../filesystems/ceph/reset_corner_cases.sh    | 646 ++++++++++++++++
>  .../filesystems/ceph/reset_stress.sh          | 694 ++++++++++++++++++
>  .../filesystems/ceph/run_validation.sh        | 350 +++++++++
>  .../selftests/filesystems/ceph/settings       |   1 +
>  .../filesystems/ceph/validate_consistency.py  | 297 ++++++++
>  9 files changed, 2081 insertions(+)
>  create mode 100644 tools/testing/selftests/filesystems/ceph/Makefile
>  create mode 100644 tools/testing/selftests/filesystems/ceph/README.md
>  create mode 100755 tools/testing/selftests/filesystems/ceph/reset_corner_cases.sh
>  create mode 100755 tools/testing/selftests/filesystems/ceph/reset_stress.sh
>  create mode 100755 tools/testing/selftests/filesystems/ceph/run_validation.sh
>  create mode 100644 tools/testing/selftests/filesystems/ceph/settings
>  create mode 100755 tools/testing/selftests/filesystems/ceph/validate_consistency.py
> 

The patch is really huge. I really like that we would like to add the selftests
for CephFS kernel client. But it's impossible to review it. It needs to be split
on several patches.

Thanks,
Slava. 


      reply	other threads:[~2026-04-17 18:48 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-15 17:00 [PATCH v2 0/7] ceph: manual client session reset Alex Markuze
2026-04-15 17:00 ` [PATCH v2 1/7] ceph: convert inode flags to named bit positions and atomic bitops Alex Markuze
2026-04-15 19:54   ` [EXTERNAL] " Viacheslav Dubeyko
2026-04-16 12:46     ` Alex Markuze
2026-04-15 17:00 ` [PATCH v2 2/7] ceph: use proper endian conversion for flock_len in reconnect Alex Markuze
2026-04-15 19:57   ` [EXTERNAL] " Viacheslav Dubeyko
2026-04-15 17:00 ` [PATCH v2 3/7] ceph: harden send_mds_reconnect and handle active-MDS peer reset Alex Markuze
2026-04-16 19:33   ` [EXTERNAL] " Viacheslav Dubeyko
2026-04-15 17:00 ` [PATCH v2 4/7] ceph: add diagnostic timeout loop to wait_caps_flush() Alex Markuze
2026-04-16 19:55   ` [EXTERNAL] " Viacheslav Dubeyko
2026-04-15 17:00 ` [PATCH v2 5/7] ceph: add client reset state machine and session teardown Alex Markuze
2026-04-16 21:50   ` [EXTERNAL] " Viacheslav Dubeyko
2026-04-15 17:00 ` [PATCH v2 6/7] ceph: add manual reset debugfs control and tracepoints Alex Markuze
2026-04-17 18:41   ` [EXTERNAL] " Viacheslav Dubeyko
2026-04-15 17:00 ` [PATCH v2 7/7] ceph: add manual reset selftests and validation harness Alex Markuze
2026-04-17 18:48   ` Viacheslav Dubeyko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=68b2b3eb55e7e44ae574c5caa0ef910cf088ed00.camel@redhat.com \
    --to=vdubeyko@redhat.com \
    --cc=amarkuze@redhat.com \
    --cc=ceph-devel@vger.kernel.org \
    --cc=idryomov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome