From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7CDB22D8399 for ; Wed, 22 Apr 2026 04:57:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776833847; cv=none; b=QTXqwNXP0Mvz6wciwrtm+2ZwCJSHhVFOngPw4XGHgS5B7eF5TCMyqlnwS39L3SUSECA5O5DTKVCOsD7TWRIzjWGeaL6/SlyUmtxDzMULLouM2YWtKiWIjWFbeoPOezEUsDT7BN+/jJAh5Jr3ORybhF0N6Nt9bH8a3uH3+1/XOLQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776833847; c=relaxed/simple; bh=B6WDchifhqJuslyH7LmkVSzSCTbAuHIA9VyWinoP1D0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Cs4J9BEidpJrM+QEF/CrXzVXbOCHHRHnKPxHw4pByLqxK9Q7r9wfesokUJW9iNR35mtlk7n9YEzWAEs8adTm5swZRB0mRQ8R7jcCLOepXkdBwXEjD52lOZFagpglAM9jt4AkX6bwzspx4ZBsjnVDjvol2+QnWTEZBabRpCVx2vQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=RMYJTctW; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=kBB0q5bp; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="RMYJTctW"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="kBB0q5bp" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776833844; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=0L9goOndJ0ZNAN3NWrENW0DDl37Vxtxj2sxDGwaEk+o=; b=RMYJTctWKr+PWP2jMT5bAhTR2Xtejevum+9+OFS5RXCmvXz8owahj1P4EJahR2ywrbtBNV bDQWBBr5aPb0/vQmJ7zA4972RsTOQCNJA/j4Gx6UIiS8SrN8QxHdWXYZj5xsLLXFIwTZ9H 7v5I+N9l3YQsyna1iqfzBE86Xrfqfmc= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-428-kwn8rlbTMwyTPK3BLDwGkA-1; Wed, 22 Apr 2026 00:57:22 -0400 X-MC-Unique: kwn8rlbTMwyTPK3BLDwGkA-1 X-Mimecast-MFC-AGG-ID: kwn8rlbTMwyTPK3BLDwGkA_1776833841 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-48a5952c635so5213065e9.2 for ; Tue, 21 Apr 2026 21:57:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1776833841; x=1777438641; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=0L9goOndJ0ZNAN3NWrENW0DDl37Vxtxj2sxDGwaEk+o=; b=kBB0q5bpuCEFaOcsmd5e5ZNOQ23AP6I8jlh8/fMb+AQBW2PgRWg2hzjDo0XCcsN3A0 04b8GhmklLzd+8HrpzjaXrRKMIZuOFWWLVtYhUU/g5U5x0N2TdPtz52hJc4atacu20vK GhG3HNpswoXhMQTwk0DbuYBTzmt2c/lEhRWIzYQN/2Svj6I2cESTUeYMT+LSxSGZ3LDZ kS10yOj4m/IsadjsWc/x06jazW+I2cfX1fHjQjNuW+CbPpmkDQOu4ZDIwKLzrSekSgQ1 VIo14fGg7eeIVSuxkrh8VeZv+GxMBgJNTo7777jKj6+xGSxtG/pwH05y/OzzMvGjlFyg wPAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776833841; x=1777438641; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0L9goOndJ0ZNAN3NWrENW0DDl37Vxtxj2sxDGwaEk+o=; b=GyMv3IthHJ7OLNNdZsOUaO0hgVeLP3H52zHVCizA62dFG3axTECXvj95saRpGrIoXf l0uiTvQYuad1j5XsOaZbBhHYV7S8MBzccl1inmCbRXgnMHKhaV6d5OimPXZ0v8GxyoPb aePSlFZQ6p9vNy3ECQV+5MW3IxyeNAz4ReYLuVJ9s16mBxk1Px9zbmCnKMG2oypAXnLW y6j8hq4OjB85yfdtbqK5F8u60J+sQSdFV5G2nyPe6hSh6ekZwFg0C5VnqU0wTiuFZeir cwV3XfLkywQkMXfWigBZlXwNrDqm7x8ew0Y6vJVo8nL+L+i4JDjSMCUm0/VsGJvnA6T4 zOAA== X-Forwarded-Encrypted: i=1; AFNElJ+aHQNzNthiCilgIN1j/Seg8Hv7cF5otPYfB0tjumH1Kb0ajzKU/XeSj6SzUUtzmBpG352jR5BmOnUu+1U=@vger.kernel.org X-Gm-Message-State: AOJu0YxfiqrQz2bUBVPyuUmRcLrHVu5N0wTVrcmi+x6zMZfK4EoaTR46 lRq2rcICikD35+P2fNLlOoUcUOpZnEaz7FH87E1KR3v8Jaw7dXZx/gLwdIX+6PJkwHRMQXYbxmJ QHE+mrjK7FvA8pAIb7VKMRwF3C8cMC969lyU1xaDzuAaDKl9gJGfdPcfmKHdYAbQifcruXVq9Pw == X-Gm-Gg: AeBDievg4M0eWD4l3kqxZgw2ayaqTryQspdsXPNV2RCyL8HzJ8RBpVBgHDnlI7lXa4j v4XG25EW/MDl4rLFEZq9aySxQ31xkYntYDvth1+J+X7NGLqHGIHn+a9PW6KiTd9YDFRs/p2rSB2 oTnnIHWwDDnUpoPJWnHqJ3iPPFfQkQyq3SdSo7699VaMkmXuJDKFqWfvqnPpogCO5LruzvT1Ttl C4xKN639O0Lr35EGLR7oT/Bl9qiWsslz9CjzPCyQ/wJsTFcPt8NMiU1/+10ScYCaxEA9cMf6HRD SHJtdIAxT+yVFs73+KoNl50dJ0LfUqaidZXlC4Ktq13jcUURPSWW6U/AdzS2Pn1mSO1qIP9ytAB Ii4oAFPWiNf+Ve1wMhdnTPrqOuKgg0A== X-Received: by 2002:a05:600c:48a1:b0:489:a4:e58a with SMTP id 5b1f17b1804b1-48900a4e881mr160289945e9.19.1776833841108; Tue, 21 Apr 2026 21:57:21 -0700 (PDT) X-Received: by 2002:a05:600c:48a1:b0:489:a4:e58a with SMTP id 5b1f17b1804b1-48900a4e881mr160289815e9.19.1776833840649; Tue, 21 Apr 2026 21:57:20 -0700 (PDT) Received: from [192.168.0.9] ([47.64.114.147]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4891c318636sm217434155e9.7.2026.04.21.21.57.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Apr 2026 21:57:19 -0700 (PDT) Message-ID: <68b36ad0-2233-49d0-a3a6-bce053686bf1@redhat.com> Date: Wed, 22 Apr 2026 06:57:18 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] xen/arm: Replace __ASSEMBLY__ with __ASSEMBLER__ in interface.h To: Stefano Stabellini Cc: Juergen Gross , Oleksandr Tyshchenko , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org References: <20260421142701.548978-1-thuth@redhat.com> Content-Language: en-US From: Thomas Huth Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzR5UaG9tYXMgSHV0 aCA8dGh1dGhAcmVkaGF0LmNvbT7CwXgEEwECACIFAlVgX6oCGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAAoJEC7Z13T+cC21EbIP/ii9cvT2HHGbFRl8HqGT6+7Wkb+XLMqJBMAIGiQK QIP3xk1HPTsLfVG0ao4hy/oYkGNOP8+ubLnZen6Yq3zAFiMhQ44lvgigDYJo3Ve59gfe99KX EbtB+X95ODARkq0McR6OAsPNJ7gpEUzfkQUUJTXRDQXfG/FX303Gvk+YU0spm2tsIKPl6AmV 1CegDljzjycyfJbk418MQmMu2T82kjrkEofUO2a24ed3VGC0/Uz//XCR2ZTo+vBoBUQl41BD eFFtoCSrzo3yPFS+w5fkH9NT8ChdpSlbNS32NhYQhJtr9zjWyFRf0Zk+T/1P7ECn6gTEkp5k ofFIA4MFBc/fXbaDRtBmPB0N9pqTFApIUI4vuFPPO0JDrII9dLwZ6lO9EKiwuVlvr1wwzsgq zJTPBU3qHaUO4d/8G+gD7AL/6T4zi8Jo/GmjBsnYaTzbm94lf0CjXjsOX3seMhaE6WAZOQQG tZHAO1kAPWpaxne+wtgMKthyPLNwelLf+xzGvrIKvLX6QuLoWMnWldu22z2ICVnLQChlR9d6 WW8QFEpo/FK7omuS8KvvopFcOOdlbFMM8Y/8vBgVMSsK6fsYUhruny/PahprPbYGiNIhKqz7 UvgyZVl4pBFjTaz/SbimTk210vIlkDyy1WuS8Zsn0htv4+jQPgo9rqFE4mipJjy/iboDzsFN BFH7eUwBEAC2nzfUeeI8dv0C4qrfCPze6NkryUflEut9WwHhfXCLjtvCjnoGqFelH/PE9NF4 4VPSCdvD1SSmFVzu6T9qWdcwMSaC+e7G/z0/AhBfqTeosAF5XvKQlAb9ZPkdDr7YN0a1XDfa +NgA+JZB4ROyBZFFAwNHT+HCnyzy0v9Sh3BgJJwfpXHH2l3LfncvV8rgFv0bvdr70U+On2XH 5bApOyW1WpIG5KPJlDdzcQTyptOJ1dnEHfwnABEfzI3dNf63rlxsGouX/NFRRRNqkdClQR3K gCwciaXfZ7ir7fF0u1N2UuLsWA8Ei1JrNypk+MRxhbvdQC4tyZCZ8mVDk+QOK6pyK2f4rMf/ WmqxNTtAVmNuZIwnJdjRMMSs4W4w6N/bRvpqtykSqx7VXcgqtv6eqoDZrNuhGbekQA0sAnCJ VPArerAZGArm63o39me/bRUQeQVSxEBmg66yshF9HkcUPGVeC4B0TPwz+HFcVhheo6hoJjLq knFOPLRj+0h+ZL+D0GenyqD3CyuyeTT5dGcNU9qT74bdSr20k/CklvI7S9yoQje8BeQAHtdV cvO8XCLrpGuw9SgOS7OP5oI26a0548M4KldAY+kqX6XVphEw3/6U1KTf7WxW5zYLTtadjISB X9xsRWSU+Yqs3C7oN5TIPSoj9tXMoxZkCIHWvnqGwZ7JhwARAQABwsFfBBgBAgAJBQJR+3lM AhsMAAoJEC7Z13T+cC21hPAQAIsBL9MdGpdEpvXs9CYrBkd6tS9mbaSWj6XBDfA1AEdQkBOn ZH1Qt7HJesk+qNSnLv6+jP4VwqK5AFMrKJ6IjE7jqgzGxtcZnvSjeDGPF1h2CKZQPpTw890k fy18AvgFHkVk2Oylyexw3aOBsXg6ukN44vIFqPoc+YSU0+0QIdYJp/XFsgWxnFIMYwDpxSHS 5fdDxUjsk3UBHZx+IhFjs2siVZi5wnHIqM7eK9abr2cK2weInTBwXwqVWjsXZ4tq5+jQrwDK cvxIcwXdUTLGxc4/Z/VRH1PZSvfQxdxMGmNTGaXVNfdFZjm4fz0mz+OUi6AHC4CZpwnsliGV ODqwX8Y1zic9viSTbKS01ZNp175POyWViUk9qisPZB7ypfSIVSEULrL347qY/hm9ahhqmn17 Ng255syASv3ehvX7iwWDfzXbA0/TVaqwa1YIkec+/8miicV0zMP9siRcYQkyTqSzaTFBBmqD oiT+z+/E59qj/EKfyce3sbC9XLjXv3mHMrq1tKX4G7IJGnS989E/fg6crv6NHae9Ckm7+lSs IQu4bBP2GxiRQ+NV3iV/KU3ebMRzqIC//DCOxzQNFNJAKldPe/bKZMCxEqtVoRkuJtNdp/5a yXFZ6TfE1hGKrDBYAm4vrnZ4CXFSBDllL59cFFOJCkn4Xboj/aVxxJxF30bn In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 22/04/2026 00.15, Stefano Stabellini wrote: > On Tue, 21 Apr 2026, Thomas Huth wrote: >> From: Thomas Huth >> >> While the GCC and Clang compilers already define __ASSEMBLER__ >> automatically when compiling assembly code, __ASSEMBLY__ is a >> macro that only gets defined by the Makefiles in the kernel. >> This can be very confusing when switching between userspace >> and kernelspace coding, or when dealing with uapi headers that >> rather should use __ASSEMBLER__ instead. So let's standardize now >> on the __ASSEMBLER__ macro that is provided by the compilers. >> >> Signed-off-by: Thomas Huth > > I haven't been closely following the __ASSEMBLER__ vs __ASSEMBLY__ > discussion. If there is general agreement to use __ASSEMBLER__ in > headers, I am happy to go along with that. Currently, I see more than > 140 uses of __ASSEMBLY__ compared to fewer than 20 uses of > __ASSEMBLER__, but I'll defer to your judgment if the project is moving > in that direction. I assume you only counted the occurrences in the main include/ folder? Please also take the arch/*/include/ folders into account: thuth:~/devel/linux$ grep -r __ASSEMBLER__ arch/*/include/ | wc -l 1492 thuth:~/devel/linux$ grep -r __ASSEMBLY__ arch/*/include/ | wc -l 120 So most spots have been converted already. It would be great if you could help with the xen header! Thanks, Thomas