From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6492C2248BE for ; Tue, 14 Apr 2026 19:16:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776194205; cv=none; b=eRypYIy2w6sYaaaN7rFOmhALwtOLrjHVw1GKhP6+0iotlCtl52NJafg8Y56l3SfrSGHHCSEp2b8PLybzc8JDI2HfGce+Zorp0ecrdZlsmUT1u1jB5KF7q8xVyFpW+dfwGX+osVExeNbwK4r7Zrx15nxkNoCPifnx8PI+QAGY5X4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776194205; c=relaxed/simple; bh=Kae0NE+YEJhUab058VBKfamPJWyW4Acc1sAaLV1mvK8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=GMsGVJawhEYg4txDZg25YEtLDDGcCiu8xXVX2189cv8fWC1NQDiR1Umr6uqyCaTA5tQu/tooxMQkK4aiHSf0T6i9SIyZElfZcOluNVl393pILyvO5HnM5sa/CUv7pSmaFw8V+zxPKOAaVE5XKZmJJxa2anhwQaMVbOyXaT89NtU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=VkXUI/g3; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=CZc0h0BB; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="VkXUI/g3"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="CZc0h0BB" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776194203; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OTjtecZ1iSoz/j8YichwBmmBonCgsoUrO3OWetqEhiA=; b=VkXUI/g3loQQhli1XAfsiBcPhnQp2D8gazeJm1BeE7LV0CmO3h2XYmys1NHsUzUbdmPQuM +K6a1nDIAOK70lYigaHfmycOpHY/qjl4HptgUpa458wIHvrSyDRphExyTZiQgoBuoHk7MX fztJBky3cuYkx0lIqX2MIb38iNlvAYc= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-235-BfWXZo0HMvaoMuzPkQzkYA-1; Tue, 14 Apr 2026 15:16:41 -0400 X-MC-Unique: BfWXZo0HMvaoMuzPkQzkYA-1 X-Mimecast-MFC-AGG-ID: BfWXZo0HMvaoMuzPkQzkYA_1776194201 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-43d73770e7bso392644f8f.1 for ; Tue, 14 Apr 2026 12:16:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1776194200; x=1776799000; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=OTjtecZ1iSoz/j8YichwBmmBonCgsoUrO3OWetqEhiA=; b=CZc0h0BBHebzAQF43E2qGZQtbW/NgvHje5YzLeEep/dCp8IEAO26vA3r6OBLDnjo2T yqfo6k66OuFSMtKue2t2GIXaJMoyXJyD5OeNwMPQylYuLUHwnsDX48+zmaTl9/IM+GW1 PegyOPxw7rvsq09a8y/MnA0SEivQwobtvrSi4G0g9Xwj/x/otdmX4KkAL1KhVGHyuR0s fjpLZfUd6LnFR7NeN1mcIyO6VAmhxk8gwgybYEPksrVA4VkLOMWih/mh80I/9DbPKx1K Sz3hoEu9pruz/zpWSSA87yaxnzHROSZVvUhWGepuDM7sEnTcHeGPyJx5pS4xv0Hxarhn yXHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776194200; x=1776799000; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OTjtecZ1iSoz/j8YichwBmmBonCgsoUrO3OWetqEhiA=; b=dU+LupLPvLPmEQZ37Pv6WoV0xzTT+Z8EaMElB/ZXaJfL/IDX+ujfPAZ67ioujmxqoi +ANZfjQM1QSlXKVRiIAVpdhbQgWDxAzXwqxPR1Xl5FWwzycK912NvLdxOj1i/0+tAG7W YVb2Hb+8Ve+ReiFvIrimvbuNwA84mqY/K6TBx6Yc7+vya8EGWgcUt8cr8tVu0H7GufAI 6YjYR6l7H+kQVjeI/91Em5SS5Zx/TG5GKPicw7GzNFwmpxxOnf44FFw9OVl3mvB1G029 7Tc9mK7RbLclufjYgJQsXihXVkZpud4kXKOa18EsfsVqlJu5AKVdbHxMGRO1Uubb+wbj 9dag== X-Forwarded-Encrypted: i=1; AFNElJ8VaUqTAHMPUZOlj2ZLls3vlEt/nbPNlwdGEChB5Am7PGtZq+xUJ8pJo9ruYBvu6zOqKin2DWDRzyn2iRc=@vger.kernel.org X-Gm-Message-State: AOJu0Ywc3QUHQnZ4jJIIY0vmYI1thKvdSa3rYozeKTrHaerdQbnjhxKp 96HNfSg3lnijWgqZpd+pXxNYXsOBDQTyKVk8w11mSuljRizQKpSi0X6gZ7wObuLkag2lWmUMmG2 3/eBYkBFGa5XJ0ztXTEXFRlwDLH/wclQnYlydZSS8P18GvLUGvjNjO8dxz+Ur+5mQYQ== X-Gm-Gg: AeBDieuMQxGs8N+jSdmMc0SUl3K6tGTUtPhghA10PW8PIlc8QNchTGI7/NVux95G0Fg oE55wxSGUhDTRPhh3m/hSPGJS+V4kITvN77Q2dnsbNfdn5qLh6wjRee/pu/G5qm9fK3HS93yVnd FrPxt4/SBxWKIwHIPYL/8XmoTkB/gvBY+tYRuDK5zv6TDVHOFQzxgk4lTnlockrPztuEly9fdnn pDd6ji87dkAfO+HsbiGhQ9nMDE5kt3yTt1t0dKOUy1ZdG9S7pLk+pdqb/X6BW810CCzZ86ybuoI LkNe6FGxmFk1mroAanUyIyyYbNdPfx6FaXiSW3gtwigAOiBeMaCa91b/BIbYiSWACUe8Eqo2KmN dmRzjwkliVAWVB1Ae2v9Z9Ode6jGBpY1Uw9vG/rPO/eZdzXU= X-Received: by 2002:a05:600c:4689:b0:485:358b:e7ee with SMTP id 5b1f17b1804b1-488d6655c82mr155399375e9.0.1776194200609; Tue, 14 Apr 2026 12:16:40 -0700 (PDT) X-Received: by 2002:a05:600c:4689:b0:485:358b:e7ee with SMTP id 5b1f17b1804b1-488d6655c82mr155399085e9.0.1776194200138; Tue, 14 Apr 2026 12:16:40 -0700 (PDT) Received: from [192.168.1.77] (109-81-81-198.rct.o2.cz. [109.81.81.198]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43d73b44b3esm27090422f8f.13.2026.04.14.12.16.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Apr 2026 12:16:39 -0700 (PDT) Message-ID: <68b5cc9d-81d2-4ff5-9d3e-a6d6746dcb3e@redhat.com> Date: Tue, 14 Apr 2026 21:16:37 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH iwl-net v5] ice: fix missing dpll notifications for SW pins To: Petr Oros , netdev@vger.kernel.org Cc: Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Arkadiusz Kubalewski , intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org References: <20260409102501.1447628-1-poros@redhat.com> Content-Language: en-US From: Michal Schmidt In-Reply-To: <20260409102501.1447628-1-poros@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/9/26 12:25, Petr Oros wrote: > --- > drivers/net/ethernet/intel/ice/ice_dpll.c | 74 +++++++++++++++++++---- > 1 file changed, 63 insertions(+), 11 deletions(-) > > diff --git a/drivers/net/ethernet/intel/ice/ice_dpll.c b/drivers/net/ethernet/intel/ice/ice_dpll.c > index 3f8cd5b8298b57..d817f17dcf1951 100644 > --- a/drivers/net/ethernet/intel/ice/ice_dpll.c > +++ b/drivers/net/ethernet/intel/ice/ice_dpll.c > @@ -1154,6 +1154,30 @@ ice_dpll_input_state_get(const struct dpll_pin *pin, void *pin_priv, > extack, ICE_DPLL_PIN_TYPE_INPUT); > } > > +/** > + * ice_dpll_sw_pin_notify_peer - notify the paired SW pin after a state change > + * @d: pointer to dplls struct > + * @changed: the SW pin that was explicitly changed (already notified by dpll core) > + * > + * SMA and U.FL pins share physical signal paths in pairs (SMA1/U.FL1 and > + * SMA2/U.FL2). When one pin's routing changes via the PCA9575 GPIO > + * expander, the paired pin's state may also change. Send a change > + * notification for the peer pin so userspace consumers monitoring the > + * peer via dpll netlink learn about the update. > + * > + * Context: Can be called under pf->dplls.lock, dpll_pin_change_ntf() is safe. > + */ > +static void ice_dpll_sw_pin_notify_peer(struct ice_dplls *d, > + struct ice_dpll_pin *changed) > +{ > + struct ice_dpll_pin *peer; > + > + peer = (changed >= d->sma && changed < d->sma + ICE_DPLL_PIN_SW_NUM) ? > + &d->ufl[changed->idx] : &d->sma[changed->idx]; > + if (peer->pin) > + dpll_pin_change_ntf(peer->pin); > +} > + > /** > * ice_dpll_sma_direction_set - set direction of SMA pin > * @p: pointer to a pin > @@ -1233,6 +1257,8 @@ static int ice_dpll_sma_direction_set(struct ice_dpll_pin *p, > ret = ice_dpll_pin_state_update(p->pf, target, > type, extack); > } > + if (!ret) > + ice_dpll_sw_pin_notify_peer(d, p); > > return ret; > } ice_dpll_sma_direction_set() runs to process a DPLL_CMD_PIN_SET command from userspace. It runs with dpll_lock held - taken in dpll_pin_pre_doit(). ice_dpll_sw_pin_notify_peer() -> dpll_pin_change_ntf() will take dpll_lock again and deadlock. Michal