mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Terry Bowman <terry.bowman@amd.com>
To: Calvin Walton <calvin.walton@kepstin.ca>,
	lenb@kernel.org, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] tools/power turbostat: Fix RAPL summary collection on AMD processors
Date: Fri, 16 Apr 2021 06:42:39 -0500	[thread overview]
Message-ID: <68be4830-36ec-85ad-56ae-ee3cf9b9589c@amd.com> (raw)
In-Reply-To: <17d15837848eddd8445b206356531b9b5aae644b.camel@kepstin.ca>


Hi Calvin,

Thanks for the feedback. I'll begin making the change and testing. I'll 
respond with V2 patch in this thread.

Regards,
Terry


On 4/14/21 9:13 PM, Calvin Walton wrote:
> On Tue, 2021-03-30 at 21:38 +0000, Terry Bowman wrote:
>> +int idx_valid_amd(int idx)
>> +{
>> +       switch (idx) {
>> +       case IDX_PKG_ENERGY:
>> +               return do_rapl & MSR_PKG_ENERGY_STAT;
> This isn't correct - MSR_PKG_ENERGY_STAT is the MSR offset, not a bit
> mask for the do_rapl bit field.
>
> The presence of MSR_PKG_ENERGY_STAT (along with MSR_RAPL_PWR_UNIT and
> MSR_CORE_ENERGY_STAT) is indicated by the RAPL_AMD_F17H bit in do_rapl,
> and can be checked with:
> 	do_rapl & RAPL_AMD_F17H
>
>

  reply	other threads:[~2021-04-16 11:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-30 21:38 Terry Bowman
2021-04-15  2:13 ` Calvin Walton
2021-04-16 11:42   ` Terry Bowman [this message]
2021-04-16 14:50     ` Calvin Walton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=68be4830-36ec-85ad-56ae-ee3cf9b9589c@amd.com \
    --to=terry.bowman@amd.com \
    --cc=calvin.walton@kepstin.ca \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®