From: Alexander Gordeev <agordeev@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Alexander Gordeev <agordeev@redhat.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Steven Rostedt <rostedt@goodmis.org>
Subject: [PATCH v2 5/9] rcu: Limit rcu_state::levelcnt[] to RCU_NUM_LVLS items
Date: Fri, 29 May 2015 11:53:41 +0200 [thread overview]
Message-ID: <68c1ca24d1e93e78c541cac9ca02c19eb6e7341a.1432889921.git.agordeev@redhat.com> (raw)
In-Reply-To: <cover.1432889921.git.agordeev@redhat.com>
Variable rcu_num_lvls is limited by RCU_NUM_LVLS macro.
In turn, rcu_state::levelcnt[] array is never accessed
beyond rcu_num_lvls. Thus, rcu_state::levelcnt[] is safe
to limit to RCU_NUM_LVLS items.
Since rcu_num_lvls could be changed during boot (as result
of rcutree.rcu_fanout_leaf kernel parameter update) one might
assume a new value could overflow the value of RCU_NUM_LVLS.
However, that is not the case, since leaf-level fanout is only
permitted to increase, resulting in rcu_num_lvls possibly to
decrease.
Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
---
kernel/rcu/tree.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/rcu/tree.h b/kernel/rcu/tree.h
index f1f4784..a6faae5 100644
--- a/kernel/rcu/tree.h
+++ b/kernel/rcu/tree.h
@@ -443,7 +443,7 @@ do { \
struct rcu_state {
struct rcu_node node[NUM_RCU_NODES]; /* Hierarchy. */
struct rcu_node *level[RCU_NUM_LVLS]; /* Hierarchy levels. */
- u32 levelcnt[MAX_RCU_LVLS + 1]; /* # nodes in each level. */
+ u32 levelcnt[RCU_NUM_LVLS]; /* # nodes in each level. */
u8 levelspread[RCU_NUM_LVLS]; /* kids/node in each level. */
u8 flavor_mask; /* bit in flavor mask. */
struct rcu_data __percpu *rda; /* pointer of percu rcu_data. */
--
1.8.3.1
next prev parent reply other threads:[~2015-05-29 9:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-29 9:53 [PATCH v2 0/9] rcu: Cleanup RCU tree initialization Alexander Gordeev
2015-05-29 9:53 ` [PATCH v2 1/9] rcu: Panic if RCU tree can not accommodate all CPUs Alexander Gordeev
2015-06-01 18:37 ` Paul E. McKenney
2015-06-02 6:45 ` Alexander Gordeev
2015-06-02 12:37 ` Paul E. McKenney
2015-05-29 9:53 ` [PATCH v2 2/9] rcu: Remove superfluous local variable in rcu_init_geometry() Alexander Gordeev
2015-05-29 9:53 ` [PATCH v2 3/9] rcu: Cleanup rcu_init_geometry() code and arithmetics Alexander Gordeev
2015-05-29 9:53 ` [PATCH v2 4/9] rcu: Simplify rcu_init_geometry() capacity arithmetics Alexander Gordeev
2015-05-29 9:53 ` Alexander Gordeev [this message]
2015-05-29 9:53 ` [PATCH v2 6/9] rcu: Limit rcu_capacity[] size to RCU_NUM_LVLS items Alexander Gordeev
2015-05-29 9:53 ` [PATCH v2 7/9] rcu: Remove unnecessary fields from rcu_state structure Alexander Gordeev
2015-05-29 9:53 ` [PATCH v2 8/9] rcu: Limit count of static data to the number of RCU levels Alexander Gordeev
2015-05-29 9:53 ` [PATCH v2 9/9] rcu: Simplify arithmetic to calculate number of RCU nodes Alexander Gordeev
2015-06-01 18:58 ` [PATCH v2 0/9] rcu: Cleanup RCU tree initialization Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68c1ca24d1e93e78c541cac9ca02c19eb6e7341a.1432889921.git.agordeev@redhat.com \
--to=agordeev@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®