From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C82A62F693A for ; Thu, 11 Dec 2025 15:17:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765466259; cv=pass; b=Ix3PLjZxKeceDjgWLMOeyWujqeVNwbrprgYqaTmS0l0j3G0RZhtB3CZeHc2/FlDqx814CN4UHcvkA64QZhvw/6GPLDS+QGg+kxv5wrcbEQAO1sQAZ0pgvvnPTLgzXQB9BGLjbxfDE274apUfDs3UjhiWXAYHvKCAcJX8pOyaBKM= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765466259; c=relaxed/simple; bh=7SLLaCZ9LboEDq8pwJgCXJRVxsIz0/Qi7j+UtiexKzs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=aKt4EABNh2utn0wmW5R1QZ+xTG+8TT6RkAdWOWW2wWNRwgsrsQxWSl6bE0PjON8gdA7BRZ9vFtjGxbM9bgKcJakKLjcSLI50eM5KqN8xTL+6hPPDbHEWNsqsmJ7TzMAF394yamCb4PKQMENLX98sZKQFD3JQeEfpuZhsS99wgdk= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=ariel.dalessandro@collabora.com header.b=L/jXXvCB; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=ariel.dalessandro@collabora.com header.b="L/jXXvCB" ARC-Seal: i=1; a=rsa-sha256; t=1765466188; cv=none; d=zohomail.com; s=zohoarc; b=L9VYmwF1ZV8mBvucp3svl+n1MZEnWQ04BL2BhNVuEMK6dCSfOeQuAT97cDSJwI2UtS5eS+maNpMT36+E1J9CzLenf0SwAHPud6VltN4mVmuujvF+jwhF8COSljdNWrlZT/Y/wOvAOC01CvvYY5bjjmtQaHkZdf/a+uLsc16RwWE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1765466188; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=N/SEPPS3LkYORhwqK+Trj2yot7q9tIQx0jdFwhoKT5g=; b=Yv5af2b0YtOIVbVBwQckS9812m+mnbuhUpQ4QpChqPvKJwPrZkAnyBH0ciyo6jBkiGQTMPUGEoez+4bySY1CUTrunn3Earx6ny21zE6HODfZe6SesicfMLmZQu8RGOHO0UvdGh0TcLON91nyH2W4xLfWl4K95ch6Wn3HUu69A6U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=ariel.dalessandro@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1765466188; s=zohomail; d=collabora.com; i=ariel.dalessandro@collabora.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=N/SEPPS3LkYORhwqK+Trj2yot7q9tIQx0jdFwhoKT5g=; b=L/jXXvCBWUVNoYDSVpKQzIj0UZfcnyE8Lh8Z2YHt8KxEHygIUMmoLAroU/yz9igs IHcH9pFbI6OQw8HIoZSj+W+05VcMrgEAQmqiNCbwAlVPkFT3iJ1IBBc9QiyKK5pMI0M h8uNTJ5v12VQvdswTB6xWbFG8lMowpjEs86OuFbU= Received: by mx.zohomail.com with SMTPS id 1765466186652613.9579128013164; Thu, 11 Dec 2025 07:16:26 -0800 (PST) Message-ID: <68c83842-16e9-429b-96c8-50c8a15c659c@collabora.com> Date: Thu, 11 Dec 2025 12:16:08 -0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC v2 07/20] drm/atomic: Pass post_blend_color_pipeline client cap to atomic check To: Harry Wentland , =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Chun-Kuang Hu , Philipp Zabel , Matthias Brugger , AngeloGioacchino Del Regno , Haneen Mohammed , Melissa Wen Cc: Alex Hung , wayland-devel@lists.freedesktop.org, leo.liu@amd.com, ville.syrjala@linux.intel.com, pekka.paalanen@collabora.com, contact@emersion.fr, mwen@igalia.com, jadahl@redhat.com, sebastian.wick@redhat.com, shashank.sharma@amd.com, agoins@nvidia.com, joshua@froggi.es, mdaenzer@redhat.com, aleixpol@kde.org, xaver.hugl@gmail.com, victoria@system76.com, uma.shankar@intel.com, quic_naseer@quicinc.com, quic_cbraga@quicinc.com, quic_abhinavk@quicinc.com, marcan@marcan.st, Liviu.Dudau@arm.com, sashamcintosh@google.com, chaitanya.kumar.borah@intel.com, louis.chauvet@bootlin.com, mcanal@igalia.com, kernel@collabora.com, daniels@collabora.com, leandro.ribeiro@collabora.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Simona Vetter References: <20250917-mtk-post-blend-color-pipeline-v2-0-ac4471b44758@collabora.com> <20250917-mtk-post-blend-color-pipeline-v2-7-ac4471b44758@collabora.com> <93edf489-c4f6-4f0d-a0d5-673da051983d@amd.com> Content-Language: en-US From: Ariel D'Alessandro In-Reply-To: <93edf489-c4f6-4f0d-a0d5-673da051983d@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ZohoMailClient: External X-ZohoMail-Owner: <68c83842-16e9-429b-96c8-50c8a15c659c@collabora.com>+zmo_0_ariel.dalessandro@collabora.com Harry, On 9/29/25 6:50 AM, Harry Wentland wrote: > > > On 2025-09-17 20:43, Nícolas F. R. A. Prado wrote: >> Pass the state of the post-blend color pipeline client cap to the atomic >> state so that drivers can rely on it to enable color pipeline >> functionality and ignore the deprecated color management CRTC >> properties. >> >> Signed-off-by: Nícolas F. R. A. Prado >> --- >>   drivers/gpu/drm/drm_atomic_uapi.c |  1 + >>   include/drm/drm_atomic.h          | 20 ++++++++++++++++++++ >>   2 files changed, 21 insertions(+) >> >> diff --git a/drivers/gpu/drm/drm_atomic_uapi.c b/drivers/gpu/drm/ >> drm_atomic_uapi.c >> index >> f5125fa3fa28ff2a6ff07fd7cf07d4bdf77ab738..56a440a9390c7730c4c41b491f29b933a2bbb889 100644 >> --- a/drivers/gpu/drm/drm_atomic_uapi.c >> +++ b/drivers/gpu/drm/drm_atomic_uapi.c >> @@ -1660,6 +1660,7 @@ int drm_mode_atomic_ioctl(struct drm_device *dev, >>       state->acquire_ctx = &ctx; >>       state->allow_modeset = !!(arg->flags & >> DRM_MODE_ATOMIC_ALLOW_MODESET); >>       state->plane_color_pipeline = file_priv->plane_color_pipeline; >> +    state->post_blend_color_pipeline = file_priv- >> >post_blend_color_pipeline; >>   retry: >>       copied_objs = 0; >> diff --git a/include/drm/drm_atomic.h b/include/drm/drm_atomic.h >> index >> 678708df9cdb90b4266127193a92183069f18688..8c42c584aefbf0034b2163d90538e80099b0dadb 100644 >> --- a/include/drm/drm_atomic.h >> +++ b/include/drm/drm_atomic.h >> @@ -482,6 +482,26 @@ struct drm_atomic_state { >>        */ >>       bool plane_color_pipeline : 1; >> +    /** >> +     * @post_blend_color_pipeline: >> +     * >> +     * Indicates whether this atomic state originated with a client that >> +     * set the DRM_CLIENT_CAP_POST_BLEND_COLOR_PIPELINE. >> +     * >> +     * Drivers and helper functions should use this to ignore legacy >> +     * properties that are incompatible with the drm_crtc COLOR_PIPELINE >> +     * behavior, such as: >> +     * >> +     *  - GAMMA_LUT >> +     *  - DEGAMMA_LUT >> +     *  - GAMMA_LUT_SIZE >> +     *  - CTM >> +     * >> +     * or any other driver-specific properties that might affect pixel >> +     * values. >> +     */ >> +    bool post_blend_color_pipeline : 1; > > As with the client cap name, I recommend calling this > crtc_color_pipeline. Agreed. As per the rest of the comments, I think it's worth moving all naming in this series from post_blend to crtc, matching the criteria used in plane (a.k.a. pre-blend) color pipelines. Will submit the related changes in v3. Regards, -- Ariel D'Alessandro Software Engineer Collabora Ltd. Platinum Building, St John's Innovation Park, Cambridge CB4 0DS, UK Registered in England & Wales, no. 5513718