mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Douglas Landgraf" <dougsland@gmail.com>
To: "Gregor Jasny" <jasny@vidsoft.de>
Cc: linux-kernel@vger.kernel.org,
	video4linux-list <video4linux-list@redhat.com>,
	"Mauro Carvalho Chehab" <mchehab@infradead.org>,
	v4l-dvb-maintainer@linuxtv.org, "Rafael J. Wysocki" <rjw@sisk.pl>
Subject: Re: [v4l-dvb-maintainer] [PATCH] Re: Regression: VIDIOCGMBUF ioctl hangs on bttv driver (2.6.24-rc6)
Date: Sun, 6 Jan 2008 20:53:27 -0200	[thread overview]
Message-ID: <68cac7520801061453w6906e510o5d53449e0b28f400@mail.gmail.com> (raw)
In-Reply-To: <20080106141548.GB18690@vidsoft.de>

Hi guys,

    Gregor, we have converted bttv driver to use vidioc_ioctl2 some days ago.
Could you check and create your patch against v4l development tree?
Bttv driver does not have anymore bttv_do_ioctl().

Cheers,
Douglas

On Jan 6, 2008 12:15 PM, Gregor Jasny <jasny@vidsoft.de> wrote:
> From: Gregor Jasny <gjasny@web.de>
>
> Fix bttv VIDIOCGMBUF locking like done in commit
> 820eacd84cff23b76693f4be1e28feb672f4488f.
>
> Signed-off-by: Gregor Jasny <gjasny@web.de>
> ---
> diff --git a/drivers/media/video/bt8xx/bttv-driver.c b/drivers/media/video/bt8xx/bttv-driver.c
> index c02d92d..581a3c9 100644
> --- a/drivers/media/video/bt8xx/bttv-driver.c
> +++ b/drivers/media/video/bt8xx/bttv-driver.c
> @@ -3063,11 +3063,10 @@ static int bttv_do_ioctl(struct inode *inode, struct file *file,
>                 struct video_mbuf *mbuf = arg;
>                 unsigned int i;
>
> -               mutex_lock(&fh->cap.lock);
>                 retval = videobuf_mmap_setup(&fh->cap,gbuffers,gbufsize,
>                                              V4L2_MEMORY_MMAP);
>                 if (retval < 0)
> -                       goto fh_unlock_and_return;
> +                       return retval;
>
>                 gbuffers = retval;
>                 memset(mbuf,0,sizeof(*mbuf));
> @@ -3075,7 +3074,6 @@ static int bttv_do_ioctl(struct inode *inode, struct file *file,
>                 mbuf->size   = gbuffers * gbufsize;
>                 for (i = 0; i < gbuffers; i++)
>                         mbuf->offsets[i] = i * gbufsize;
> -               mutex_unlock(&fh->cap.lock);
>                 return 0;
>         }
>         case VIDIOCMCAPTURE:
>
>
> _______________________________________________
> v4l-dvb-maintainer mailing list
> v4l-dvb-maintainer@linuxtv.org
> http://www.linuxtv.org/cgi-bin/mailman/listinfo/v4l-dvb-maintainer
>

  parent reply	other threads:[~2008-01-06 22:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-05 22:33 Gregor Jasny
2008-01-05 23:32 ` Rafael J. Wysocki
2008-01-06 14:15 ` [PATCH] " Gregor Jasny
2008-01-06 15:17   ` Ingo Molnar
2008-01-06 22:53   ` Douglas Landgraf [this message]
2008-01-06 22:55     ` [v4l-dvb-maintainer] " Douglas Landgraf
2008-01-06 23:22     ` Ingo Molnar
2008-01-07  2:02       ` Douglas Landgraf
2008-01-07  9:43       ` Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=68cac7520801061453w6906e510o5d53449e0b28f400@mail.gmail.com \
    --to=dougsland@gmail.com \
    --cc=jasny@vidsoft.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@infradead.org \
    --cc=rjw@sisk.pl \
    --cc=v4l-dvb-maintainer@linuxtv.org \
    --cc=video4linux-list@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®