From: Michal Simek <michal.simek@amd.com>
To: Yang Li <yang.lee@linux.alibaba.com>, broonie@kernel.org
Cc: michal.simek@xilinx.com, linux-spi@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] spi: xilinx: Use devm_platform_get_and_ioremap_resource()
Date: Tue, 28 Mar 2023 08:33:07 +0200 [thread overview]
Message-ID: <68ce9aed-f5a0-ff43-27b3-651773eb3258@amd.com> (raw)
In-Reply-To: <20230328061524.77529-1-yang.lee@linux.alibaba.com>
On 3/28/23 08:15, Yang Li wrote:
> According to commit 890cc39a8799 ("drivers: provide
> devm_platform_get_and_ioremap_resource()"), convert
> platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> drivers/spi/spi-xilinx.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/spi/spi-xilinx.c b/drivers/spi/spi-xilinx.c
> index 5dd3d1901412..8e6e3876aa9a 100644
> --- a/drivers/spi/spi-xilinx.c
> +++ b/drivers/spi/spi-xilinx.c
> @@ -440,8 +440,7 @@ static int xilinx_spi_probe(struct platform_device *pdev)
> xspi->bitbang.txrx_bufs = xilinx_spi_txrx_bufs;
> init_completion(&xspi->done);
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - xspi->regs = devm_ioremap_resource(&pdev->dev, res);
> + xspi->regs = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
> if (IS_ERR(xspi->regs))
> return PTR_ERR(xspi->regs);
>
> --
> 2.20.1.7.g153144c
>
Reviewed-by: Michal Simek <michal.simek@amd.com>
Thanks,
Michal
next prev parent reply other threads:[~2023-03-28 6:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-28 6:15 Yang Li
2023-03-28 6:33 ` Michal Simek [this message]
2023-03-28 14:52 ` Mark Brown
2023-03-28 15:25 ` Tudor Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68ce9aed-f5a0-ff43-27b3-651773eb3258@amd.com \
--to=michal.simek@amd.com \
--cc=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®