mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: Gencen Gan <gangecen@hust.edu.cn>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>
Cc: hust-os-kernel-patches@googlegroups.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] net: amd: Fix link leak when verifying config failed
Date: Thu, 20 Apr 2023 10:40:09 +0200	[thread overview]
Message-ID: <68d139bdc5c2cc267864b2136efb591948f61c91.camel@redhat.com> (raw)
In-Reply-To: <20230419065829.4077082-1-gangecen@hust.edu.cn>

Hi,

On Wed, 2023-04-19 at 14:58 +0800, Gencen Gan wrote:
> From: Gan Gecen <gangecen@hust.edu.cn>
> 
> After failing to verify configuration, it returns directly without 
> releasing link, which may cause memory leak.
> 
> Signed-off-by: Gan Gecen <gangecen@hust.edu.cn>

Please include a suitable Fixes tag and specify the target tree in the
subj - see the documentation for the details.

More importantly, skimming over the relevant code I think that at least
a netdev is still leaked in the relevant error path.

Generally speaking the whole code of this driver is quite "suboptimal"
and looks unmainatained since at least ~15y, just receiving tree-wide
related changes.

I'm wondering if we could simply remove the whole driver?

Thanks

Paolo


      reply	other threads:[~2023-04-20  8:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-19  6:58 Gencen Gan
2023-04-20  8:40 ` Paolo Abeni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=68d139bdc5c2cc267864b2136efb591948f61c91.camel@redhat.com \
    --to=pabeni@redhat.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=gangecen@hust.edu.cn \
    --cc=hust-os-kernel-patches@googlegroups.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®