From: Colin Ian King <colin.king@canonical.com>
To: Leon Romanovsky <leonro@mellanox.com>,
Gal Pressman <galpress@amazon.com>,
Dennis Dalessandro <dennis.dalessandro@intel.com>,
Doug Ledford <dledford@redhat.com>,
linux-rdma@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: re: RDMA: Clean destroy CQ in drivers do not return errors
Date: Fri, 14 Jun 2019 14:59:32 +0100 [thread overview]
Message-ID: <68d62660-902c-ca49-20fd-32e92830faa7@canonical.com> (raw)
Hi,
Static analysis with Coverity reported an issue with the following commit:
commit a52c8e2469c30cf7ac453d624aed9c168b23d1af
Author: Leon Romanovsky <leonro@mellanox.com>
Date: Tue May 28 14:37:28 2019 +0300
RDMA: Clean destroy CQ in drivers do not return errors
In function bnxt_re_destroy_cq() contains the following:
if (!cq->umem)
ib_umem_release(cq->umem);
Coverity detects this as a deference after null check on the null
pointer cq->umem:
"var_deref_model: Passing null pointer cq->umem to ib_umem_release,
which dereferences it"
Is the logic inverted on that null check?
Colin
next reply other threads:[~2019-06-14 13:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-14 13:59 Colin Ian King [this message]
2019-06-14 19:46 ` Doug Ledford
2019-06-15 7:12 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68d62660-902c-ca49-20fd-32e92830faa7@canonical.com \
--to=colin.king@canonical.com \
--cc=dennis.dalessandro@intel.com \
--cc=dledford@redhat.com \
--cc=galpress@amazon.com \
--cc=leonro@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®