From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754206AbdGXPrs (ORCPT <rfc822;w@1wt.eu>);
        Mon, 24 Jul 2017 11:47:48 -0400
Received: from mail-pg0-f49.google.com ([74.125.83.49]:37416 "EHLO
        mail-pg0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753210AbdGXPrl (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 24 Jul 2017 11:47:41 -0400
Subject: Re: [PATCH v5] printk: Add pr_info_show_time
To: Pavel Machek <pavel@ucw.cz>
Cc: linux-kernel@vger.kernel.org, andriy.shevchenko@linux.intel.com,
        joe@perches.com, prarit@redhat.com, rjw@rjwysocki.net,
        tglx@linutronix.de, Petr Mladek <pmladek@suse.com>,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Kees Cook <keescook@chromium.org>, Anton Vorontsov <anton@enomsg.org>,
        Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
        Ingo Molnar <mingo@kernel.org>, Peter Zijlstra <peterz@infradead.org>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Mark Salyzyn <salyzyn@google.com>,
        "Luis R. Rodriguez" <mcgrof@kernel.org>,
        Nicholas Piggin <npiggin@gmail.com>, Olof Johansson <olof@lixom.net>,
        "Jason A. Donenfeld" <Jason@zx2c4.com>,
        Josh Poimboeuf <jpoimboe@redhat.com>
References: <20170720182505.9357-1-salyzyn@android.com>
 <20170722094000.GA8064@xo-6d-61-c0.localdomain>
From: Mark Salyzyn <salyzyn@android.com>
Message-ID: <68db835b-4053-4785-f385-9a455bc505e2@android.com>
Date: Mon, 24 Jul 2017 08:47:38 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.1.1
MIME-Version: 1.0
In-Reply-To: <20170722094000.GA8064@xo-6d-61-c0.localdomain>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 07/22/2017 02:40 AM, Pavel Machek wrote:
>> For example, the persistent clock that is used to report
>> "Suspended for" message, although very useful, is not present on all
>> platforms.  It is currently standardized for millisecond precision.
> Fix that on your platforms, instead?
>
> 								Pavel

lol :-)

That is a _hardware_ issue. For a vast majority of them, the persistent 
read-only clock requires a LTE, always-on ready to wakeup device for a 
phone call, correction factor from a separate driver. In some cases the 
persistent clock requires a hardware re-init sequence to a pmic 
controller that occurs higher up in the resume chain. For those where it 
is possible, please remember there are 25K different Android devices, 
represented in nearly 2B hands. Feel free to tell all the implementors 
just how important a continuously accessible working 100% tuned accurate 
persistent clock is when _this_ _one_ flawed (ms accuracy, no lte 
correction while asleep) print is the only place which gains from said 
access ;-). I am blue in the face just working with the limited set I 
have influence on.

And yet, add a simple print of realtime clock at suspend and resume 
points higher up in the chain always works regardless of the hardware or 
the driver skills of the vendor building the devices.


-- Mark