From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752672AbcFVO2m (ORCPT ); Wed, 22 Jun 2016 10:28:42 -0400 Received: from AUSXIPPC110.us.dell.com ([143.166.85.200]:23038 "EHLO ausxippc110.us.dell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752027AbcFVO2k (ORCPT ); Wed, 22 Jun 2016 10:28:40 -0400 DomainKey-Signature: s=smtpout; d=dell.com; c=nofws; q=dns; h=X-LoopCount0:X-IronPort-AV:From:To:CC:Subject: Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language: X-MS-Has-Attach:X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader:x-originating-ip: Content-Type:Content-Transfer-Encoding:MIME-Version: Return-Path; b=yXMl69z22r8RDb5j1yDEGI3HyPjTrXR5zP5R/jOfU+KJ0VNR4wvQPAgf hcSN7XOVyVsuAooJfJYITfFYhD2UWreAIDGQFvaKYzI23GwJ2AgWl8gMv FWnwQBrefS+17cLk1IeAAonm6WgRlhbGPTdAY78tjTDOeCxrwLWIg47hl k=; X-LoopCount0: from 10.170.28.40 X-IronPort-AV: E=Sophos;i="5.26,509,1459832400"; d="scan'208";a="324776060" From: To: CC: , , , , , , , Subject: RE: [PATCH 3/4] dell-wmi: Add information about other WMI event codes Thread-Topic: [PATCH 3/4] dell-wmi: Add information about other WMI event codes Thread-Index: AQHRtB42hzf3HHxGtEu99Pj4tlzQap/MILSAgBLrjQCAACDR8IAApAwAgAuY+oCACRdL8IABITwAgAAJTLCAAF/ugP//rahwgABVjID//6xYoA== Date: Wed, 22 Jun 2016 14:28:37 +0000 Message-ID: <68dd5c56440d4fc9a1c09c69a548476a@ausx13mpc124.AMER.DELL.COM> References: <1463916983-12562-1-git-send-email-pali.rohar@gmail.com> <01b8e172bca546728b596c8cc4ebd932@ausx13mpc124.AMER.DELL.COM> <0d5a8762-b849-41c6-bfe5-e00da25d26d5@gmail.com> <201606152151.07407@pali> <20160622075602.GA29844@pali> <41f11bb2917349919e0b4eb21fab9a46@ausx13mpc124.AMER.DELL.COM> <20160622141239.GG29844@pali> <20160622142407.GH29844@pali> In-Reply-To: <20160622142407.GH29844@pali> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.208.89.195] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u5MESjef010394 > -----Original Message----- > From: Pali Rohár [mailto:pali.rohar@gmail.com] > Sent: Wednesday, June 22, 2016 9:24 AM > To: Limonciello, Mario > Cc: gabriele.mzt@gmail.com; mjg59@srcf.ucam.org; dvhart@infradead.org; > kernel@kempniu.pl; luto@kernel.org; alex.hung@canonical.com; platform- > driver-x86@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH 3/4] dell-wmi: Add information about other WMI event > codes > > On Wednesday 22 June 2016 14:21:25 Mario_Limonciello@Dell.com wrote: > > > > For Linux I don’t think this is necessary and a NOOP is appropriate. > > > > > > > > There is also a second place that some older laptops had a battery > "hotkey" > > > > that would also emit 0xE00E. This was also picked up by quickset and > would > > > > show battery information. > > > > > > > > This shouldn't be blocked by kernel, I'd expect if someone wants to > bind > > > this > > > > to another application from userspace they should be able to. > > > > > > Great! Can I send patch after which 0xe00e will be send to input layer as > > > event KEY_BATTERY? > > > > > > > Well that's why I was mentioning this in two places. If it's received from > keyboard > > recoding it as KEY_BATTERY sounds appropriate to me. If it's received from > WMI, > > it really shouldn't be set as anything for Linux to do. > > > > I don't think any apps will benefit from the notification to re-read battery > > Information today. > > I mean for dell-wmi.c code. > Why it should not be set to anything on Linux? > On Windows Quickset is a separate application from built-in Windows battery applet. It shows similar types of information as gnome-power-manager does, but because it's not part of the OS, it doesn't get notifications like this so special BIOS hooks are in place for it to know when to re-read battery information. On Linux, there are already infrastructure for battery removal and adding notifications from ACPI. Sending this up to user space won't be useful.