mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Aditya Garg <gargaditya08@live.com>,
	Andre Eikmeyer <dev@deq.rocks>,
	Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev,
	brcm80211-dev-list.pdl@broadcom.com,
	linux-kernel@vger.kernel.org,
	Sasha Finkelstein <k@chaosmail.tech>,
	Sven Peter <sven@kernel.org>, Janne Grunau <j@jannau.net>
Subject: Re: [PATCH 0/7] wifi: brcmfmac: AWDL for AirDrop on Apple T2 Macs
Date: Sun, 22 Nov 2026 21:08:55 +0100	[thread overview]
Message-ID: <68def4e1-3429-45eb-b025-dd0fa10cb58c@broadcom.com> (raw)
In-Reply-To: <84585c89-9f57-42ce-8127-6a4b2da205c6@broadcom.com>

On 18/11/2026 11:52, Arend van Spriel wrote:
> On 11/11/2026 15:28, Aditya Garg wrote:
>> Hi Arend
>>
>>> I really have no idea how to deal with this series. AWDL is not part 
>>> of the IEEE 802.11 so I can imagine the kernel wireless subsystem 
>>> does not care to support this. From driver perspective I am not keen 
>>> on supporting this upstream either. My limited understanding of AWDL 
>>> was that it was Apple's variant of TDLS (802.11z).
>>>
>>> So what does AWDL provide to user-space and could the same be 
>>> accomplished by TDLS? From the explanation above it seems AWDL 
>>> provides more knobs to user-space, but not sure whether the awdl%d 
>>> interface is merely a control interface or actually passing data 
>>> through it (patch 5 implies it does). If my memory does not fail me 
>>> then adding vendor commands is generally pushed back.
>>>
>>> Regards,
>>> Arend
>>
>> There has been a lot of Apple specific code in the kernel, be it HID, 
>> DRM, EFI etc. So why not a small bit of code in brcmfmac. We have 
>> never faced complaints from those maintainers in getting code 
>> upstreamed which is different from the standards, but is needed for 
>> the hardware to work. While the concern of unable the understand the 
>> code is valid, I believe the author can be questioned to clear doubts 
>> before upstreaming. Getting code rejected just because of inability to 
>> maintain is heartbreaking when people work hard to make something 
>> good. Also the patches are just for Apple Macs, and not for supporting 
>> AirDrop on random hardware, so it shouldn't be that difficult to 
>> maintain.
> 
> You are reading stuff between the lines that are not there. My concern 
> was mostly related to the new vendor commands. The vendor commands are 
> out of favor as it was used to avoid defining an generic nl80211 command 
> and thus avoid true collaboration in building a device independent 
> wireless subsystem. In brcmfmac we currently have one vendor command 
> which allows user-space to interact directly with firmware for debugging 
> purposes.
> 
> Also AWDL support is not about making the hardware work. It is a 
> software feature providing the transport layer for AirDrop (and 
> apparently t2-drop). I would say the same experience could be provided 
> with another transport layer, eg. by using NAN or P2P. I get that 
> downstream users are happy with the AirDrop-like experience, but that 
> does not make it a must-have in upstream linux.
This has taken a bit longer to decide what to do with it. Adding support 
for AWDL for some Apple wireless devices does not feel like the 
collaborative work that makes my heart skip a few beats in excitement. A 
vendor agnostic solution would have it racing.

I had a short discussion with Johannes and in general vendor commands 
are banned. However, for this feature we do not want to push for a 
solution with nl80211 commands. Hence I have review the AWDL series. 
Patch 1 was already rejected because of a similar fix that was already 
applied to wireless-next. So a v2 is needed. The patches 4, 6 and 7 need 
changes. patches 2, 3 and 5 may carry the Acked-by into v2 as they look 
fine to me.

Regards,
Arend

      reply	other threads:[~2026-11-22 20:09 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-04 15:15 Andre Eikmeyer
2026-11-04 15:15 ` [PATCH 1/7] wifi: brcmfmac: match firmware capabilities as whole words Andre Eikmeyer
2026-11-05 17:33   ` Arend van Spriel
2026-11-06  7:07     ` André Eikmeyer
2026-11-04 15:15 ` [PATCH 2/7] wifi: brcmfmac: move the interface_create definitions to fwil_types.h Andre Eikmeyer
2026-11-22 20:09   ` Arend van Spriel
2026-11-04 15:15 ` [PATCH 3/7] wifi: brcmfmac: detect AWDL support of the firmware Andre Eikmeyer
2026-11-22 20:09   ` Arend van Spriel
2026-11-04 15:15 ` [PATCH 4/7] wifi: brcmfmac: create and remove the AWDL interface Andre Eikmeyer
2026-11-22 20:09   ` Arend van Spriel
2026-11-04 15:15 ` [PATCH 5/7] wifi: brcmfmac: add the AWDL data path Andre Eikmeyer
2026-11-22 20:09   ` Arend van Spriel
2026-11-04 15:15 ` [PATCH 6/7] wifi: brcmfmac: add vendor commands for AWDL Andre Eikmeyer
2026-11-22 20:09   ` Arend van Spriel
2026-11-04 15:15 ` [PATCH 7/7] wifi: brcmfmac: pass AWDL frames and role changes to user space Andre Eikmeyer
2026-11-22 20:09   ` Arend van Spriel
2026-11-08 15:41 ` [PATCH 0/7] wifi: brcmfmac: AWDL for AirDrop on Apple T2 Macs Arend van Spriel
2026-11-08 18:20   ` André Eikmeyer
2026-11-11 14:28   ` Aditya Garg
2026-11-18 10:52     ` Arend van Spriel
2026-11-22 20:08       ` Arend van Spriel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=68def4e1-3429-45eb-b025-dd0fa10cb58c@broadcom.com \
    --to=arend.vanspriel@broadcom.com \
    --cc=brcm80211-dev-list.pdl@broadcom.com \
    --cc=brcm80211@lists.linux.dev \
    --cc=dev@deq.rocks \
    --cc=gargaditya08@live.com \
    --cc=j@jannau.net \
    --cc=johannes@sipsolutions.net \
    --cc=k@chaosmail.tech \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=sven@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®