From: SF Markus Elfring <elfring@users.sourceforge.net>
To: adi-buildroot-devel@lists.sourceforge.net,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>,
Steven Miao <realmz6@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: [PATCH 4/5] blackfin-setup: Replace three seq_printf() calls by seq_puts() in show_cpuinfo()
Date: Wed, 19 Oct 2016 22:49:45 +0200 [thread overview]
Message-ID: <68ec4f90-f98d-6b55-40a3-939a664c64dc@users.sourceforge.net> (raw)
In-Reply-To: <4cd6678e-ebf0-d2f4-0b79-ac33060a6752@users.sourceforge.net>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 19 Oct 2016 21:46:16 +0200
Strings which did not contain data format specifications should be put
into a sequence. Thus use the corresponding function "seq_puts".
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
arch/blackfin/kernel/setup.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/blackfin/kernel/setup.c b/arch/blackfin/kernel/setup.c
index a159008..fdd9168 100644
--- a/arch/blackfin/kernel/setup.c
+++ b/arch/blackfin/kernel/setup.c
@@ -1313,9 +1313,9 @@ static int show_cpuinfo(struct seq_file *m, void *v)
if (bfin_revid() != bfin_compiled_revid()) {
if (bfin_compiled_revid() == -1)
- seq_printf(m, "(Compiled for Rev none)");
+ seq_puts(m, "(Compiled for Rev none)");
else if (bfin_compiled_revid() == 0xffff)
- seq_printf(m, "(Compiled for Rev any)");
+ seq_puts(m, "(Compiled for Rev any)");
else
seq_printf(m, "(Compiled for Rev %d)", bfin_compiled_revid());
}
@@ -1385,7 +1385,7 @@ static int show_cpuinfo(struct seq_file *m, void *v)
seq_printf(m, "icache setup\t: %d Sub-banks/%d Ways, %d Lines/Way\n",
BFIN_ISUBBANKS, BFIN_IWAYS, BFIN_ILINES);
else
- seq_printf(m, "icache setup\t: off\n");
+ seq_puts(m, "icache setup\t: off\n");
seq_printf(m,
"dcache setup\t: %d Super-banks/%d Sub-banks/%d Ways, %d Lines/Way\n",
--
2.10.1
next prev parent reply other threads:[~2016-10-19 20:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-19 20:44 [PATCH 0/5] Blackfin: Fine-tuning for three function implementations SF Markus Elfring
2016-10-19 20:46 ` [PATCH 1/5] blackfin-cplbinfo: Use seq_puts() in cplbinfo_print_header() SF Markus Elfring
2016-10-19 20:47 ` [PATCH 2/5] blackfin-irqchip: Combine two seq_printf() calls into one call in arch_show_interrupts() SF Markus Elfring
2016-10-19 20:48 ` [PATCH 3/5] blackfin-setup: Use seq_putc() in show_cpuinfo() SF Markus Elfring
2016-10-19 20:49 ` SF Markus Elfring [this message]
2016-10-19 20:50 ` [PATCH 5/5] blackfin-setup: Combine ten seq_printf() calls into three calls " SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68ec4f90-f98d-6b55-40a3-939a664c64dc@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=adi-buildroot-devel@lists.sourceforge.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=realmz6@gmail.com \
--cc=rickard_strandqvist@spectrumdigital.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®