From: Kyle Switch <kyle.switch@motor-comm.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: olteanv@gmail.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, mmyangfl@gmail.com,
horms@kernel.org, linux@armlinux.org.uk, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, ming.xu@motor-comm.com,
xiaolin.xu@motor-comm.com, jianmin.wang@motor-comm.com,
wei.zhang@gl-inet.com, sijia.huang@gl-inet.com
Subject: Re: [PATCH net-next v8 2/6] net: dsa: motorcomm: use max_ports in series for port bounds checking
Date: Wed, 23 Sep 2026 09:07:56 +0800 [thread overview]
Message-ID: <68f0b522-1795-41bb-bb13-33a29bf3d1b9@motor-comm.com> (raw)
In-Reply-To: <e54c308b-3297-4abc-af95-5ef9c925931f@lunn.ch>
On 9/22/26 20:47, Andrew Lunn wrote:
>> @@ -402,7 +403,8 @@ yt921x_mbus_int_init(struct yt921x_priv *priv, struct device_node *mnp)
>> mbus->read = yt921x_mbus_int_read;
>> mbus->write = yt921x_mbus_int_write;
>> mbus->parent = dev;
>> - mbus->phy_mask = (u32)~GENMASK(YT921X_PORT_NUM - 1, 0);
>> + max_ports = priv->series->max_ports;
>> + mbus->phy_mask = (u32)~GENMASK(max_ports - 1, 0);
> A separate patch, but can this be changed to GENMASK_U32() so the cast
> is not needed? There maybe be other instances in this driver which can
> be changed as well.
Ans: okay, will be updated in next patch.
>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
>
> Andrew
next prev parent reply other threads:[~2026-09-23 1:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 8:22 [PATCH net-next v8 0/6] net: dsa: motorcomm: add support yt922x driver Kyle Switch
2026-09-17 8:22 ` [PATCH net-next v8 1/6] net: dsa: motorcomm: initialize dsa_switch based on chipid Kyle Switch
2026-09-21 9:35 ` netdev-bot+sashiko
2026-09-22 12:41 ` Andrew Lunn
2026-09-17 8:22 ` [PATCH net-next v8 2/6] net: dsa: motorcomm: use max_ports in series for port bounds checking Kyle Switch
2026-09-21 9:35 ` netdev-bot+sashiko
2026-09-22 12:47 ` Andrew Lunn
2026-09-23 1:07 ` Kyle Switch [this message]
2026-09-17 8:22 ` [PATCH net-next v8 3/6] net: dsa: motorcomm: move mib start from probe() to dsa_setup() Kyle Switch
2026-09-21 9:35 ` netdev-bot+sashiko
2026-09-17 8:22 ` [PATCH net-next v8 4/6] net: dsa: motorcomm: move mib stop from remove() to teardown() Kyle Switch
2026-09-21 9:35 ` netdev-bot+sashiko
2026-09-17 8:22 ` [PATCH net-next v8 5/6] net: dsa: tag_yt922x: add support for Motorcomm YT922x tags Kyle Switch
2026-09-21 9:35 ` netdev-bot+sashiko
2026-09-17 8:22 ` [PATCH net-next v8 6/6] net: dsa: motorcomm: Add support for Motorcomm YT922x Kyle Switch
2026-09-21 9:35 ` netdev-bot+sashiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68f0b522-1795-41bb-bb13-33a29bf3d1b9@motor-comm.com \
--to=kyle.switch@motor-comm.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jianmin.wang@motor-comm.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=ming.xu@motor-comm.com \
--cc=mmyangfl@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=sijia.huang@gl-inet.com \
--cc=wei.zhang@gl-inet.com \
--cc=xiaolin.xu@motor-comm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®