From: Paolo Abeni <pabeni@redhat.com>
To: Yi Zou <03zouyi09.25@gmail.com>, davem@davemloft.net
Cc: 21210240012@m.fudan.edu.cn, 21302010073@m.fudan.edu.cn,
dsahern@kernel.org, edumazet@google.com, kuba@kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ipv6: ip6_fib: fix possible null-pointer-dereference in ipv6_route_native_seq_show
Date: Tue, 5 Nov 2024 13:28:28 +0100 [thread overview]
Message-ID: <68f209ba-2979-4a15-b344-4613c465b005@redhat.com> (raw)
In-Reply-To: <20241101044828.55960-1-03zouyi09.25@gmail.com>
On 11/1/24 05:48, Yi Zou wrote:
> In the ipv6_route_native_seq_show function, the fib6_nh variable
> is assigned the value from nexthop_fib6_nh(rt->nh), which could
> return NULL. This creates a risk of a null-pointer-dereference
> when accessing fib6_nh->fib_nh_gw_family. This can be resolved by
> checking if fib6_nh is non-NULL before accessing fib6_nh->fib_nh_gw_family
> and assign dev using dev = fib6_nh ? fib6_nh->fib_nh_dev : NULL;
> to prevent null-pointer dereference errors.
>
> Signed-off-by: Yi Zou <03zouyi09.25@gmail.com>
Please send a new revision, including a the target tree in the subj
prefix - in this case 'net' and a suitable Fixes tag.
/P
next prev parent reply other threads:[~2024-11-05 12:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-01 4:48 Yi Zou
2024-11-01 16:45 ` Markus Elfring
[not found] ` <CAH_kV5EXr6B3vU3mbwHYaCHdSeCcVw9DiNT4on5rNwiAE+svRg@mail.gmail.com>
2024-11-02 17:30 ` Markus Elfring
2024-11-05 12:28 ` Paolo Abeni [this message]
2024-11-05 15:44 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68f209ba-2979-4a15-b344-4613c465b005@redhat.com \
--to=pabeni@redhat.com \
--cc=03zouyi09.25@gmail.com \
--cc=21210240012@m.fudan.edu.cn \
--cc=21302010073@m.fudan.edu.cn \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®