From: Richard Fitzgerald <rf@opensource.cirrus.com>
To: Andrey Zakharov <dedemorow@gmail.com>,
broonie@kernel.org, lgirdwood@gmail.com
Cc: perex@perex.cz, tiwai@suse.com, patches@opensource.cirrus.com,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: wm_adsp_fw_find_test: Replace strlcat() with seq_buf
Date: Mon, 9 Nov 2026 11:12:38 +0000 [thread overview]
Message-ID: <68f4c2c6-bb73-4610-9975-d093989f9ceb@opensource.cirrus.com> (raw)
In-Reply-To: <20261107152338.77837-1-dedemorow@gmail.com>
On 07/11/2026 3:23 pm, Andrey Zakharov wrote:
> strlcat() is being removed from the kernel. It runs an unbounded
> strlen() on the destination, and its size argument is not tied to
> the real buffer, see the issue below.
>
> The test builds the searched_fw_files string by appending to a fixed
> size buffer in two places. Use seq_buf_init_append() and
> seq_buf_puts() instead. seq_buf_init_append() keeps the NUL-terminated
> content already in the buffer, and seq_buf_puts() copies as much as
> fits and keeps the buffer NUL-terminated if it overflows.
Reviewed-by: Richard Fitzgerald <rf@opensource.cirrus.com>
prev parent reply other threads:[~2026-11-09 11:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-07 15:23 Andrey Zakharov
2026-11-09 11:12 ` Richard Fitzgerald [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68f4c2c6-bb73-4610-9975-d093989f9ceb@opensource.cirrus.com \
--to=rf@opensource.cirrus.com \
--cc=broonie@kernel.org \
--cc=dedemorow@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®