From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vs1-f99.google.com (mail-vs1-f99.google.com [209.85.217.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1058C8003D for ; Fri, 24 Jul 2026 20:07:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.217.99 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784923662; cv=none; b=h9wEwC9sLHENnEhnWPqt9Wb5wJ/GzNKIo6AnbUnC3PC4BoBG3p5uwImsXFx9eic/pCdp0CTlpC8e4+gQLHtRUG8869eFOs8MH1f/eeCT3f2EfzxmmnWVrzH2bptKdQnSCo5z05k3pEC44BjrOpjiUZzxjVO7NFHNTAC4nU3qqOg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784923662; c=relaxed/simple; bh=HIReAvMzZS/y3Hl1qTGZmF8VbrWn3WGQbZjXY/7QQD4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=L8xVvd6PXaphB2x9cqJskFak9uSv3cmNgoRkyPKbChtuzbNFPiKK+aPLgaCGOFx614GEou+TxWBc4H2SGoOBR1AyixeFKsekc3mu8seTtkMmNnnzoKgznbtGCOhiOcBay2I8BoTF1MZdboBtAkmgehNDUJroPF48qA/CFh6FR9A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=Lkhc4a9u; arc=none smtp.client-ip=209.85.217.99 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="Lkhc4a9u" Received: by mail-vs1-f99.google.com with SMTP id ada2fe7eead31-74dceb46291so330806137.0 for ; Fri, 24 Jul 2026 13:07:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784923660; x=1785528460; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:dkim-signature:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=O87kJCBhVSrXeMQLPuEgMpocdJnGzImKIzvyu9Sbd1E=; b=aiHxLchtokBCV3gzQXJKvflk+kCVseJlcOgbOFvuV1Bb/7JoKsMCuEb7f59iogJ51h o94+yPzuDZ5MbOvKzfVhYcEGqpN+Sqekw8qPM81l71bMw5RSNHICYEjSLdhbsiRyhanY MexknkbhgrCpuTbCxgSNvuRofY7fVa/kNakYUpSw0gUWY6C5K+19sEWIqDjCSdVm6qBI rszuLXsNlGZ8dT93XuSypnAEhfg5SGcVShv185PkkC8E6Q8x+TpSJSUdY8W1UE+7P7mA k4oGpyl2sVh8m/r6JZNHNNDIsLuJLLlvVUvgLscI1r7J63SNSrUycfgTkrU6eGlmdE4u dHbw== X-Forwarded-Encrypted: i=1; AHgh+RoQ+K3duFgUnDoYRMXxCBKplwzHlqFcEO3tS6ff+FhRGruCWLZQ22ABqEx5O1HJ69vCcAJjXAXEPu78TlY=@vger.kernel.org X-Gm-Message-State: AOJu0YzeIxo4Gb/JwJMSCEF8a290GcJVCKja/3Vy0yRnt4BWa8MDf62X NsUTtnU9x+LSod07WUTna4iiBDkMcxcgJN2VfF6WXPf3TAGdEDanGrmUooyVx8IosXDxdCnjm8U L/Pb4Yp9UlcHc4k7Xg7j7RVZV0ASXrkgcdhlKdXt7MP8Pm7g7WsLPR/2KSp+Q/raeCMTZVaiRiK 08tepT/VzQ8NkowygTLf/JIAttEgY9d1BdMveeRLz/+GgE655z/C+li2/7rnQKWwwwj3e6smuEH JFBW+1uxUpzAKAhsEfOpiXH X-Gm-Gg: AR+sD13gn9XUSTVGNi50YtSWOgj3p2lt/aw9xCIydhfbMddTaWzwP+sYsPLvcSCul/i VqusLlAbRhXg7Du9/Z7QFl4GaKzLhF9EO6aEmr+FbDY/I0NSHKX1jil6qz5hW5tA8My6VxdcWt8 M/DVfmfWWj7ce5ZkbJrqVClDJtUMYbGEh0s7VLEQWupKDuy4HMkKE/AooBohSpukSIUh7s2HTm+ xHaNPbDw2xcNob7v27e+zTWMOLdmVh7WGO748bd0HVJuxAh/OM97iNiuDWdKPS/E+Js9edLPYDM PGA+B0ZGkbxUXO3Q50p9ITyhxyP8x5nZYahizHkeV4OBreLP21qVC12u2MsmBPA+IaPP9NEe2bu IpcRd8IT99VPv8HWN0Q6RUluMapTvY2gG8DgDZ+TNqo13G++d+fzjcf+QQOf67PikSHelZMXnsI wiI9tBprqXhu4wnd0G32GYTguYELjoqjOBKuvkOM4H X-Received: by 2002:a05:6102:5cc8:b0:74c:11b2:a941 with SMTP id ada2fe7eead31-74d60e0b64fmr4900011137.27.1784923659893; Fri, 24 Jul 2026 13:07:39 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-73.dlp.protect.broadcom.com. [144.49.247.73]) by smtp-relay.gmail.com with ESMTPS id ada2fe7eead31-74ad3454f0csm770583137.23.2026.07.24.13.07.39 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 24 Jul 2026 13:07:39 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-92e9a2b95b5so132604485a.2 for ; Fri, 24 Jul 2026 13:07:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1784923659; x=1785528459; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=O87kJCBhVSrXeMQLPuEgMpocdJnGzImKIzvyu9Sbd1E=; b=Lkhc4a9u1zlFLWwA4HEZRucDumTXyXafFbqMpGEZdMc74wB4J+DAfDX9oecGrMK73r sHqYMcLUs2E6nWQMmOexY3bxXaHM1tIkXr0Bg3ebzfHJgIov2RyJv/jH/Bk8TAchwjVn VqV0QrKiz6DdiQf7kSoU6Fbl4+7dLB3+phO1M= X-Forwarded-Encrypted: i=1; AHgh+Rp940Cl+4S5A98s4aYuvj8IlaIUyMESadlZjVZMDQaXzvkhN+3qXsHRwURuWhgSsrwfsF3IMWSIx6ZDQFM=@vger.kernel.org X-Received: by 2002:a05:620a:3952:b0:92e:4799:a808 with SMTP id af79cd13be357-9310387a352mr1028559285a.40.1784923659310; Fri, 24 Jul 2026 13:07:39 -0700 (PDT) X-Received: by 2002:a05:620a:3952:b0:92e:4799:a808 with SMTP id af79cd13be357-9310387a352mr1028555585a.40.1784923658874; Fri, 24 Jul 2026 13:07:38 -0700 (PDT) Received: from [10.211.247.235] ([192.19.50.250]) by smtp.gmail.com with ESMTPSA id af79cd13be357-930f6a6bd88sm721848685a.39.2026.07.24.13.07.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Jul 2026 13:07:38 -0700 (PDT) Message-ID: <68f99546-7ca4-4aa2-ba5c-aa36204c2f8a@broadcom.com> Date: Fri, 24 Jul 2026 13:12:19 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] drm/vmwgfx: Remove unused vmw_goal_waiter_add/remove To: Saswat Jung Khadka , zack.rusin@broadcom.com Cc: bcm-kernel-feedback-list@broadcom.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260721080028.4464-1-saswatjungkhadka@gmail.com> <20260723043605.2195-1-saswatjungkhadka@gmail.com> From: Maaz Mombasawala Content-Language: en-US In-Reply-To: <20260723043605.2195-1-saswatjungkhadka@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e On 7/22/26 9:36 PM, Saswat Jung Khadka wrote: > vmw_goal_waiter_add() and vmw_goal_waiter_remove() have had no > callers since commit db6a94b26354 ("drm/vmwgfx: Implement > dma_fence_ops properly"), which removed their only call site. > Their sibling functions vmw_seqno_waiter_add/remove are still > in active use, confirming these are leftover dead code. > > Signed-off-by: Saswat Jung Khadka > --- > drivers/gpu/drm/vmwgfx/vmwgfx_drv.h | 2 -- > drivers/gpu/drm/vmwgfx/vmwgfx_irq.c | 12 ------------ > 2 files changed, 14 deletions(-) > > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.h b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.h > index 38bea8aba..d84e077ed 100644 > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.h > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.h > @@ -1026,8 +1026,6 @@ extern int vmw_fallback_wait(struct vmw_private *dev_priv, > unsigned long timeout); > bool vmw_seqno_waiter_add(struct vmw_private *dev_priv); > bool vmw_seqno_waiter_remove(struct vmw_private *dev_priv); > -bool vmw_goal_waiter_add(struct vmw_private *dev_priv); > -bool vmw_goal_waiter_remove(struct vmw_private *dev_priv); > bool vmw_generic_waiter_add(struct vmw_private *dev_priv, u32 flag, > int *waiter_count); > bool vmw_generic_waiter_remove(struct vmw_private *dev_priv, > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_irq.c b/drivers/gpu/drm/vmwgfx/vmwgfx_irq.c > index 05773eb39..88c77226c 100644 > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_irq.c > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_irq.c > @@ -273,18 +273,6 @@ bool vmw_seqno_waiter_remove(struct vmw_private *dev_priv) > &dev_priv->fence_queue_waiters); > } > > -bool vmw_goal_waiter_add(struct vmw_private *dev_priv) > -{ > - return vmw_generic_waiter_add(dev_priv, vmw_irqflag_fence_goal(dev_priv), > - &dev_priv->goal_queue_waiters); > -} > - > -bool vmw_goal_waiter_remove(struct vmw_private *dev_priv) > -{ > - return vmw_generic_waiter_remove(dev_priv, vmw_irqflag_fence_goal(dev_priv), > - &dev_priv->goal_queue_waiters); > -} > - > static void vmw_irq_preinstall(struct drm_device *dev) > { > struct vmw_private *dev_priv = vmw_priv(dev); LGTM! Reviewed-by: Maaz Mombasawala -- Maaz Mombasawala