mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ira Weiny <ira.weiny@intel.com>
To: dan.j.williams@intel.com, "Michał Cłapiński" <mclapinski@google.com>
Cc: Vishal Verma <vishal.l.verma@intel.com>,
	Dave Jiang <dave.jiang@intel.com>, <nvdimm@lists.linux.dev>,
	<linux-cxl@vger.kernel.org>,
	Pasha Tatashin <pasha.tatashin@soleen.com>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] dax: add PROBE_PREFER_ASYNCHRONOUS to the pmem driver
Date: Thu, 23 Oct 2025 09:57:08 -0500	[thread overview]
Message-ID: <68fa4244ca3a5_1870d210024@iweiny-mobl.notmuch> (raw)
In-Reply-To: <68f9a61ccc6b1_10e9100e5@dwillia2-mobl4.notmuch>

dan.j.williams@ wrote:
> Michał Cłapiński wrote:
> [..]
> > > However, I believe that falls back to synchronous probing if the driver
> > > is loaded after the device has already arrived. Is that the case you are
> > > hitting?
> > 
> > Yes. I use all pmem/devdax modules built into the kernel so loading
> > them is in the critical path for kernel boot.
> > I use memmap= with devdax. So first, the pmem device is created
> > asynchronously, which means loading the nd_e820 module is always fast.
> > But then, the dax_pmem driver is loaded. If the dax device has not yet
> > been created by the async code, then loading this module is also fast.
> > But if the dax device has already been created, then attaching it to
> > the dax_pmem driver will be synchronous and on the critical boot path.
> > 
> > For thousands of dax devices, this increases the boot time by more
> > than a second. With the patch it takes ~10ms.
> > 
> > > I am ok with this in concept, but if we do this it should be done for
> > > all dax drivers, not just dax_pmem.
> > 
> > Will do in v2.
> 
> Sounds good, include that detail above and I'll ack / poke Ira to pick
> it up.

Yea if you send to me I'll pick it up.  Sorry I did not see this before.

Ira

      reply	other threads:[~2025-10-23 14:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-02 13:19 Michal Clapinski
2025-10-22 20:57 ` Michał Cłapiński
2025-10-22 23:38 ` dan.j.williams
2025-10-22 23:53   ` Michał Cłapiński
2025-10-23  3:50     ` dan.j.williams
2025-10-23 14:57       ` Ira Weiny [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=68fa4244ca3a5_1870d210024@iweiny-mobl.notmuch \
    --to=ira.weiny@intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mclapinski@google.com \
    --cc=nvdimm@lists.linux.dev \
    --cc=pasha.tatashin@soleen.com \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®