From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDB33C433ED for ; Fri, 23 Apr 2021 07:04:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8C36B6144A for ; Fri, 23 Apr 2021 07:04:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240931AbhDWHFB (ORCPT ); Fri, 23 Apr 2021 03:05:01 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:23022 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240881AbhDWHE7 (ORCPT ); Fri, 23 Apr 2021 03:04:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1619161463; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RmvPHXOIz59ZhDsNoQXWHFewKFvZPSMFlQfKoIahSjw=; b=AznTNZZm2GtjS6wPmPLRAcbVj/TBoIhDYNO0FfLwWN0Qb2DxN9TmeqTSqEuOd8alQVIABe aGqWGkEJOeQ0J/jLbvRdWnNouUE8cm86Cs/tjNO/Tk78i2nZpFI3R45eekx5O8MJi3N57i HRPItMsGc52hnNPD+xa/zR/Vt+2y39Q= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-322-2u_w1w8dO_Cn6PT_yX8HCg-1; Fri, 23 Apr 2021 03:04:21 -0400 X-MC-Unique: 2u_w1w8dO_Cn6PT_yX8HCg-1 Received: by mail-ej1-f72.google.com with SMTP id bx15-20020a170906a1cfb029037415131f28so8101647ejb.18 for ; Fri, 23 Apr 2021 00:04:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=RmvPHXOIz59ZhDsNoQXWHFewKFvZPSMFlQfKoIahSjw=; b=FsVHcC6QMfKGlyiX63j4PymYRIwr55bALhJu9M7mIZT8YTmzKTQZXWgU83/PardP0p 589JSng2jN0DXWrjYlRKifa2Q/e2b81zlU3TWs1OwYyGKKnMMRMoKUOROhi32EcA5b9T XcOYE53Eob3RXr+mJfrQelmxoWZ+K5hxNDkZUdeqwoaG1G9TdDKa+yTOjU5C64yRvqwr hwNa7eB6Vg+HBk3cJbfB5pprMR1x5l/GyyhBcisgua1WBTFE5Cg6Zi8KPIRKNrFdje4r p1yA8wFjkpzZbsCS2f4SGLydDNOClP3E7nF4GQc5hyab+CG7SAokLqsMOCmCN6FM/l2H eyAw== X-Gm-Message-State: AOAM532BTQSHiEH7Z/sV6ALshjeoEY30QPCWwVAYox0DreLTxnHtBJtD bC74937jmrgHURC9slYFVbkaunRTsn2i+ddO951bY/tSGUVADk8vdICcvPwy7oKvY6bOot66Fm6 DX8AVkyiaCJkpfn1QISwg/texBm4Nvrxlmo5HnPNNPg35MYehaVth9YOlejqLugQdQxKUT/l20u iO X-Received: by 2002:a05:6402:646:: with SMTP id u6mr2719509edx.74.1619161460118; Fri, 23 Apr 2021 00:04:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxWR+WigVfcUVDUgxhH63vnxFbSo3QzmiBcdSKKBGoPovmcpdIwJCOfTnVynrTz+hP5rmBfYA== X-Received: by 2002:a05:6402:646:: with SMTP id u6mr2719474edx.74.1619161459855; Fri, 23 Apr 2021 00:04:19 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id l3sm4009512edr.2.2021.04.23.00.04.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Apr 2021 00:04:19 -0700 (PDT) Subject: Re: [PATCH 0/4] KVM: x86: Kill off pdptrs_changed() To: Sean Christopherson , Maxim Levitsky Cc: Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210423000637.3692951-1-seanjc@google.com> From: Paolo Bonzini Message-ID: <68ff1249-2902-43d5-3dfd-35b1f14c4f90@redhat.com> Date: Fri, 23 Apr 2021 09:04:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210423000637.3692951-1-seanjc@google.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23/04/21 02:06, Sean Christopherson wrote: > Remove pdptrs_changed(), which is mostly dead anyways, and the few bits > that are still thrashing are useless. > > This conflicts with Maxim's work to migrate PDPTRs out-of-band, but I > think it will conflict in a good way as the "skip load_pdptrs()" > logic for the out-of-band case won't have to juggle this legacy crud. Maxim, can you integrate these patches in your series yourself? Thanks, Paolo > Sean Christopherson (4): > KVM: nVMX: Drop obsolete (and pointless) pdptrs_changed() check > KVM: nSVM: Drop pointless pdptrs_changed() check on nested transition > KVM: x86: Always load PDPTRs on CR3 load for SVM w/o NPT and a PAE > guest > KVM: x86: Unexport kvm_read_guest_page_mmu() > > arch/x86/include/asm/kvm_host.h | 4 ---- > arch/x86/kvm/svm/nested.c | 6 ++--- > arch/x86/kvm/vmx/nested.c | 8 +++---- > arch/x86/kvm/x86.c | 41 ++++----------------------------- > 4 files changed, 10 insertions(+), 49 deletions(-) >