From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7AF6C341AB8 for ; Sat, 30 May 2026 17:37:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780162670; cv=none; b=MTbgRszIcMrOrzbwossF2987mihJ5SAeBtCsPn2xr8ue2l2UoR52zrOUEfHxkhhg54mL6nbgA/R4VQgfJdVlcowJ2EMsxdTcihQlpTU4a4uZvRWmPZ6EiVaDrzGUl77qcBhtsL7mw8s/3tF0VpUwHPDHBWxCqyLDQpiXmMhMR/8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780162670; c=relaxed/simple; bh=CClcWYWefXJz1TGr8gJYERltJnjvvEJlgyxAfvko/xQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JW5R0mJIP4Z5scdMjIxru/EVBDmMUXDtwgcuuthPbH7mXagqbQ6aBM8rM/4B1UoIjpe88xABdCFSgtBn27GrtRjWiUqLd9v99dMcKVLyMWP+oQVIGZ+D7x3f6l9/UAPYKO4YC/xIakbV56XzUONZg/HMsvgIfyDNnoidnK2EMts= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=i5ipaRNY; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=i2nwN07w; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="i5ipaRNY"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="i2nwN07w" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64UGnOJF2552626 for ; Sat, 30 May 2026 17:37:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 1uRD66FKDWLNiktBxoDeBLGm6tf0fhPc9ZoqTh6hw3A=; b=i5ipaRNYH/QvV2Oj 2DLEIFDVVm0KAyTGUhBYSy8ORGG/iTnbDk2+U5+ksK+wPL8je+6kdR98DiLOK5Ws lr1l7J0+FLsWvyvcPyQWgeh3VnnnWgLcNy2kjLD6WLa6aFahd/5Bsndko/Wo+0/Y KTTPNst23YKeBmHbWLMf4b/5jABqU6vlO1b2oln4Tk80I592N/25egtBNYJ2Zl/w nNjHFUnb3GZtGiB7nGE2jIQFHDcB550YnbAnffejTnDPn3H+pd4Z+0a4JjbDwkmM DK0GM5HN27xKVWZg2AaWo+zKt0tZAcvBDfishEcsOK1BXriC+2/B/oAPdbQY4abW 1baPiQ== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4efs66scgn-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 30 May 2026 17:37:48 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2c0c272e532so477355ad.1 for ; Sat, 30 May 2026 10:37:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780162668; x=1780767468; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=1uRD66FKDWLNiktBxoDeBLGm6tf0fhPc9ZoqTh6hw3A=; b=i2nwN07wJY+ycLUf89f3ILRNdcQDtXArWKCSgNn0hFGoPnB9cAtU94yzi7ysiD24hu kL5PUWvUnJHtaQek3YDfFekjP/zIaG4IXEnKEP0J+TwGwiVWMCWvtUjdhVom6ap8/E2g 9Gp63+eK/e/vqyc1Mk4fhvfHhNU/OFhJPIUsxh9S3evVRC1VcmVvMsYzAG+43SBk3eRi Ki5yPFTfjQ3qCqXdo/LlNo1sjCpd6RU+3HjlHTXhv/E8oMpHC1QO8sI4wdzkPucDeILN hXNMiXJZPWdEWvJ3Yx2v9qq5snGBTvORXqrqNqyctHwleVqIRSU/+0F5U1XbRS4LluG/ mqyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780162668; x=1780767468; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1uRD66FKDWLNiktBxoDeBLGm6tf0fhPc9ZoqTh6hw3A=; b=m5wWMKk4xJ45Zo42iLMtaXSyDiQShXX4nNjLjaZ3c30tus1xF65keEhisL3YGnywHa UtXtS0PaDcDKsT7Awu51jrNSvRjKvJ5mvEO4udkXmbThLUkLjAgiDkcuxe08O0X7KATP 5QiNscI35RPyc0Jb2iu6caLEHaR3HJtYwcWR5SwvF7cHFXEoqFCo4JysrXt14iREDuOW hVT3y99iBrLs86K43djPB9lBNgFPCXZ6u9XCxuYqJWHwla2rYOJ8JADxXUWXUOiA3CPS zOyBVksnX+lmttrADGb6+pivDnbLndeegXpkLkqw15ixcyHk8XFaKiuahApHcekaL30+ DMaA== X-Forwarded-Encrypted: i=1; AFNElJ/htNrTk55xEyCOaT9yaOcu56F3bwGB7DkYf5+AkLNgWd7IgMHBWrxfW2j41kMXCPwU2Iu3VF/NwqyccAI=@vger.kernel.org X-Gm-Message-State: AOJu0Yx1W8HYU0V0uTkeluDbz9kdLVhDW/Wfpy3GKwuUkO94sv3IIhM7 Qtl1cpLAo/ne2LfN3cp40ZSBXzrBM+O35vS7p5nB791jTy8FQV9nLLn2VRhqkWuYggMskd9ctGR EMKyGLfPLo21nvsaX+4aSmBfGDRC3VGSewGtGSc0wybjhkAvJwfDqtHTWM9goY6OkiiM= X-Gm-Gg: Acq92OF+N3ZXk/PHi+WATSf1465VjI5k93gWj1TWc19od7y+PY2fP3Ze8UAK6tsych8 MubvV3/9jdno79A3xdpYZp/xNhYTk5flbn1MFKMXpxPbu+P61TzVQrnE0OxppKOsnZw014lRGE1 i8tcIXjglmevfez/nLAIoRpYBFF2SdHiPYhkpPSuxy8D6Zr7CVvGTbBhiqPgjt6VtkgE7Df3Nc9 GnbzGVWtX0vMnaU2dwkNQ2tud6gZ7rq9rc68jXz/te4MKRnPFYnYA+KBsVZiRaEG3KLcFxIbOkP WW3NUX63ujpOc2k9m39E/Vhyqt2KN9RWLJUBS7CriQlHXZMcVqDL34CPXZCLbY+DFX1EzBQDCO/ mPK76867vUvbBOBcfNyB1tKW5j0iERV+iVRfM9op4yQ767nY+svystl/ZsYsHnxQ4dsAnM00acN vs X-Received: by 2002:a17:903:244d:b0:2bd:c310:f7c9 with SMTP id d9443c01a7336-2bf367b2353mr56429845ad.2.1780162668050; Sat, 30 May 2026 10:37:48 -0700 (PDT) X-Received: by 2002:a17:903:244d:b0:2bd:c310:f7c9 with SMTP id d9443c01a7336-2bf367b2353mr56429675ad.2.1780162667589; Sat, 30 May 2026 10:37:47 -0700 (PDT) Received: from [192.168.11.104] ([124.123.82.179]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bf239fd7bfsm53050615ad.19.2026.05.30.10.37.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 30 May 2026 10:37:47 -0700 (PDT) Message-ID: <6904229c-0de5-4e91-a532-80d9d0336793@oss.qualcomm.com> Date: Sat, 30 May 2026 23:07:43 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH ath-next 0/2] wifi: ath12k: fix NULL deref when MLO link activation fails To: Wei Zhang , jeff.johnson@oss.qualcomm.com Cc: ath12k@lists.infradead.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260512044906.1735821-1-wei.zhang@oss.qualcomm.com> From: Rameshkumar Sundaram Content-Language: en-US In-Reply-To: <20260512044906.1735821-1-wei.zhang@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTMwMDE5MCBTYWx0ZWRfX6Ozcf6PC3na+ L3D3RSAsPhuECykUoodLTw3ETnLN89OZJriBLNkk6gfH21Sk/ra0+MSlD2+6967481oegVh2hWE HwQDzaQlLDdoH9iwmb4u1VwJg5xKQz3LDi6LoeDm7w3c/bPZEVm58k40DYbJMD+1gDmV+g1qFqy 2gyQ94ghabzm0gYaR9pJqHg8ZKoNEmlQgky3XMAZD046dwMeO0a/nvOTdUWwPWxmB2CYFmuRoPF 8aJleu+O0m4xNWjWCDcrqHfe5lbyfdrNnbi6HyVR+NS/CBqOg3ChKY4Z0hupU8Gya/Toj7XJFqY p9Ij62AU3GU2hL5O65ScHPl+ZxtvmYN9fqBuZSBSE+AuPKKV1evj1rEymvdVJ6UffaPX8O6WraZ EUujXpObACxOKn0O6qv9HprjU4uqRoc4RqNdR8reO2YSQC8ph0n7Ly/OEFEeqIuwzqa/96/fpHg QgngAQ2/kksyomcKYAg== X-Authority-Analysis: v=2.4 cv=X8di7mTe c=1 sm=1 tr=0 ts=6a1b206c cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=ZCREz13nqshT/on6E9YcPw==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=Bf6z4bKntrc-jtSRWE8A:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-ORIG-GUID: AH8hbKhzCdn43PEOcUHXCyO8nW0ViGbV X-Proofpoint-GUID: AH8hbKhzCdn43PEOcUHXCyO8nW0ViGbV X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-05-30_05,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 lowpriorityscore=0 phishscore=0 impostorscore=0 priorityscore=1501 bulkscore=0 adultscore=0 malwarescore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2605300190 On 5/12/2026 10:19 AM, Wei Zhang wrote: > ath12k_mac_op_change_sta_links() adds a link to ahsta->links_map > before verifying that the link's vdev is ready, allowing broken links > to be processed by subsequent operations and causing NULL dereferences. > > Patch 1 fixes three error path inconsistencies in ath12k_mac_vdev_create() > that leave arvif state or vdev resources inconsistent: a direct return on > wmi_vdev_create failure bypasses err: which clears arvif->ar; and both > failure paths in err_peer_del skip the DP peer cleanup and vdev rollback. > > Patch 2 uses arvif->is_created (made reliable by patch 1) to guard > against links with no vdev before allocating a link station, preventing > broken links from entering links_map. > > Wei Zhang (2): > wifi: ath12k: fix inconsistent arvif state in vdev_create error paths > wifi: ath12k: fix NULL deref in change_sta_links for unready link > > drivers/net/wireless/ath/ath12k/mac.c | 17 ++++++++--------- > 1 file changed, 8 insertions(+), 9 deletions(-) > > base-commit: 7b25796f571fc09a7aa6fe7efb23edccd326917d Reviewed-by: Rameshkumar Sundaram