From: Bagas Sanjaya <bagasdotme@gmail.com>
To: "Kyrie Wu (吴晗)" <Kyrie.Wu@mediatek.com>,
"nicolas.dufresne@collabora.com" <nicolas.dufresne@collabora.com>,
"mchehab@kernel.org" <mchehab@kernel.org>,
"Irui Wang (王瑞)" <Irui.Wang@mediatek.com>,
"hverkuil-cisco@xs4all.nl" <hverkuil-cisco@xs4all.nl>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"angelogioacchino.delregno@collabora.com"
<angelogioacchino.delregno@collabora.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"tfiga@chromium.org" <tfiga@chromium.org>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"Maoguang Meng (孟毛广)" <Maoguang.Meng@mediatek.com>,
Project_Global_Chrome_Upstream_Group
<Project_Global_Chrome_Upstream_Group@mediatek.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"Xia Jiang (江霞)" <Xia.Jiang@mediatek.com>
Subject: Re: [V2] media: jpeg: Fix multi-hw judgement
Date: Fri, 30 Dec 2022 16:06:10 +0700 [thread overview]
Message-ID: <69095f6d-2f1d-07ab-26ac-5f35ea80a58a@gmail.com> (raw)
In-Reply-To: <0846a7d726135d28f1da2a94eaa4c978754f9d2f.camel@mediatek.com>
On 12/29/22 15:19, Kyrie Wu (吴晗) wrote:
> On Wed, 2022-12-28 at 19:29 +0700, Bagas Sanjaya wrote:
>> On Fri, Dec 16, 2022 at 11:52:47AM +0800, Irui Wang wrote:
>> > From: kyrie wu <kyrie.wu@mediatek.com>
>> >
>> > some chips have multi-hw, but others have only one,
>> > modify the condition of multi-hw judgement
>>
>> nit: s/judgement/conditional block/ ...
>>
>> > -if (list_empty(&pdev->dev.devres_head)) {
>> > +if (!jpeg->variant->hw_arch) {
>>
>> ... like here (if block).
>>
>> Thanks.
>
> Hi Bagas,
>
> I can't get your suggestion exactly.
> Do you mean to change if (...) as follows:
> if (jpeg->variant->hw_arch)
No, not what I mean. I pointed you at the correct terminology
with your code as example.
Thanks.
--
An old man doll... just what I always wanted! - Clara
prev parent reply other threads:[~2022-12-30 9:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-16 3:52 Irui Wang
2022-12-20 9:53 ` AngeloGioacchino Del Regno
2022-12-28 7:29 ` Kyrie Wu (吴晗)
2022-12-28 12:29 ` Bagas Sanjaya
2022-12-29 8:19 ` Kyrie Wu (吴晗)
2022-12-30 9:06 ` Bagas Sanjaya [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69095f6d-2f1d-07ab-26ac-5f35ea80a58a@gmail.com \
--to=bagasdotme@gmail.com \
--cc=Irui.Wang@mediatek.com \
--cc=Kyrie.Wu@mediatek.com \
--cc=Maoguang.Meng@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=Xia.Jiang@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=nicolas.dufresne@collabora.com \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®