From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3FEE71DC99F for ; Mon, 6 Jan 2025 10:57:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736161073; cv=none; b=Juz+fMy8oRxW/pyQ4ZfAhZeS0TPIlG96FWWxO1BahhT9fvzY9ACdSE4O9DqHlKI+Mn0nky9KZEachCsmZNWB4lFBfsrYerS6qBuUFvks6I1obouoGdot5skFYHgPKOtwk0EzSfYK0CbKKZBeRQ5ZKlHUBsE1nOJef3POi/a2Dcc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736161073; c=relaxed/simple; bh=0HPjyIMcS44C+BDPMKqNONf/Zff0hoZdM9xKSHxcZLM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=f5JwIxnfIt6YB6AAse27nfrErBN9ZL0BjM+QqSlsmiuQwb+Kp5O4GcYrfGSEMPY320ZkmX1Z2o+Iqop2B/ks0v7GmKXlZjB8kkqMK/LNymcTAAJcrlC1412A40npPJsYMeB8d/okvjx3wVogiXVYagc0rpEyw7gCyg2bqSTJ6mk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=GthwMXBK; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="GthwMXBK" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736161068; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xelBfWSODcxsrEcjEs1BiG8WTAMva9NkWAeUvbujNUA=; b=GthwMXBK6YuehXGLLAmNS/PINtdzdyxH6LyE2QIPdmIX3GF2xkE+YzvQjQ3Tv3KPY16dMl cfFnW+DnK3rH0RINDoFoy1g7Yi0owjBbvH1/N0G6/1VIx66ZaBao0MuEh9NJDmovitm9zH YX3N6omZGX3cn3A7ujIdZjbExTi++0s= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-538-73vbaGsiOjixdNe3ZbTR_w-1; Mon, 06 Jan 2025 05:57:47 -0500 X-MC-Unique: 73vbaGsiOjixdNe3ZbTR_w-1 X-Mimecast-MFC-AGG-ID: 73vbaGsiOjixdNe3ZbTR_w Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-6dadae92652so341703806d6.2 for ; Mon, 06 Jan 2025 02:57:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736161067; x=1736765867; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xelBfWSODcxsrEcjEs1BiG8WTAMva9NkWAeUvbujNUA=; b=fIac9vFbIoZKO5DWpyWQT1uvb7+OLpISLpgQHVb2jBDxBGED8tQt4j5FXVnWLhCPdk gR9gT5sNGkC/INOIF/mFeDzKx2HxgDgvVwBq4AaafLdkCGmC2WzEpjH35PnJGCT5fuSC OqnXsQcldHu+zi2EJymtsgUIA8kBDQKz1LDRm/a6rT/aLWj2E/UlJUV17CkfBjApxEKp /OQzrz3Gr1v31WoTb6JuSDduiFD0q7tkPfgRbas9mpsTGTK4AvgumlvsZ2iY5QKobVfA U0n+uFaK8am1ulrr/Dj8x76rInGURnZD2K59hyw1T9of3WLvK9amsh3p/HKb+Ka2oEqa Y8qQ== X-Forwarded-Encrypted: i=1; AJvYcCUnJlU9Uth32A1vZID7d7DRHIeRx+EtrNt3lAbywsXH8TIyVtHWNh2Cu6Pke9mt2iZ2wDaPlvhtbas/ehI=@vger.kernel.org X-Gm-Message-State: AOJu0YzGRSOFZGj4yVOhsivk35Q7NQ+HvAyPyDNM1KtJkmoGjMlK6DuR 0CsbQgoIv5uq9+I4egw3PpoutPx9W+vlIINbwpAo73S6BM5AcujMSUBgfVUncAz6Wuy0BNerejC sXG8FHfBtqhqPvgHAohsrLhE/3sc2Omwp0q/tLHU4FzcUajGYORRY9K/NNUMr6w== X-Gm-Gg: ASbGncsyAbgj6LNPUuEwcWWepDg94bZAPFkTiTTJcpXyQHza2N3oaWQHPtnhy/yMAYI 6riHxEMNS9xI8ItQDrXVXmZK9nkGn/EWYqxNgfMc1XqsABMHV7f8Lv4nf9vGUCCz2zoEYCCjXec daDZD/5Fw8LAcftqFHifFQRe2gKmOFAQwZ5Wy8ZmTwYkENpz398fmY7RJh1Jpqzr4nqWIUrDC7y 2fna7NoJkhYhWonr1YPdAdfxVJGdgPnMcG2RQL/gNAWXoJlyob6d1pAPwBA1n9TmYijHIeVJLYV zibZlBVjyNW6ZAGApW3AALM= X-Received: by 2002:a05:6214:20aa:b0:6da:dbf0:9640 with SMTP id 6a1803df08f44-6dd2332ed7cmr917796756d6.7.1736161066973; Mon, 06 Jan 2025 02:57:46 -0800 (PST) X-Google-Smtp-Source: AGHT+IHLwbrQGbMn9NL9Ah4F4vcDj6k2WKY2Yw/cnHzXjmWPCRq8m97NVu8ZZRP56C6MfG+D7akdOA== X-Received: by 2002:a05:6214:20aa:b0:6da:dbf0:9640 with SMTP id 6a1803df08f44-6dd2332ed7cmr917796606d6.7.1736161066729; Mon, 06 Jan 2025 02:57:46 -0800 (PST) Received: from ?IPV6:2a01:e0a:59e:9d80:527b:9dff:feef:3874? ([2a01:e0a:59e:9d80:527b:9dff:feef:3874]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-46a3eb178a7sm174272571cf.62.2025.01.06.02.57.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Jan 2025 02:57:45 -0800 (PST) Message-ID: <690b7702-42be-4c23-a9bd-c1e8f09b0623@redhat.com> Date: Mon, 6 Jan 2025 11:57:41 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V2 15/46] arm64/sysreg: Add register fields for PFAR_EL1 Content-Language: en-US To: Anshuman Khandual , linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, maz@kernel.org Cc: ryan.roberts@arm.com, Oliver Upton , James Morse , Suzuki K Poulose , Catalin Marinas , Will Deacon , Mark Brown References: <20241210055311.780688-1-anshuman.khandual@arm.com> <20241210055311.780688-16-anshuman.khandual@arm.com> <5203176c-2646-425b-b375-edb7931ef54f@redhat.com> From: Eric Auger In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Anshuman, On 12/19/24 4:13 AM, Anshuman Khandual wrote: > > > On 12/18/24 21:12, Eric Auger wrote: >> Hi Anshuman, >> >> On 12/10/24 06:52, Anshuman Khandual wrote: >>> This adds register fields for PFAR_EL1 as per the definitions based on >>> DDI0601 2024-09. >>> >>> Cc: Catalin Marinas >>> Cc: Will Deacon >>> Cc: Mark Brown >>> Cc: linux-arm-kernel@lists.infradead.org >>> Cc: linux-kernel@vger.kernel.org >>> Signed-off-by: Anshuman Khandual >>> --- >>> arch/arm64/tools/sysreg | 7 +++++++ >>> 1 file changed, 7 insertions(+) >>> >>> diff --git a/arch/arm64/tools/sysreg b/arch/arm64/tools/sysreg >>> index 18b814ff2c41..e33edb41721a 100644 >>> --- a/arch/arm64/tools/sysreg >>> +++ b/arch/arm64/tools/sysreg >>> @@ -3533,3 +3533,10 @@ Field 5 F >>> Field 4 P >>> Field 3:0 Align >>> EndSysreg >>> + >>> +Sysreg PFAR_EL1 3 0 6 0 5 >>> +Field 63 NS >>> +Field 62 NSE >>> +Res0 61:56 >>> +Field 55:0 PA >> Just wondering: part of the PA definition depends on FEAT_D128 or >> FEAT_LPA and the reset field value is UNKNOWN if the feature is not >> available. Shouldn't introduce separate fields directly? > Generated PFAR_EL1_PA_MASK aka GENMASK_ULL(55, 0) should cover all the > cases for PA i.e 48 bits, LPA, D128 etc. Although individual use cases > will have to trim the mask subsequently as required. > > Are you suggesting something like the following instead where the user > will have to concatenate these fields selectively to find the required > PA mask ? > > Field 55:52 PA_D128 > Field 51:48 PA_LPA > Field 47:0 PA Yes that was my suggestion. Thanks Eric