From: Ira Weiny <ira.weiny@intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Ira Weiny <ira.weiny@intel.com>, <nvdimm@lists.linux.dev>,
<linux-kernel@vger.kernel.org>
Cc: Dan Williams <dan.j.williams@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Dave Jiang <dave.jiang@intel.com>
Subject: Re: [PATCH v1 1/1] libnvdimm/labels: Get rid of redundant 'else'
Date: Wed, 5 Nov 2025 13:18:46 -0600 [thread overview]
Message-ID: <690ba316b541c_2848c61001f@iweiny-mobl.notmuch> (raw)
In-Reply-To: <20251105183743.1800500-1-andriy.shevchenko@linux.intel.com>
Andy Shevchenko wrote:
> In the snippets like the following
>
> if (...)
> return / goto / break / continue ...;
> else
> ...
>
> the 'else' is redundant. Get rid of it.
What is the reason for this change? This results in 0.6% code size
reduction. Is that really worth this effort?
Ira
[snip]
next prev parent reply other threads:[~2025-11-05 19:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-05 18:37 Andy Shevchenko
2025-11-05 19:18 ` Ira Weiny [this message]
2025-11-06 7:37 ` Andy Shevchenko
2025-11-06 20:57 ` Alison Schofield
2025-11-07 0:46 ` Ira Weiny
2025-11-07 7:39 ` Andy Shevchenko
2025-11-07 16:23 ` Ira Weiny
2025-11-09 22:11 ` Alison Schofield
2025-11-10 8:50 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=690ba316b541c_2848c61001f@iweiny-mobl.notmuch \
--to=ira.weiny@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®