From: "Arınç ÜNAL" <arinc.unal@arinc9.com>
To: Rob Herring <robh@kernel.org>
Cc: "Sean Wang" <sean.wang@mediatek.com>,
linux-arm-kernel@lists.infradead.org,
"Luiz Angelo Daros de Luca" <luizluca@gmail.com>,
"Bernhard Rosenkränzer" <bero@baylibre.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Hui Liu" <hui.liu@mediatek.com>,
"Landen Chao" <Landen.Chao@mediatek.com>,
linux-kernel@vger.kernel.org,
"Sergio Paracuellos" <sergio.paracuellos@gmail.com>,
"Del Regno" <angelogioacchino.delregno@collabora.com>,
erkin.bozoglu@xeront.com, linux-gpio@vger.kernel.org,
"Zhiyong Tao" <zhiyong.tao@mediatek.com>,
"Daniel Santos" <daniel.santos@pobox.com>,
"Frank Wunderlich" <frank-w@public-files.de>,
"Rob Herring" <robh+dt@kernel.org>,
"Daniel Golle" <daniel@makrotopia.org>,
"Andy Teng" <andy.teng@mediatek.com>,
"William Dean" <williamsukatube@gmail.com>,
devicetree@vger.kernel.org,
"Linus Walleij" <linus.walleij@linaro.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Sean Wang" <sean.wang@kernel.org>,
linux-mediatek@lists.infradead.org, linux-mips@vger.kernel.org,
"DENG Qingfang" <dqfext@gmail.com>
Subject: Re: [PATCH v2 15/21] dt-bindings: pinctrl: {mediatek,ralink}: fix formatting
Date: Fri, 17 Mar 2023 20:51:54 +0300 [thread overview]
Message-ID: <690e29ee-5e40-5f57-59d7-7c1167852cfb@arinc9.com> (raw)
In-Reply-To: <c64d9f88-75ca-3a6c-b5c2-6e4b1a161d5f@arinc9.com>
On 14.03.2023 18:38, Arınç ÜNAL wrote:
> On 14.03.2023 17:10, Rob Herring wrote:
>>
>> On Mon, 13 Mar 2023 23:59:15 +0300, arinc9.unal@gmail.com wrote:
>>> From: Arınç ÜNAL <arinc.unal@arinc9.com>
>>>
>>> Change the style of description properties to plain style where
>>> there's no
>>> need to preserve the line endings, and vice versa.
>>>
>>> Fit the schemas to 80 columns for each line.
>>>
>>> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
>>> Reviewed-by: Rob Herring <robh@kernel.org>
>>> ---
>>> .../pinctrl/mediatek,mt65xx-pinctrl.yaml | 22 +++---
>>> .../pinctrl/mediatek,mt6779-pinctrl.yaml | 33 +++++----
>>> .../pinctrl/mediatek,mt6795-pinctrl.yaml | 33 +++++----
>>> .../pinctrl/mediatek,mt7620-pinctrl.yaml | 2 +-
>>> .../pinctrl/mediatek,mt7621-pinctrl.yaml | 2 +-
>>> .../pinctrl/mediatek,mt7622-pinctrl.yaml | 26 +++----
>>> .../pinctrl/mediatek,mt7981-pinctrl.yaml | 33 +++++----
>>> .../pinctrl/mediatek,mt7986-pinctrl.yaml | 68 ++++++++---------
>>> .../pinctrl/mediatek,mt8183-pinctrl.yaml | 26 ++++---
>>> .../pinctrl/mediatek,mt8186-pinctrl.yaml | 47 ++++++------
>>> .../pinctrl/mediatek,mt8188-pinctrl.yaml | 74 ++++++++++---------
>>> .../pinctrl/mediatek,mt8192-pinctrl.yaml | 47 ++++++------
>>> .../pinctrl/mediatek,mt8195-pinctrl.yaml | 41 +++++-----
>>> .../pinctrl/mediatek,mt8365-pinctrl.yaml | 28 +++----
>>> .../pinctrl/ralink,rt2880-pinctrl.yaml | 2 +-
>>> .../pinctrl/ralink,rt305x-pinctrl.yaml | 2 +-
>>> .../pinctrl/ralink,rt3883-pinctrl.yaml | 2 +-
>>> 17 files changed, 254 insertions(+), 234 deletions(-)
>>>
>>
>> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
>> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>>
>> yamllint warnings/errors:
>> ./Documentation/devicetree/bindings/pinctrl/mediatek,mt6795-pinctrl.yaml:103:16: [warning] wrong indentation: expected 14 but found 15 (indentation)
>> ./Documentation/devicetree/bindings/pinctrl/mediatek,mt6795-pinctrl.yaml:113:16: [warning] wrong indentation: expected 14 but found 15 (indentation)
>>
>> dtschema/dtc warnings/errors:
>>
>> doc reference errors (make refcheckdocs):
>>
>> See
>> https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230313205921.35342-16-arinc.unal@arinc9.com
>>
>> The base for the series is generally the latest rc1. A different
>> dependency
>> should be noted in *this* patch.
>>
>> If you already ran 'make dt_binding_check' and didn't see the above
>> error(s), then make sure 'yamllint' is installed and dt-schema is up to
>> date:
>>
>> pip3 install dtschema --upgrade
>>
>> Please check and re-submit after running the above command yourself. Note
>> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
>> your schema. However, it must be unset to test all examples with your
>> schema.
>
> I do see the warning. Looks like the wrong indentation was there before
> my patch series. I'll address that as well on this patch on v3.
>
> Will you review the rest of v2?
I guess that's a no. I'll send v3 soon.
Arınç
next prev parent reply other threads:[~2023-03-17 17:52 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-13 20:59 [PATCH 00/21] pinctrl: ralink: fix ABI, improve driver, move to mediatek, improve dt-bindings arinc9.unal
2023-03-13 20:59 ` [PATCH v2 01/21] pinctrl: ralink: reintroduce ralink,rt2880-pinmux compatible string arinc9.unal
2023-03-13 20:59 ` [PATCH v2 02/21] pinctrl: ralink: rt305x: add new compatible string for every SoC arinc9.unal
2023-03-13 20:59 ` [PATCH v2 03/21] pinctrl: ralink: mt7620: split out to mt76x8 arinc9.unal
2023-03-13 20:59 ` [PATCH v2 04/21] pinctrl: ralink: move to mediatek as mtmips arinc9.unal
2023-03-13 20:59 ` [PATCH v2 05/21] pinctrl: mediatek: remove OF_GPIO as reverse dependency arinc9.unal
2023-03-13 20:59 ` [PATCH v2 06/21] dt-bindings: pinctrl: ralink: move additionalProperties to top arinc9.unal
2023-03-17 18:54 ` Rob Herring
2023-03-13 20:59 ` [PATCH v2 07/21] dt-bindings: pinctrl: ralink: drop quotes from referred schemas arinc9.unal
2023-03-17 18:54 ` Rob Herring
2023-03-13 20:59 ` [PATCH v2 08/21] dt-bindings: pinctrl: ralink: add new compatible strings arinc9.unal
2023-03-17 18:54 ` Rob Herring
2023-03-13 20:59 ` [PATCH v2 09/21] dt-bindings: pinctrl: ralink: {mt7620,mt7621}: rename to mediatek arinc9.unal
2023-03-17 18:58 ` Rob Herring
2023-03-17 20:43 ` Arınç ÜNAL
2023-03-13 20:59 ` [PATCH v2 10/21] dt-bindings: pinctrl: mediatek: mt6795: rename to mediatek,mt6795-pinctrl arinc9.unal
2023-03-13 20:59 ` [PATCH v2 11/21] dt-bindings: pinctrl: mediatek: mt8186: rename to mediatek,mt8186-pinctrl arinc9.unal
2023-03-13 20:59 ` [PATCH v2 12/21] dt-bindings: pinctrl: mediatek: mt8192: rename to mediatek,mt8192-pinctrl arinc9.unal
2023-03-13 20:59 ` [PATCH v2 13/21] dt-bindings: pinctrl: mediatek: mt8195: rename to mediatek,mt8195-pinctrl arinc9.unal
2023-03-13 20:59 ` [PATCH v2 14/21] dt-bindings: pinctrl: mediatek: fix naming inconsistency arinc9.unal
2023-03-13 20:59 ` [PATCH v2 15/21] dt-bindings: pinctrl: {mediatek,ralink}: fix formatting arinc9.unal
2023-03-14 14:10 ` Rob Herring
2023-03-14 15:38 ` Arınç ÜNAL
2023-03-17 17:51 ` Arınç ÜNAL [this message]
2023-03-13 20:59 ` [PATCH v2 16/21] dt-bindings: pinctrl: mediatek: fix pinmux header location arinc9.unal
2023-03-17 18:58 ` Rob Herring
2023-03-13 20:59 ` [PATCH v2 17/21] dt-bindings: pinctrl: mediatek: drop quotes from referred schemas arinc9.unal
2023-03-17 18:59 ` Rob Herring
2023-03-13 20:59 ` [PATCH v2 18/21] dt-bindings: pinctrl: mediatek: mt7986: fix patternProperties regex arinc9.unal
2023-03-17 19:01 ` Rob Herring
2023-03-13 20:59 ` [PATCH v2 19/21] dt-bindings: pinctrl: ralink: rt305x: split binding arinc9.unal
2023-03-13 20:59 ` [PATCH v2 20/21] dt-bindings: pinctrl: mediatek: mt7620: " arinc9.unal
2023-03-17 19:03 ` Rob Herring
2023-03-17 20:38 ` Arınç ÜNAL
2023-03-13 20:59 ` [PATCH v2 21/21] MAINTAINERS: move ralink pinctrl to mediatek mips pinctrl arinc9.unal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=690e29ee-5e40-5f57-59d7-7c1167852cfb@arinc9.com \
--to=arinc.unal@arinc9.com \
--cc=Landen.Chao@mediatek.com \
--cc=andy.teng@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bero@baylibre.com \
--cc=daniel.santos@pobox.com \
--cc=daniel@makrotopia.org \
--cc=devicetree@vger.kernel.org \
--cc=dqfext@gmail.com \
--cc=erkin.bozoglu@xeront.com \
--cc=frank-w@public-files.de \
--cc=hui.liu@mediatek.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mips@vger.kernel.org \
--cc=luizluca@gmail.com \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sean.wang@kernel.org \
--cc=sean.wang@mediatek.com \
--cc=sergio.paracuellos@gmail.com \
--cc=williamsukatube@gmail.com \
--cc=zhiyong.tao@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®