From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB904322774 for ; Fri, 7 Nov 2025 17:58:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762538325; cv=none; b=krgWXRA/k77BkxCHq/Yn8powaH/KxMgNogzqqcPwsiIBsB/zq7pxU/wW189OTDcYmWGSqQV1KTt1AFtUFujtXIaO27c8mEotlrJ0ENULwIvJRKIYP48uIwCDW/7NqDTodEjtcZM9OPvxRArOEixoPONeVfOqNd/EeD0mTY//kpk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762538325; c=relaxed/simple; bh=zcMWRLy2zTfSrZa7T+hCLM/4/N7QvFnX+Xx3zpNBBGo=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=m0cEuq7ZvPRYeRax4hYBQxPc98mOmrG3a0HB9MJuUImf77Qi36ktkajjQ9zVm73F4j7+yAVa+sIscFxhIEE90YaP83hqzyEcx/oDlRKMOOdEP/AaNIzsI8rPVW9Rtz+2WOssp/Bbv/e9aNSwnErP91LnKdbVPUzkX2NfJ59Xayk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kMXcaIBP; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kMXcaIBP" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-429c48e05aeso640788f8f.1 for ; Fri, 07 Nov 2025 09:58:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1762538322; x=1763143122; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=4Hy8PEdE/fLtMOp8zZJDYe1K5v8P86jnmwdVl01gCF0=; b=kMXcaIBP4T1ajPvHI5jq/hMge6Y30jyfxD7ylSxWWlnTwkKPXwJYlxcFt5R8hjXuk4 DfJP6GP7u5O1D1Mx+4pS3l3MF+yrs1E5jtt85imr7GgLu1+emYH3OoHjbJrd/YoZcHCi qisvGamcAryoccGe8o6F04cDhB6+hOUV0rkcZ1qth5Zs3x6dZVYKK9OM77o4Ku/Qljie f5Quju1TJA6J/FsRiy0iQs3EbYx4MgBELz7LuAZhMsGtzQJQboydhzCovQb5/gGQspFQ U4HT52hsHwupqDYwIsSyEw20ElnMuIlWn1Q4vDcSs4lD/wSXrmABQTW8olaDvhRxrebl FP/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762538322; x=1763143122; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4Hy8PEdE/fLtMOp8zZJDYe1K5v8P86jnmwdVl01gCF0=; b=NIutQ2jfqi6gtkugOpr4taWb8Xg5sW+x9FcfJkoMm0Nc6pAnV6u5BpPaFjp0RsRZzu KeajsFLGOfBb0pBxP8R5RWJVvkRrVrkIQDLE8CcW3BSgK+10VW9oyLvz18c7iLPKDnAi 0eFARXW7wzkI9JDEUrVHZnCarv0EP53Q16hBca0hxW1uholDEPS6F/0VHOPev2kAUCJr f2xfTrXLDUYfI3t+UwyCCjVKvSrFxaX1ryNKmIcYzQM2WK4CykNca1rWp55yYFfyGZ8R 9gJgiSdLFiBKihj87LQAMldleNBEmRCa7qGx/28bBCQb7XvW6MdBkUK9Il6hgdHU+clV MYVA== X-Forwarded-Encrypted: i=1; AJvYcCVaNphpVFuOzOAiW3318uE3ODICjh8gNc6vxNP1gcOJsN7fcQJ9/OcCb3YhkivH3Ivk94rgvI4f1n//f8k=@vger.kernel.org X-Gm-Message-State: AOJu0Yx5kofzK7sfCN1O4UfM5mHw6S4Fl7u4JiYLlVZFqTSvKKW2nCR4 yXvAeKmQf1kbpLnj8SXN15rodBt4J+i2eCo0H1gWcg1XsoVZMhWNXiRY X-Gm-Gg: ASbGncsa5UICdmC4fXoUK/Sa01LkXGZ9A5fLBfMNjeBhfAUIJGXUN0YGX/ttIbT2OHY z+lRy9MDR9Jx/cNH9HPuxKOmUslvcKvlUcrXiBR9TS+BAuPXhX0968Uy1fmHRbGLXWACoGpHUJH q6/D8yyoKHz22YyMZV8YB51C5a4feWqNO4+TIvW8vTg9tP4n2Th6mc4yr/P25O55+++M4zfP5/M +Pyhu9JjQyosIuZ+K0b5ZkoMupjSHn8bdU17ZHzwZ1HNojIqMbz46O3en57265057SsM97IhcLo F5e76JcyW0eBPHSdFJ1vrUGPQZiciVURpl/9BShWdI/+3MQijIjjUnmJMhz4QxMetVzpPf25cw/ prWLFgsfJik/o2nqdHX2jitDSZ52IGkluhTxJHwWv2MOwXBJjDuc6Fqr7hArlSn+FmoF5XtS3X7 DazBuFvc5B3yTKrh3aLpmj3cKZd4ar X-Google-Smtp-Source: AGHT+IHxrsG4B2duEE/+GCKG0QyJVFEsIc/yuwXnmYOAcLA/FUrE6rMl803DqisMTH4v+FhxV5j+Ag== X-Received: by 2002:a05:6000:26c9:b0:429:ef72:c33a with SMTP id ffacd0b85a97d-42b26f4be9dmr2506029f8f.3.1762538322141; Fri, 07 Nov 2025 09:58:42 -0800 (PST) Received: from Ansuel-XPS. (93-34-90-37.ip49.fastwebnet.it. [93.34.90.37]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477640fb801sm45371425e9.11.2025.11.07.09.58.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Nov 2025 09:58:41 -0800 (PST) Message-ID: <690e3351.050a0220.15e225.cf82@mx.google.com> X-Google-Original-Message-ID: Date: Fri, 7 Nov 2025 18:58:38 +0100 From: Christian Marangi To: Conor Dooley Cc: Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Lorenzo Bianconi , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 4/5] dt-bindings: pinctrl: airoha: Document AN7583 Pin Controller References: <20251106235713.1794668-1-ansuelsmth@gmail.com> <20251106235713.1794668-5-ansuelsmth@gmail.com> <20251107-washstand-motivator-c5e5e5d30dae@spud> <690e311d.5d0a0220.2f18f8.2b28@mx.google.com> <20251107-jasmine-unarmored-e3f5d544a1b7@spud> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251107-jasmine-unarmored-e3f5d544a1b7@spud> On Fri, Nov 07, 2025 at 05:55:43PM +0000, Conor Dooley wrote: > On Fri, Nov 07, 2025 at 06:49:13PM +0100, Christian Marangi wrote: > > On Fri, Nov 07, 2025 at 05:24:21PM +0000, Conor Dooley wrote: > > > On Fri, Nov 07, 2025 at 12:57:07AM +0100, Christian Marangi wrote: > > > > Document Airoha AN7583 Pin Controller based on Airoha EN7581 with some > > > > minor difference on some function group (PCM and LED gpio). > > > > > > > > To not bloat the EN7581 schema with massive if condition, use a > > > > dedicated YAML schema for Airoha AN7583. > > > > > > You went to more effort than I would have here with that conditional! > > > > > > > Well it was suggested by Rob and it's honestly a copy paste of en7581 > > with the relevant thing changed. > > > > > > +patternProperties: > > > > + '-pins$': > > > > + type: object > > > > + > > > > + patternProperties: > > > > + '^mux(-|$)': > > > > + type: object > > > > > > What's up with this regex? Why does it allow either - or $? > > > > It's to permit either mux-* or unique node name with mux. Pattern is > > also used by mt7622 or other schema. Other use mux- to require a name > > after the mux. > > Ah right, because you can have the config properties like drive > strength in the mux node, so sometimes a -pins has one mux node (mux:) if > all pins share settings and sometimes there could be multiple, which > requires a suffix. > Reviewed-by: Conor Dooley > pw-bot: not-applicable Mhhh why not-applicable ? :( I rebased on top of linux-next, did you spot any conflict? -- Ansuel