From: Andrew Lunn <andrew@lunn.ch>
To: Zhiyuan Wan <kmlinuxm@gmail.com>
Cc: kuba@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, willy.liu@realtek.com,
Yuki Lee <febrieac@outlook.com>
Subject: Re: [PATCH 1/2] net: phy: realtek: add combo mode support for RTL8211FS
Date: Tue, 3 Dec 2024 00:52:53 +0100 [thread overview]
Message-ID: <690e556f-a486-41e3-99ef-c29cb0a26d83@lunn.ch> (raw)
In-Reply-To: <20241202195029.2045633-1-kmlinuxm@gmail.com>
> +static int rtl8211f_config_aneg(struct phy_device *phydev)
> +{
> + int ret;
> +
> + struct rtl821x_priv *priv = phydev->priv;
> +
> + ret = genphy_read_abilities(phydev);
> + if (ret < 0)
> + return ret;
> +
> + linkmode_copy(phydev->advertising, phydev->supported);
This is all very unusual for config_aneg(). genphy_read_abilities()
will have been done very early on during phy_probe(). So why do it
now? And why overwrite how the user might of configured what is to be
advertised?
> +static int rtl8211f_read_status(struct phy_device *phydev)
> +{
> + int ret;
> + struct rtl821x_priv *priv = phydev->priv;
> + bool changed = false;
> +
> + if (rtl8211f_mode(phydev) != priv->lastmode) {
> + changed = true;
> + ret = rtl8211f_config_aneg(phydev);
> + if (ret < 0)
> + return ret;
> +
> + ret = genphy_restart_aneg(phydev);
> + if (ret < 0)
> + return ret;
> + }
> +
> + return genphy_c37_read_status(phydev, &changed);
> +}
So you are assuming read_status() is called once per second? But what
about when interrupts are used?
You might want to look at how the marvell driver does this. It is not
great, but better than this.
Andrew
---
pw-bot: cr
next prev parent reply other threads:[~2024-12-02 23:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-02 19:50 Zhiyuan Wan
2024-12-02 19:50 ` [PATCH 2/2] net: phy: realtek: add dt property to disable broadcast PHY address Zhiyuan Wan
2024-12-03 0:04 ` Andrew Lunn
2024-12-03 3:46 ` [PATCH v2 1/2] net: phy: realtek: disable broadcast address feature of rtl8211f Zhiyuan Wan
2024-12-03 3:58 ` Andrew Lunn
2024-12-03 4:26 ` [PATCH v3 " Zhiyuan Wan
2024-12-03 6:50 ` Heiner Kallweit
2024-12-03 7:18 ` [PATCH net-next " Zhiyuan Wan
2024-12-03 7:38 ` Heiner Kallweit
2024-12-03 8:35 ` Zhiyuan Wan
2024-12-03 9:52 ` Heiner Kallweit
2024-12-02 23:52 ` Andrew Lunn [this message]
2024-12-03 3:08 ` [PATCH 1/2] net: phy: realtek: add combo mode support for RTL8211FS 万致远
2024-12-03 3:53 ` Andrew Lunn
2024-12-03 4:42 ` 万致远
2024-12-03 4:44 ` 万致远
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=690e556f-a486-41e3-99ef-c29cb0a26d83@lunn.ch \
--to=andrew@lunn.ch \
--cc=febrieac@outlook.com \
--cc=kmlinuxm@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=willy.liu@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®