From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 985672153CB for ; Thu, 9 Jan 2025 09:37:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736415462; cv=none; b=Veo7l7Fwsmv65z6jPR166Nj8IWmw0iE0BsnaD6zgocfQcWUp/I2vpLYxTi39yNF/OM9QT613od273xm2BYqYwyUVrzJK7lIDxAGtrlUT6jV5ALP9d77GjVcTiC3IJnzfoC+vHq/SbpI+jXI7ziKJUU1ieWm8bmrRvElZmTrbsR0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736415462; c=relaxed/simple; bh=fU8s7w7K7tvNKOVFFKMzVGMmQWFxUprl9XPXzD7hEBM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=oVOGT3r5XFAoQgOsd+Rl5vBXhI8g0nNhH65s19zogQJnfHm/wIy9wKowx+ggM9YyajmQIJDgHkdm52ArZko9Xz7CC8s6uoFkj3XVA3FS4iLyksihy805uPA4R+unoRu+4/cyZPzjvh7bZfqvB45HrDdAzR1kmyiCfJ/MYPDApCU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=AFOQmSTz; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="AFOQmSTz" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736415459; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zlguHxDSv6f2kjam2JyYQgfvVb9DaN2aNRpw2oQi+Nc=; b=AFOQmSTz7/A8IlVZytHZ0Dhy7TskflXSK/T9F9r8LVEAhlhhCSfij4ChApqt4aWOI35b+E 9Ovc9l8qpIH2/iKCrxFAPmYz2b1j40pR09uGrMm1PTmBtQK+smOZKPTHzrcchlzsvWywZS 4oZTwJuw3Y8ksPHL9byn+RB68/c/T08= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-592-tZ5FiauIMMmocN6HLKEFpw-1; Thu, 09 Jan 2025 04:37:38 -0500 X-MC-Unique: tZ5FiauIMMmocN6HLKEFpw-1 X-Mimecast-MFC-AGG-ID: tZ5FiauIMMmocN6HLKEFpw Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-7b6e178d4f8so121900085a.3 for ; Thu, 09 Jan 2025 01:37:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736415457; x=1737020257; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zlguHxDSv6f2kjam2JyYQgfvVb9DaN2aNRpw2oQi+Nc=; b=HkpDj26s7TMXXRRNmy9kIIkAY+ZRJFswQTaV13UhBjvftDdUa45Q3fgtV92PXvAEdq VlQEfc+2+xK4FHGO9MKdLi0wpPwUJGGR5DS6ljA3SiQURC9bDeIcKfOxooCkp7jYHpXF i8jsWq7WX9HHM6xiPY7wwprA1bwZnxJrnwtEWD06NIdNgcN5o8nvtVVh59Hu9KbZL+AZ GqsfZgLVJj9U06OUWTMohym+B60OqwXEozTZGVXL4yv3UGmRtUYYHyCIVvq8JANm2lPD 2fF512R41gFuLy1HDLR5sd3IS3i+6JnN801Vp1scX64Px7E+iqO1IaTO3n2uQs2vxBkL TjPQ== X-Forwarded-Encrypted: i=1; AJvYcCWnkXB2318OrBxWLHPJo/pDXX8WTSO0KcsgKonLL+ghh08mL04p3ca3amgRSFnNvpMKScchnqSirepKSGY=@vger.kernel.org X-Gm-Message-State: AOJu0YwjKBtfhsRkYt31VauxOIWnEO87AeJb0Gkcq86sfpU/gxvHkSCU ryRqHGW2qXO+TQs/j8yJLw95eK9kWiphw3sz0fCTuHPavew9yyQmVa0SGEalDZLa/qAyztxz3yH FKBem2HCR53te62jJ77DjOTCxOBcbyxJp+ZerO93H7lBHrHWztXLwZ3B65QmIyA== X-Gm-Gg: ASbGnctFWQhkyX/Qx3zoNEzzs5HnpwkCk3tx2fwPgYTzvr9MGoqwL1Fu0WuuzR5bb0Y jjF88SdS8Gf7/cwjJI2GL07g4tFcGR/s6CDL0Nf1pu50UkCfbEEZ2OFrpzQTPdf4I+iuk2gK0X6 U2BB+o7wiR6mEbLbUBXGxMYIDUwNQ50qQsA0dYv2PTm6w3BNAC6/8AbJK0QO0TNa8fYIvnBj8Zv bbgki9NLe/jhT44xLfNJF8M+vKlWbz96wczDMzi4LdQtMGrCaeyi3Uy+RlFUyo5b0qsfsyNF25H /Wwn736i X-Received: by 2002:a05:620a:2443:b0:7b6:72bc:df67 with SMTP id af79cd13be357-7bcd96fa150mr889456285a.1.1736415457738; Thu, 09 Jan 2025 01:37:37 -0800 (PST) X-Google-Smtp-Source: AGHT+IG2F6Ru6Ok/aPxAZik1gN132odWyGCZsSRKmKWIOUestXgwhfS9+7n6PwHtMVo8+7sYD3e+Kg== X-Received: by 2002:a05:620a:2443:b0:7b6:72bc:df67 with SMTP id af79cd13be357-7bcd96fa150mr889452685a.1.1736415457435; Thu, 09 Jan 2025 01:37:37 -0800 (PST) Received: from [192.168.88.253] (146-241-2-244.dyn.eolo.it. [146.241.2.244]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7bce3237e3bsm49254385a.23.2025.01.09.01.37.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Jan 2025 01:37:37 -0800 (PST) Message-ID: <690fc7d2-c235-450c-981a-a889f976936e@redhat.com> Date: Thu, 9 Jan 2025 10:37:32 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 08/14] net: pse-pd: Split ethtool_get_status into multiple callbacks To: Jakub Kicinski , Kory Maincent Cc: Oleksij Rempel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Simon Horman , Donald Hunter , Jonathan Corbet , Liam Girdwood , Mark Brown , Thomas Petazzoni , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-doc@vger.kernel.org, Kyle Swenson , Dent Project , kernel@pengutronix.de, Maxime Chevallier References: <20250104-b4-feature_poe_arrange-v1-0-92f804bd74ed@bootlin.com> <20250104-b4-feature_poe_arrange-v1-8-92f804bd74ed@bootlin.com> <20250107171554.742dcf59@kernel.org> <20250108102736.18c8a58f@kmaincent-XPS-13-7390> <20250108093645.72947028@kernel.org> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20250108093645.72947028@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/8/25 6:36 PM, Jakub Kicinski wrote: > On Wed, 8 Jan 2025 10:27:36 +0100 Kory Maincent wrote: >>> Is there a reason this is defined in ethtool.h? >> >> I moved in to ethtool because the PSE drivers does not need it anymore. >> I can keep it in pse.h. >> >>> I have a weak preference towards keeping it in pse-pd/pse.h >>> since touching ethtool.h rebuilds bulk of networking code. >>> From that perspective it's also suboptimal that pse-pd/pse.h >>> pulls in ethtool.h. >> >> Do you prefer the other way around, ethtool.h pulls in pse.h? > > No, no, I'd say the order of deceasing preference is: > - headers are independent > - smaller header includes bigger one > - bigger one includes smaller one In this specific case, given the widespread inclusion of ethtool.h, I think keeping the struct definition in pse.h is necessary - the reduced incremental builds time would be a good enough reason for it. Thanks! Paolo