From: Bart Van Assche <bvanassche@acm.org>
To: "Uwe Kleine-König (The Capable Hub)"
<u.kleine-koenig@baylibre.com>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
Peter Wang <peter.wang@mediatek.com>,
Bean Huo <beanhuo@micron.com>, Can Guo <can.guo@oss.qualcomm.com>,
Archana Patni <archana.patni@intel.com>,
Markus Schneider-Pargmann <msp@baylibre.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] ufs: tc-dwc-g210-pci: Simplify initialization of pci_device_id array
Date: Tue, 12 May 2026 13:03:39 -0700 [thread overview]
Message-ID: <691169b9-9602-4443-976f-4a46d7b07e3f@acm.org> (raw)
In-Reply-To: <ff015bf46ad395702f40c85c8359fd24957e7224.1777968942.git.u.kleine-koenig@baylibre.com>
On 5/5/26 1:28 AM, Uwe Kleine-König (The Capable Hub) wrote:
> A list initializer is hard to parse for a human if they don't see or know
> the order of the members of struct pci_devcie_id. So use the PCI_VDEVICE
> macro which is much more ideomatic and skip assigning explicit zeros.
^^^^^^^^^
idiomatic
Otherwise this patch looks good to me.
Thanks,
Bart.
next prev parent reply other threads:[~2026-05-12 20:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-05 8:25 [PATCH 0/2] ufs: Rework pci_device_id initialization Uwe Kleine-König (The Capable Hub)
2026-05-05 8:28 ` [PATCH 1/2] ufs: tc-dwc-g210-pci: Simplify initialization of pci_device_id array Uwe Kleine-König (The Capable Hub)
2026-05-12 20:03 ` Bart Van Assche [this message]
2026-05-05 8:28 ` [PATCH 2/2] ufs: ufshcd-pci: Use PCI_VDEVICE and named initializers for pci array Uwe Kleine-König (The Capable Hub)
2026-05-05 9:25 ` Adrian Hunter
2026-05-12 20:05 ` Bart Van Assche
2026-05-15 1:40 ` [PATCH 0/2] ufs: Rework pci_device_id initialization Martin K. Petersen
2026-05-23 3:14 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=691169b9-9602-4443-976f-4a46d7b07e3f@acm.org \
--to=bvanassche@acm.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=adrian.hunter@intel.com \
--cc=archana.patni@intel.com \
--cc=beanhuo@micron.com \
--cc=can.guo@oss.qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=msp@baylibre.com \
--cc=peter.wang@mediatek.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®