From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Josh Boyer <jwboyer@fedoraproject.org>
Cc: "Zheng, Lv" <lv.zheng@intel.com>, Lv Zheng <zetalog@gmail.com>,
"Wysocki, Rafael J" <rafael.j.wysocki@intel.com>,
"Brown, Len" <len.brown@intel.com>,
"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"Moore, Robert" <robert.moore@intel.com>
Subject: Re: [PATCH 20/27] ACPICA: Tables: Fix invalid pointer accesses in acpi_tb_parse_root_table().
Date: Tue, 06 May 2014 02:43:44 +0200 [thread overview]
Message-ID: <6913597.VSrPZ98ePF@vostro.rjw.lan> (raw)
In-Reply-To: <CA+5PVA58527N76yJ8yNZPAbOz6YepR3RHXtjaV6t0i1nCYwcXg@mail.gmail.com>
On Monday, May 05, 2014 08:42:46 AM Josh Boyer wrote:
> On Mon, May 5, 2014 at 12:23 AM, Zheng, Lv <lv.zheng@intel.com> wrote:
> > Hi, Rafael
> >
> >> From: linux-acpi-owner@vger.kernel.org [mailto:linux-acpi-owner@vger.kernel.org] On Behalf Of Rafael J. Wysocki
> >> Sent: Monday, May 05, 2014 8:43 AM
> >>
> >> On Saturday, May 03, 2014 08:59:14 AM Josh Boyer wrote:
> >> > On Tue, Apr 29, 2014 at 10:05 PM, Lv Zheng <lv.zheng@intel.com> wrote:
> >> > > The commit of back porting Linux XSDT validation mechanism has introduced
> >> > > a regreession:
> >> > > Commit: 671cc68dc61f029d44b43a681356078e02d8dab8
> >> > > Subject: ACPICA: Back port and refine validation of the XSDT root table.
> >> > > There is a pointer still accessed after unmapping.
> >> > >
> >> > > This patch fixes this issue. Lv Zheng.
> >> > >
> >> > > Buglink: https://bugzilla.kernel.org/show_bug.cgi?id=73911
> >> > > Buglink: https://bugs.archlinux.org/task/39811
> >> > > Signed-off-by: Lv Zheng <lv.zheng@intel.com>
> >> > > Reported-and-tested-by: Bruce Chiarelli <mano155@gmail.com>
> >> > > Reported-and-tested-by: Spyros Stathopoulos <spystath@gmail.com>
> >> > > Signed-off-by: Bob Moore <robert.moore@intel.com>
> >> > > Cc: <stable@vger.kernel.org> # 3.14.x: 671cc68: ACPICA: Back port and refine validation of the XSDT root table.
> >> >
> >> > This patch should get into 3.15-rcX soon. It fixes a known regression
> >> > that prevents booting on machines with AMI firmware, and that is
> >> > present in 3.14 so we need it for stable as well. Rafael?
> >>
> >> Lv, is it safe to take this patch alone into 3.15-rc?
> >
> > Yes, it's safe to only take this patch to be a regression fix.
>
> FWIW, Fedora is carrying this on top of 3.14.2 already, and people
> with the impacted machines say it's working for them. So I agree it
> should be safe.
>
> Thanks to the both of you.
OK, queued up for 3.15, thanks!
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
next prev parent reply other threads:[~2014-05-06 0:27 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-30 2:03 [PATCH 00/27] ACPICA: 20140424 Release Lv Zheng
2014-04-30 2:03 ` [PATCH 01/27] ACPICA: Utilities: Cleanup obsoleted global variables Lv Zheng
2014-04-30 2:03 ` [PATCH 02/27] ACPICA: Utilities: Deploy ACPI_DEBUGGER_EXEC for ACPI_DEBUGGER enabled code in utglobal.c Lv Zheng
2014-05-06 7:53 ` Pavel Machek
2014-05-06 8:58 ` Zheng, Lv
2014-05-06 11:08 ` Pavel Machek
2014-05-06 13:54 ` Zheng, Lv
2014-04-30 2:03 ` [PATCH 03/27] ACPICA: acpidump: Fix code issue in invoking fread in the loop Lv Zheng
2014-04-30 2:03 ` [PATCH 04/27] ACPICA: Update global variable definitions. No functional change Lv Zheng
2014-04-30 2:03 ` [PATCH 05/27] ACPICA: Update acpi_buffer_to_resource interface Lv Zheng
2014-04-30 2:04 ` [PATCH 06/27] ACPICA: Add support for LPIT table Lv Zheng
2014-04-30 2:04 ` [PATCH 07/27] ACPICA: Add support for _LPD and _PRP methods Lv Zheng
2014-04-30 2:04 ` [PATCH 08/27] ACPICA: Update handling of PCI ID lists Lv Zheng
2014-04-30 2:04 ` [PATCH 09/27] ACPICA: Comment updates - no functional change Lv Zheng
2014-04-30 2:04 ` [PATCH 10/27] ACPICA: OSL: Move external globals from utglobal.c to acpixf.h using ACPI_INIT_GLOBAL/ACPI_GLOBAL Lv Zheng
2014-04-30 2:04 ` [PATCH 11/27] ACPICA: OSL: Add configurability for memory allocation macros Lv Zheng
2014-04-30 2:04 ` [PATCH 12/27] ACPICA: OSL: Add configurability for error message functions Lv Zheng
2014-04-30 2:04 ` [PATCH 13/27] ACPICA: OSL: Add configurability for debug output functions Lv Zheng
2014-04-30 2:05 ` [PATCH 14/27] ACPICA: OSL: Add section to collect the divergence in acpixf.h Lv Zheng
2014-04-30 2:05 ` [PATCH 15/27] ACPICA: OSL: Add configurability for generic external functions Lv Zheng
2014-04-30 2:05 ` [PATCH 16/27] ACPICA: Linux header: Add support for stubbed externals Lv Zheng
2014-04-30 2:05 ` [PATCH 17/27] ACPICA: acpidump: Fix truncated RSDP signature validation Lv Zheng
2014-04-30 2:05 ` [PATCH 18/27] ACPICA: Back port of _PRP update Lv Zheng
2014-04-30 2:05 ` [PATCH 19/27] ACPICA: Back port of improvements on exception code Lv Zheng
2014-04-30 2:05 ` [PATCH 20/27] ACPICA: Tables: Fix invalid pointer accesses in acpi_tb_parse_root_table() Lv Zheng
2014-05-03 12:59 ` Josh Boyer
2014-05-05 0:43 ` Rafael J. Wysocki
2014-05-05 4:23 ` Zheng, Lv
2014-05-05 12:42 ` Josh Boyer
2014-05-06 0:43 ` Rafael J. Wysocki [this message]
2014-05-06 1:39 ` Zheng, Lv
2014-04-30 2:05 ` [PATCH 21/27] ACPICA: acpidump: Add support to force using RSDT Lv Zheng
2014-04-30 2:05 ` [PATCH 22/27] ACPICA: Tables: Add new mechanism to skip NULL entries in RSDT and XSDT Lv Zheng
2014-04-30 2:06 ` [PATCH 23/27] ACPICA: Tables: Remove old mechanism to validate if XSDT contains NULL entries Lv Zheng
2014-04-30 2:06 ` [PATCH 24/27] ACPICA: Remove extraneous error message for large number of GPEs Lv Zheng
2014-04-30 2:06 ` [PATCH 25/27] ACPICA: Events: Update GPE handling and initialization code Lv Zheng
2014-04-30 2:06 ` [PATCH 26/27] ACPICA: Comment/format update, no functional change Lv Zheng
2014-04-30 2:06 ` [PATCH 27/27] ACPICA: Update version to 20140424 Lv Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6913597.VSrPZ98ePF@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=jwboyer@fedoraproject.org \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lv.zheng@intel.com \
--cc=rafael.j.wysocki@intel.com \
--cc=robert.moore@intel.com \
--cc=zetalog@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®