From: Jes Sorensen <jes.sorensen@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>,
linux-wireless <linux-wireless@vger.kernel.org>
Cc: Stanislaw Gruszka <sgruszka@redhat.com>,
David Miller <davem@davemloft.net>,
Helmut Schaa <helmut.schaa@googlemail.com>,
Kalle Valo <kvalo@codeaurora.org>,
Daniel Golle <daniel@makrotopia.org>,
Mathias Kresin <dev@kresin.me>,
Johannes Berg <johannes.berg@intel.com>,
Serge Vasilugin <vasilugin@yandex.ru>,
Roman Yeryomin <roman@advem.lv>,
Networking <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Tom Psyborg <pozega.tomislav@gmail.com>
Subject: Re: [PATCH v2 00/10] rt2x00: rt2x00: improve calling conventions for register accessors
Date: Mon, 22 May 2017 14:03:39 -0400 [thread overview]
Message-ID: <69171f99-0844-cfe1-7bcb-72d61f56c3c5@gmail.com> (raw)
In-Reply-To: <20170517144702.1381136-1-arnd@arndb.de>
On 05/17/2017 10:46 AM, Arnd Bergmann wrote:
> I've managed to split up my long patch into a series of reasonble
> steps now.
>
> The first two are required to fix a regression from commit 41977e86c984
> ("rt2x00: add support for MT7620"), the rest are just cleanups to
> have a consistent state across all the register access functions.
>
> Arnd
Nice work! This is a textbook example of how to do this the right way!
Reviewed-by: Jes Sorensen <jsorensen@fb.com>
Jes
prev parent reply other threads:[~2017-05-22 18:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-17 14:46 Arnd Bergmann
2017-05-17 14:46 ` [PATCH v2 01/10] rt2x00: change function pointers " Arnd Bergmann
2017-05-24 13:46 ` [v2, " Kalle Valo
2017-05-17 14:46 ` [PATCH v2 02/10] rt2x00: convert rt2800_rfcsr_read return type Arnd Bergmann
2017-05-17 14:46 ` [PATCH v2 03/10] rt2x00: convert rt2x00_rf_read " Arnd Bergmann
2017-05-17 14:46 ` [PATCH v2 04/10] rt2x00: convert rt2x00mmio_register_read " Arnd Bergmann
2017-05-17 14:46 ` [PATCH v2 05/10] rt2x00: convert rt2x00usb_register_read " Arnd Bergmann
2017-05-17 14:46 ` [PATCH v2 06/10] rt2x00: convert rt2800_register_read " Arnd Bergmann
2017-05-17 14:46 ` [PATCH v2 07/10] rt2x00: convert rt2*_bbp_read " Arnd Bergmann
2017-05-17 14:47 ` [PATCH v2 08/10] rt2x00: convert rt2x00_eeprom_read " Arnd Bergmann
2017-05-17 14:47 ` [PATCH v2 09/10] rt2x00: convert rt2800_eeprom_read " Arnd Bergmann
2017-05-17 14:47 ` [PATCH v2 10/10] rt2x00: convert rt2x00_desc_read " Arnd Bergmann
2017-05-19 5:18 ` [PATCH v2 00/10] rt2x00: rt2x00: improve calling conventions for register accessors Kalle Valo
2017-05-19 6:50 ` Arnd Bergmann
2017-05-19 7:15 ` Kalle Valo
2017-05-19 7:21 ` Arnd Bergmann
[not found] ` <CAKR_QVJGxWF8+ZGGn08XiOgpYVGSjwQwqJoP10fY_bjfRg-uzw@mail.gmail.com>
2017-05-19 6:55 ` Arnd Bergmann
2017-05-19 7:12 ` Kalle Valo
[not found] ` <CAKR_QVLf5Yn3En2DD4Pwbc2+EKaO9xGB0qU3MWQrNWNjZkx1CA@mail.gmail.com>
2017-05-19 12:20 ` Arnd Bergmann
2017-05-22 18:03 ` Jes Sorensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69171f99-0844-cfe1-7bcb-72d61f56c3c5@gmail.com \
--to=jes.sorensen@gmail.com \
--cc=arnd@arndb.de \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=dev@kresin.me \
--cc=helmut.schaa@googlemail.com \
--cc=johannes.berg@intel.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pozega.tomislav@gmail.com \
--cc=roman@advem.lv \
--cc=sgruszka@redhat.com \
--cc=vasilugin@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®