From: Alexey Kardashevskiy <aik@amd.com>
To: Borislav Petkov <bp@alien8.de>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
Ingo Molnar <mingo@redhat.com>,
Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH kernel v2] x86/compressed/64: reduce #VC nesting for intercepted CPUID for SEV-SNP guest
Date: Tue, 3 Oct 2023 12:45:48 +1100 [thread overview]
Message-ID: <6917dfcb-651b-45a0-9dc7-c42f765dea02@amd.com> (raw)
In-Reply-To: <20231001095322.GAZRlBkle6JC2rfM6u@fat_crate.local>
On 1/10/23 20:53, Borislav Petkov wrote:
> On Sun, Oct 01, 2023 at 08:40:30PM +1100, Alexey Kardashevskiy wrote:
>> Ingo says different, who wins? :)
>
> I do: a function gives you type checking - a macro doesn't.
The macro is a wrapper for the sev_es_ghcb_hv_call() function with type
checking.
>>> Then, it should be defined only in sev-shared.c for now.
>>
>> sev-shared.c makes me sad. Including .c is not ... nice,
>
> There's a point in doing things this way.
>
>> I would avoid adding stuff to it at any cost.
>
> Care to give a technical argument why or is it just general sadness?
> Because I don't care about non-technical sentiments.
No it is not technical, it is my ignorance :)
For example why inat.c/insn.c are included and not linked? Cannot linux
compile arch/x86/lib/ files twice into two different .o, for compressed
and running kernels? Is not more logical place for sev-shared.c in
arch/x86/lib/sev.c?
>>> Furthermore, it should not be called "rdmsr" or so but something like
>>>
>>> ghcb_prot_read_msr()
>>>
>>> or so to denote that it is using the GHCB protocol to read the MSR. I'm
>>> sure it'll gain more users with time.
>>
>> What is "prot" going to signify?
>
> "... or so to denote that it is using the GHCB protocol..."
> ^^^^^^^^
>
> it is right there.
Ah right. I am used (after some grepping - not just me) to "prot" ==
"protected", "protocol" would be "proto". imho not needed here but alright.
>> And what about Tom's "x86/sev: Fix SNP CPUID requests to the hypervisor",
>> are you taking that one or I have to repost this one and the Tom's patch?
>
> Yes, use this branch:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/bp/bp.git/log/?h=tip-x86-urgent
Oh cool, thanks!
> Thx.
>
--
Alexey
prev parent reply other threads:[~2023-10-03 1:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-26 4:05 Alexey Kardashevskiy
2023-09-26 18:28 ` Tom Lendacky
2023-09-27 8:50 ` [tip: x86/mm] x86/sev: Reduce #VC nesting for intercepted CPUID for SEV-SNP guest, to fix nesting crash tip-bot2 for Alexey Kardashevskiy
2023-09-27 9:48 ` [PATCH kernel v2] x86/compressed/64: reduce #VC nesting for intercepted CPUID for SEV-SNP guest Ingo Molnar
2023-09-27 11:22 ` Borislav Petkov
2023-09-28 9:32 ` Ingo Molnar
2023-09-30 7:17 ` Borislav Petkov
2023-10-01 9:40 ` Alexey Kardashevskiy
2023-10-01 9:53 ` Borislav Petkov
2023-10-01 12:17 ` Ingo Molnar
2023-10-01 12:31 ` Ingo Molnar
2023-10-03 1:45 ` Alexey Kardashevskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6917dfcb-651b-45a0-9dc7-c42f765dea02@amd.com \
--to=aik@amd.com \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®