From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B1A53081C1 for ; Sat, 15 Nov 2025 19:55:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763236505; cv=none; b=sVOcSE+xWR54ZnF1q1mZkKXd+j1eFpSr/N0cvetPVPBf2jfHgDqNF8u81q2J5eV1l1D2Nfhi7PpNsckvmQChTX3yXqhae07fN5rnZRSlPc3z7G3oXLqSbA8GUGnLiEXJrk26q4Hux0ETsCZDBmpuHcwtOxiL+gt3WDm+tMExw3A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763236505; c=relaxed/simple; bh=Wiwp1Q+OvYMcsGdBWtQcyoDwE7jV4tPDZZbsA8/uaMY=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TfhGG//AGPNsHhQn914SfiwHG7fNbfGksoCuhfjHQ6468WVdFDRUgeMd5YhWavbgVeejUsQ9QzTzyPX1eLS3tB0YeIQgJjixgxR3PXwiKTiCu9gDEaewxtrBRditUdMnc0LBM+St1vQUGiSaszaXuWWP2ybLq9/o/GkXpddR0dI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HNVf+g02; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HNVf+g02" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-42b3c965ca9so1424701f8f.1 for ; Sat, 15 Nov 2025 11:55:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763236500; x=1763841300; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=SBUMvmH/FE2NkP+rH9gUjMt6Dd3cDonURWl8AiaS8Jg=; b=HNVf+g02oqgXwDiqrK+iE1J1VccJkQ62WuZHuRXXTR+eH0XgyXLlIFv2xu/URQNim2 g56lHaeX9KnoyVyaVpo/MR+08SjZpIUXQ18DgWyAL8oZlg3RDW5dcp0DgKfA+2RMVhZ9 DMEJtCFL4NPyYb4G7ldFl4623c6CoPzb1SiP362/s2pD8++17Rawdwz3vmftTy+khWxX ehE0HDndkc/li2+k4dZkP9T/05BUnn5VmgzmEovtrRDYqtQqA0qytL2t51Y9p1sZ3SCE I7yFK+DSt7YLudAdrtDVUBSXuSIU83hzewqyqocLkoJx8A29etb0e0AZ04eGDVNc/09K S8mQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763236500; x=1763841300; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SBUMvmH/FE2NkP+rH9gUjMt6Dd3cDonURWl8AiaS8Jg=; b=Oecn2nBmlJK09vmw+mVivW4cjYH/qowTCaw56E69Wwlvmoj7VDkKfF9OtqKkOR2/u5 D0WOOIoixeTZTgVKn5+KQcvR3FLk1W5Ve+kVhyZUpUcUUJsra5EBzSGv8or1dLB6qIGz j8ch9QUlQbSLRyj8NfsdHuIzSyPiQ43CiAXVIii8xew2riaH+j31Vrv2qC63tON88J/b W7tNYp0KZw4dhvqq9JewNGSeT2WdCeuGMnpYx/KiOkp7jyR2QYiEiezP7SdE2yjD75Mn fbP19JvJuf7rCpVGZzYBM7VrQRONhsQyseFvD3tnIL75aUMeqaEbNfD6Kw8UerExRLf4 ylRQ== X-Forwarded-Encrypted: i=1; AJvYcCX/UfqdNeiNt+gx5dywNvaEu8puSv5ZIaUf7o+23qNvEenjG1HaNezm33aVnzwSJDeuo8kRAeYhjbs+qQs=@vger.kernel.org X-Gm-Message-State: AOJu0Ywut+j7Rr/5kCWzZ7lHRmYh/gVB8PwtjtTa3O7ExSgrzxx5MpHl DsmkondXrLNWbI6aBmRZAXC3e37axPJgNnZTNLlkaFefG9V780OdB1dS X-Gm-Gg: ASbGncuffyF22D4O2/pRpIe1da11looogpO8yQzXACQfp1S2ceDKlp3bbJlUWpNF0DY ZOXmOk5on7x13TSTWD8UaIVCQNPI6dMLKaoPGExS/w8f/6Oxza/1suW3OhQV+/visuE9U08p7zj 0wQRLEX27/ORp2lI9DBaHsSICZZu50hYRH4kPs2sOVdls5eMJxh2HDyDMn/ZoTQ8N9sx+RVKRqn XDE4zGHdiHCOZhI61ktT+tfm2dVpN3lmBcFvxjSfRpz6TlX0VWvlazylh1p+bpRzpo2ME8gUmn+ iX6z4Vj/JhhYf+ifptRnH97/HNTBz2g8LrwK+f0XK5c59xJfjJk9HxftHe/rmCoTsHh7Fg0H4ri ExpEmabhMsJ8ajLqwaEGKaT05DBCMxK6YPuEkPxcxROGN0l25xUFPIy28YOPynvDhfrL54rxbIX pW3fXebCZuIr6K9ZbnJUXGf5eh4Od4bSpQY9NeG3SUsrH+Gs8HOmO3 X-Google-Smtp-Source: AGHT+IHSPwnyZ4YZke/ZsJzOSxMHljj18mEXOamqRXYe9YIBBAmYoQ9mxQRgJ1dWDU6O1s+9DDZ4pA== X-Received: by 2002:a05:6000:2f83:b0:42b:3ee9:4772 with SMTP id ffacd0b85a97d-42b5937618emr6490889f8f.52.1763236499409; Sat, 15 Nov 2025 11:54:59 -0800 (PST) Received: from Ansuel-XPS. (host-87-10-15-59.retail.telecomitalia.it. [87.10.15.59]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42b53e7ae2dsm17786147f8f.5.2025.11.15.11.54.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Nov 2025 11:54:59 -0800 (PST) Message-ID: <6918da93.df0a0220.10a972.69d2@mx.google.com> X-Google-Original-Message-ID: Date: Sat, 15 Nov 2025 20:54:52 +0100 From: Christian Marangi To: Chukun Pan Cc: Lorenzo Bianconi , Linus Walleij , Matthias Brugger , angelogioacchino.delregno@collabora.com, Sean Wang , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH 1/1] pinctrl: airoha: fix pinctrl function mismatch issue References: <20251115100000.177791-1-amadeus@jmu.edu.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251115100000.177791-1-amadeus@jmu.edu.cn> On Sat, Nov 15, 2025 at 06:00:00PM +0800, Chukun Pan wrote: > The blamed commit made the following changes: > > -#define PINCTRL_FUNC_DESC(id)... > - .desc = PINCTRL_PINFUNCTION(#id, ... > +#define PINCTRL_FUNC_DESC(id, table)... > + .desc = PINCTRL_PINFUNCTION(#id, ... > > - PINCTRL_FUNC_DESC(pon)... > + PINCTRL_FUNC_DESC("pon", pon)... > > It's clear that the id of funcs doesn't match the definition. > Remove redundant #string from the definition to fix this issue: > pinctrl-airoha ...: invalid function mdio in map table > > Fixes: 4043b0c45f85 ("pinctrl: airoha: generalize pins/group/function/confs handling") > Signed-off-by: Chukun Pan Acked-by: Christian Marangi > --- > drivers/pinctrl/mediatek/pinctrl-airoha.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/mediatek/pinctrl-airoha.c b/drivers/pinctrl/mediatek/pinctrl-airoha.c > index bfcedc7f920b..18c952e44229 100644 > --- a/drivers/pinctrl/mediatek/pinctrl-airoha.c > +++ b/drivers/pinctrl/mediatek/pinctrl-airoha.c > @@ -35,7 +35,7 @@ > > #define PINCTRL_FUNC_DESC(id, table) \ > { \ > - .desc = PINCTRL_PINFUNCTION(#id, table##_groups, \ > + .desc = PINCTRL_PINFUNCTION(id, table##_groups, \ > ARRAY_SIZE(table##_groups)),\ > .groups = table##_func_group, \ > .group_size = ARRAY_SIZE(table##_func_group), \ > -- > 2.25.1 > -- Ansuel