From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DE41C433FE for ; Fri, 15 Oct 2021 15:00:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ED7DF611CE for ; Fri, 15 Oct 2021 15:00:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240727AbhJOPDE (ORCPT ); Fri, 15 Oct 2021 11:03:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35134 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240639AbhJOPDC (ORCPT ); Fri, 15 Oct 2021 11:03:02 -0400 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E482C061762 for ; Fri, 15 Oct 2021 08:00:56 -0700 (PDT) Received: by mail-wr1-x42c.google.com with SMTP id y3so27150084wrl.1 for ; Fri, 15 Oct 2021 08:00:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=reply-to:subject:to:references:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=RBjjLeiWguUvJEs61LGvxzcOuVVwGqpZvu6xGLNcQxE=; b=Itr/Erp+2n16kmSlIzgLZ7us7a3qCYej2DFLFJtKE7utAoqwfiU1p032ZmfVUwJrvQ MNmp1vhX2U3vxiYdEFGItNPK4SQn1+VqY8QsZAtqM87WDBHNJf6V+XmVLlTQs42gc6kb T9kZ+fNu2gfkOAeWwQBOk92IA2HQsbaEYcWkOaO/P28PhlAYw4poa1K1IeC+J3IIgP1i htj2mq+VNF0LuhV8wkelX6oycFnzBZ+gnZaXZgOITdwZvi++GLKyQIPMJT0QSEy5HyBf kZA9vs/gFxbd7iH/5hP2JcssLc9aUhkzLVUjP8JhJVo+1HC3vlR0U1phgjRm7euBLV5e rZqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:reply-to:subject:to:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=RBjjLeiWguUvJEs61LGvxzcOuVVwGqpZvu6xGLNcQxE=; b=nzTZG2vZY72b27XtV8ZmlixH4i8fBJduPiA50zFrVbMHWptlhqSEuy52Em0Wx/9ieP pYFRF1g/3tFfe7Sc36zHHlABx3eyOidxuyJH4rWm/+NEfSmXVMXxVRYtbGTZSx/NrUTI e1YHJyRap5IGtYIc2q8sRX52f7uilhj5zJVHQVTm3vilLfr+pX+AVBgKZ1Elhilwau7D e5SX/PeLxQk3/u6HhEVNbiCfXeT8nGUdqPcoT0GOGrel2HRy6bRONS4vAuiOTIKbNowW obkny9Unu8MKzE6J0S0DxgiKt2WaYianKwryc/wHlZcbgds6gFVXlpG9YPf8kYdpAC8e IcCg== X-Gm-Message-State: AOAM532WcMTJt2XFrpg8GT2Q/dutzBPU9lOqPUStNhGI4tJSLYn5fq53 DBfqoUd7fYFfk4N09Qa4r1Pn3cMRB1c8Bg== X-Google-Smtp-Source: ABdhPJw3V0tV2tqFwx5yiba7x713EFDNGe3fhRlXpAn+qCCXXHMAMNVbT05amOnKCklh4pF7y+mogQ== X-Received: by 2002:a5d:64e2:: with SMTP id g2mr14917796wri.253.1634310054940; Fri, 15 Oct 2021 08:00:54 -0700 (PDT) Received: from ?IPv6:2a01:e0a:410:bb00:a58d:ec4:bbb2:aed8? ([2a01:e0a:410:bb00:a58d:ec4:bbb2:aed8]) by smtp.gmail.com with ESMTPSA id o8sm11730076wme.38.2021.10.15.08.00.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Oct 2021 08:00:54 -0700 (PDT) Reply-To: nicolas.dichtel@6wind.com Subject: Re: [ovs-dev] [PATCH net-next v7] net: openvswitch: IPv6: Add IPv6 extension header support To: Ilya Maximets , Toms Atteka , netdev@vger.kernel.org, pshelar@ovn.org, davem@davemloft.net, kuba@kernel.org, dev@openvswitch.org, linux-kernel@vger.kernel.org References: <20211014211828.291213-1-cpp.code.lv@gmail.com> <1d0a5e90-b878-61a1-99af-35702b72f2d9@ovn.org> From: Nicolas Dichtel Organization: 6WIND Message-ID: <69204286-6dad-dade-f749-8603da82eb48@6wind.com> Date: Fri, 15 Oct 2021 17:00:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <1d0a5e90-b878-61a1-99af-35702b72f2d9@ovn.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 15/10/2021 à 15:56, Ilya Maximets a écrit : [snip] > Not a full review, but, I think, that we should not add paddings, and > define OVS_KEY_ATTR_IPV6_EXTHDRS before the OVS_KEY_ATTR_TUNNEL_INFO > instead. See my comments for v6: +1