From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753695AbcK2R5j (ORCPT ); Tue, 29 Nov 2016 12:57:39 -0500 Received: from mga01.intel.com ([192.55.52.88]:1664 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755394AbcK2R51 (ORCPT ); Tue, 29 Nov 2016 12:57:27 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,717,1473145200"; d="scan'208";a="11159204" Subject: Re: [RFC 1/4] mm: Define coherent device memory node To: Anshuman Khandual , linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <1479824388-30446-1-git-send-email-khandual@linux.vnet.ibm.com> <1479824388-30446-2-git-send-email-khandual@linux.vnet.ibm.com> Cc: mhocko@suse.com, vbabka@suse.cz, mgorman@suse.de, minchan@kernel.org, aneesh.kumar@linux.vnet.ibm.com, bsingharora@gmail.com, srikar@linux.vnet.ibm.com, haren@linux.vnet.ibm.com, jglisse@redhat.com From: Dave Hansen Message-ID: <692074f0-184f-e506-40a1-8fc078d1e706@intel.com> Date: Tue, 29 Nov 2016 09:57:26 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1479824388-30446-2-git-send-email-khandual@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/22/2016 06:19 AM, Anshuman Khandual wrote: > @@ -393,6 +393,9 @@ enum node_states { > N_MEMORY = N_HIGH_MEMORY, > #endif > N_CPU, /* The node has one or more cpus */ > +#ifdef CONFIG_COHERENT_DEVICE > + N_COHERENT_DEVICE, > +#endif > NR_NODE_STATES > }; Don't we really want this to be N_MEMORY_ISOLATED? Or, better yet, N_MEMORY_UNISOLATED so that we can just drop the bitmap in for N_MEMORY and not have to do any bit manipulation operations at runtime.